HBASE-24777 InfoServer support ipv6 host and port #2147

utf7 · 2020-07-27T03:21:02Z

HBASE-24777 InfoServer support ipv6 host and port

Apache-HBase · 2020-07-27T04:18:58Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 45s	master passed
+1 💚	checkstyle	0m 14s	master passed
+1 💚	spotbugs	0m 36s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 23s	the patch passed
-0 ⚠️	checkstyle	0m 13s	hbase-http: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 1s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	0m 42s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 13s	The patch does not generate ASF License warnings.
		27m 38s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2147/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2147
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux dab63553a233 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `975cdf7`
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2147/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-http.txt
Max. process+thread count	94 (vs. ulimit of 12500)
modules	C: hbase-http U: hbase-http
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2147/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-07-27T04:41:46Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 40s	master passed
+1 💚	compile	0m 21s	master passed
+1 💚	shadedjars	5m 45s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 17s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 30s	the patch passed
+1 💚	compile	0m 20s	the patch passed
+1 💚	javac	0m 20s	the patch passed
+1 💚	shadedjars	5m 45s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 16s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 42s	hbase-http in the patch passed.
		22m 9s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2147/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2147
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 24c3ce0fca78 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `975cdf7`
Default Java	1.8.0_232
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2147/1/testReport/
Max. process+thread count	532 (vs. ulimit of 12500)
modules	C: hbase-http U: hbase-http
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2147/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-07-27T05:06:38Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 24s	master passed
+1 💚	compile	0m 25s	master passed
+1 💚	shadedjars	6m 14s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 17s	hbase-http in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 3s	the patch passed
+1 💚	compile	0m 22s	the patch passed
+1 💚	javac	0m 22s	the patch passed
+1 💚	shadedjars	5m 49s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 18s	hbase-http in the patch failed.
		_ Other Tests _
+1 💚	unit	0m 39s	hbase-http in the patch passed.
		24m 8s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2147/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2147
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 805a81c6ca28 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `975cdf7`
Default Java	2020-01-14
javadoc	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2147/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-http.txt
javadoc	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2147/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-http.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2147/1/testReport/
Max. process+thread count	518 (vs. ulimit of 12500)
modules	C: hbase-http U: hbase-http
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2147/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-07-27T07:19:41Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 32s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 1s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 52s	master passed
+1 💚	checkstyle	0m 16s	master passed
+1 💚	spotbugs	0m 36s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 31s	the patch passed
+1 💚	checkstyle	0m 13s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 43s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	0m 46s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 15s	The patch does not generate ASF License warnings.
		30m 18s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2147/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2147
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux cfce498787f3 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `975cdf7`
Max. process+thread count	94 (vs. ulimit of 12500)
modules	C: hbase-http U: hbase-http
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2147/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-07-27T07:31:16Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 2s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 48s	master passed
+1 💚	compile	0m 20s	master passed
+1 💚	shadedjars	5m 33s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 18s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 27s	the patch passed
+1 💚	compile	0m 20s	the patch passed
+1 💚	javac	0m 20s	the patch passed
+1 💚	shadedjars	5m 33s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 16s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 40s	hbase-http in the patch passed.
		22m 16s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2147/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2147
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux a93ee111f8c7 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `975cdf7`
Default Java	1.8.0_232
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2147/2/testReport/
Max. process+thread count	469 (vs. ulimit of 12500)
modules	C: hbase-http U: hbase-http
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2147/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-07-27T07:46:09Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 32s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 13s	master passed
+1 💚	compile	0m 24s	master passed
+1 💚	shadedjars	7m 7s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 20s	hbase-http in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 33s	the patch passed
+1 💚	compile	0m 23s	the patch passed
+1 💚	javac	0m 23s	the patch passed
+1 💚	shadedjars	6m 12s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 20s	hbase-http in the patch failed.
		_ Other Tests _
+1 💚	unit	0m 49s	hbase-http in the patch passed.
		25m 50s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2147/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2147
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux bc161cd4f3e0 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `975cdf7`
Default Java	2020-01-14
javadoc	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2147/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-http.txt
javadoc	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2147/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-http.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2147/2/testReport/
Max. process+thread count	494 (vs. ulimit of 12500)
modules	C: hbase-http U: hbase-http
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2147/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

utf7 · 2020-07-27T07:54:35Z

@Apache9 @infraio @anoopsjohn mind have a look ,small patch ,don't know why yetus failed

and the patch doesn't apply branch-2.2/branch-2.1, what should I do ?

make another push , like :

push origin origin branch-2.1:HBASE-214777

virajjasani

+1, nice change. Can you also add unit test for IPv6 host, port?

Apache9 · 2020-07-27T09:08:10Z

@Apache9 @infraio @anoopsjohn mind have a look ,small patch ,don't know why yetus failed

and the patch doesn't apply branch-2.2/branch-2.1, what should I do ?

make another push , like :

push origin origin branch-2.1:HBASE-214777

branch-2.1 is dead, so just ignore it. Please open another PR for branch-2.2.

Apache9 · 2020-07-27T09:10:17Z

And for the UT, I think it could be another issue. I do not know if we have any IPv6 related UTs in our code base, as it has special requirements on the env?

virajjasani · 2020-07-27T09:58:27Z

Even if we have some way to mock, it would be fine, but anyways, can be taken as a separate task.

virajjasani

+1

utf7 · 2020-07-27T11:37:08Z

thanks for review @virajjasani @Apache9

utf7 · 2020-07-27T12:06:34Z

#2154 for branch-2.2

Closes #2147 Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Viraj Jasani <[email protected]>

Closes apache#2147 Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Viraj Jasani <[email protected]>

Closes apache#2147 Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Viraj Jasani <[email protected]> (cherry picked from commit 5eb4b87) Change-Id: I355d602a00192e607bca7c23beadbf6c82da059c

HBASE-24777 InfoServer support ipv6 host and port

3b500fa

HBASE-24777 InfoServer support ipv6 host and port

15ffd3b

virajjasani reviewed Jul 27, 2020

View reviewed changes

Apache9 approved these changes Jul 27, 2020

View reviewed changes

virajjasani approved these changes Jul 27, 2020

View reviewed changes

virajjasani closed this in 82d0990 Jul 27, 2020

virajjasani pushed a commit that referenced this pull request Jul 27, 2020

HBASE-24777 InfoServer support ipv6 host and port

8f31b12

Closes #2147 Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Viraj Jasani <[email protected]>

virajjasani pushed a commit that referenced this pull request Jul 27, 2020

HBASE-24777 InfoServer support ipv6 host and port

93d9246

Closes #2147 Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Viraj Jasani <[email protected]>

virajjasani pushed a commit that referenced this pull request Jul 27, 2020

HBASE-24777 InfoServer support ipv6 host and port

5eb4b87

Closes #2147 Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Viraj Jasani <[email protected]>

virajjasani pushed a commit that referenced this pull request Jul 27, 2020

HBASE-24777 InfoServer support ipv6 host and port

b154f20

Closes #2147 Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Viraj Jasani <[email protected]>

clarax pushed a commit to clarax/hbase that referenced this pull request Nov 15, 2020

HBASE-24777 InfoServer support ipv6 host and port

13bcdfe

Closes apache#2147 Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Viraj Jasani <[email protected]>

HBASE-24777 InfoServer support ipv6 host and port #2147

HBASE-24777 InfoServer support ipv6 host and port #2147

Uh oh!

Conversation

utf7 commented Jul 27, 2020

Uh oh!

Apache-HBase commented Jul 27, 2020

Uh oh!

Apache-HBase commented Jul 27, 2020

Uh oh!

Apache-HBase commented Jul 27, 2020

Uh oh!

Apache-HBase commented Jul 27, 2020

Uh oh!

Apache-HBase commented Jul 27, 2020

Uh oh!

Apache-HBase commented Jul 27, 2020

Uh oh!

utf7 commented Jul 27, 2020

Uh oh!

virajjasani left a comment

Choose a reason for hiding this comment

Uh oh!

Apache9 commented Jul 27, 2020

Uh oh!

Apache9 commented Jul 27, 2020

Uh oh!

virajjasani commented Jul 27, 2020

Uh oh!

virajjasani left a comment

Choose a reason for hiding this comment

Uh oh!

utf7 commented Jul 27, 2020

Uh oh!

utf7 commented Jul 27, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants