Skip to content

HBASE-24808 skip empty log cleaner delegate class names (WAS => cleaner.CleanerChore: Can NOT create CleanerDelegate= Cla… #2181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
saintstack merged 1 commit into from
Aug 3, 2020
Merged

HBASE-24808 skip empty log cleaner delegate class names (WAS => cleaner.CleanerChore: Can NOT create CleanerDelegate= Cla… #2181

saintstack merged 1 commit into from
Aug 3, 2020

Conversation

@saintstack
Copy link
Contributor

@saintstack saintstack commented Jul 31, 2020

…ssNotFoundException

anoopsjohn
anoopsjohn approved these changes Aug 1, 2020
View reviewed changes
hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
*/
private void initCleanerChain(String confKey) {
this.cleanersChain = new LinkedList<>();
String[] logCleaners = conf.getStrings(confKey);
Copy link
Contributor

@anoopsjohn anoopsjohn Aug 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: We can even rename this and related var names also.. This is not just logCleaner.. Hfile cleaner also.. may be call just cleaner or fileCleaner.

Copy link
Contributor Author

@saintstack saintstack Aug 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can do in follow-on. Just reusing what was there ....

@Apache-HBase
Copy link

Apache-HBase commented Aug 1, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 36s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+1 💚 mvninstall 3m 40s branch-2 passed
+1 💚 checkstyle 1m 8s branch-2 passed
+1 💚 spotbugs 1m 59s branch-2 passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 15s the patch passed
+1 💚 checkstyle 1m 5s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 11m 37s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 spotbugs 2m 5s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 15s The patch does not generate ASF License warnings.
33m 1s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2181/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #2181
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname Linux 63d16f2ecdec 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 271a3cb
Max. process+thread count 94 (vs. ulimit of 12500)
modules C: hbase-server U: hbase-server
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2181/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

virajjasani
virajjasani approved these changes Aug 1, 2020
View reviewed changes
Copy link
Contributor

@virajjasani virajjasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@busbey
Copy link
Contributor

busbey commented Aug 1, 2020

Please change the jira subject and commit message to something like "skip empty log cleaner delegate class names" to describe what is changing

@saintstack saintstack changed the title HBASE-24808 cleaner.CleanerChore: Can NOT create CleanerDelegate= Cla… HBASE-24808 skip empty log cleaner delegate class names (WAS => cleaner.CleanerChore: Can NOT create CleanerDelegate= Cla… Aug 3, 2020
@saintstack saintstack merged commit 8c4f8e2 into apache:branch-2 Aug 3, 2020
saintstack added a commit that referenced this pull request Aug 3, 2020
@saintstack
HBASE-24808 skip empty log cleaner delegate class names (WAS => clean…
e57bfcb 
…er.CleanerChore: Can NOT create CleanerDelegate= ClassNotFoundException) (#2181)


Signed-off-by: Anoop Sam John <[email protected]>
Signed-off-by: Viraj Jasani <[email protected]>
Signed-off-by: Sean Busbey <[email protected]>
saintstack added a commit that referenced this pull request Aug 3, 2020
@saintstack
HBASE-24808 skip empty log cleaner delegate class names (WAS => clean…
148c185 
…er.CleanerChore: Can NOT create CleanerDelegate= ClassNotFoundException) (#2181)


Signed-off-by: Anoop Sam John <[email protected]>
Signed-off-by: Viraj Jasani <[email protected]>
Signed-off-by: Sean Busbey <[email protected]>
clarax pushed a commit to clarax/hbase that referenced this pull request Nov 15, 2020
@saintstack @clarax
HBASE-24808 skip empty log cleaner delegate class names (WAS => clean…
157354e 
…er.CleanerChore: Can NOT create CleanerDelegate= ClassNotFoundException) (apache#2181)


Signed-off-by: Anoop Sam John <[email protected]>
Signed-off-by: Viraj Jasani <[email protected]>
Signed-off-by: Sean Busbey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anoopsjohn anoopsjohn anoopsjohn approved these changes

@virajjasani virajjasani virajjasani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@saintstack @Apache-HBase @busbey @anoopsjohn @virajjasani