-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBAE-24507 Remove HTableDescriptor and HColumnDescriptor #2186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
saintstack
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice. Needs a nice fat release note on purging old types. Minor thing to fix on commit.... see below.
| * <p/> | ||
| * NOTE: this class is NOT thread safe. Concurrent setting/enabling/disabling of | ||
| * constraints can cause constraints to be run at incorrect times or not at all. | ||
| >>>>>>> 210f1e7388... tmp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me check.
| * @throws IOException | ||
| * If the {@link ConstraintProcessor} CP couldn't be added to the | ||
| * table. | ||
| >>>>>>> 210f1e7388... tmp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto
|
Looks like old ruby references have already started using new builder classes. Much better. |
virajjasani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
+1 |
|
🎊 +1 overall
This message was automatically generated. |
No description provided.