HBASE-24823 Port HBASE-22762 Print the delta between phases in the sp… #2204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lit/merge/compact/flush transaction journals to master branch
|
🎊 +1 overall
This message was automatically generated. |
apurtell
approved these changes
Aug 5, 2020
Contributor
Author
|
Sample snapshot journal after the change: Table snapshot journal : |
liuml07
reviewed
Aug 5, 2020
| public String prettyPrintJournal() { | ||
| return StringUtils.join("\n\t", getStatusJournal()); | ||
| StringBuilder sb = new StringBuilder(); | ||
| for (int i = 0; i < journal.size(); i++) { |
Contributor
Author
There was a problem hiding this comment.
@liuml07 That's a good point. It would thrown an NPE and thereafter abort the master if we print the journal without enabling it. Pushed the change to have a safety check before printing the journal entries
liuml07
approved these changes
Aug 5, 2020
Member
liuml07
left a comment
liuml07
left a comment
There was a problem hiding this comment.
+1
Checked original patch for HBASE-22762. This backport looks good to me
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
virajjasani
pushed a commit
that referenced
this pull request
Aug 6, 2020
…lit/merge/compact/flush transaction journals Closes #2204 Signed-off-by: Andrew Purtell <[email protected]> Signed-off-by: Mingliang Liu <[email protected]> Signed-off-by: Viraj Jasani <[email protected]>
virajjasani
pushed a commit
that referenced
this pull request
Aug 6, 2020
…lit/merge/compact/flush transaction journals Closes #2204 Signed-off-by: Andrew Purtell <[email protected]> Signed-off-by: Mingliang Liu <[email protected]> Signed-off-by: Viraj Jasani <[email protected]>
clarax
pushed a commit
to clarax/hbase
that referenced
this pull request
Nov 15, 2020
…lit/merge/compact/flush transaction journals Closes apache#2204 Signed-off-by: Andrew Purtell <[email protected]> Signed-off-by: Mingliang Liu <[email protected]> Signed-off-by: Viraj Jasani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lit/merge/compact/flush transaction journals to master branch