HBASE-24743 Reject to add a peer which replicate to itself earlier #2071

infraio · 2020-07-15T06:28:48Z

No description provided.

Apache-HBase · 2020-07-15T07:08:00Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 44s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 49s	master passed
+1 💚	checkstyle	1m 8s	master passed
+1 💚	spotbugs	2m 0s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 21s	the patch passed
-0 ⚠️	checkstyle	1m 5s	hbase-server: The patch generated 9 new + 114 unchanged - 0 fixed = 123 total (was 114)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 14s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	2m 7s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 16s	The patch does not generate ASF License warnings.
		32m 49s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2071/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2071
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux a6e08dad3d03 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2505c77`
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2071/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	94 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2071/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

wchevreuil

+1, after addressing checkstyles issues.

...-server/src/main/java/org/apache/hadoop/hbase/master/replication/ReplicationPeerManager.java

Apache-HBase · 2020-07-15T09:33:15Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	5m 50s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 39s	master passed
+1 💚	compile	1m 4s	master passed
+1 💚	shadedjars	5m 51s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 38s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 46s	the patch passed
+1 💚	compile	0m 59s	the patch passed
+1 💚	javac	0m 59s	the patch passed
+1 💚	shadedjars	5m 53s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 38s	the patch passed
		_ Other Tests _
-1 ❌	unit	146m 33s	hbase-server in the patch failed.
		178m 5s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2071/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2071
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux fa4a13539bd3 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2505c77`
Default Java	1.8.0_232
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2071/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2071/1/testReport/
Max. process+thread count	4504 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2071/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-07-15T10:48:31Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 49s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	5m 50s	master passed
+1 💚	compile	1m 34s	master passed
+1 💚	shadedjars	8m 1s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	1m 3s	hbase-server in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 47s	the patch passed
+1 💚	compile	1m 27s	the patch passed
+1 💚	javac	1m 27s	the patch passed
+1 💚	shadedjars	7m 35s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 54s	hbase-server in the patch failed.
		_ Other Tests _
-1 ❌	unit	217m 2s	hbase-server in the patch failed.
		253m 20s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2071/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2071
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux aabe8f60bd6a 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2505c77`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2071/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2071/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2071/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2071/1/testReport/
Max. process+thread count	3034 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2071/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

...-server/src/main/java/org/apache/hadoop/hbase/master/replication/ReplicationPeerManager.java

bharathv · 2020-07-15T22:51:17Z

...-server/src/main/java/org/apache/hadoop/hbase/master/replication/ReplicationPeerManager.java

+            return false;
+          }
+        });
+      peerClusterId = ZKClusterId.readClusterIdZNode(zkWatcher);


ReplicationPeerManager is colocated with master, right? you can use master.getClusterId() without doing all this? (that is cached, so saves a ZK round trip).

Not right. This fetch peer cluster id.

See the changed code in hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java

...-server/src/main/java/org/apache/hadoop/hbase/master/replication/ReplicationPeerManager.java

Apache-HBase · 2020-07-16T00:51:11Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 10s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	4m 8s	master passed
+1 💚	checkstyle	1m 15s	master passed
+1 💚	spotbugs	2m 9s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 45s	the patch passed
+1 💚	checkstyle	1m 13s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 17s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	2m 16s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 14s	The patch does not generate ASF License warnings.
		36m 6s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2071/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2071
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux e7d783199938 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2505c77`
Max. process+thread count	84 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2071/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

bharathv

One last set of questions, then +1.

...-server/src/main/java/org/apache/hadoop/hbase/master/replication/ReplicationPeerManager.java

bharathv · 2020-07-16T01:25:40Z

...-server/src/main/java/org/apache/hadoop/hbase/master/replication/ReplicationPeerManager.java

  private void checkPeerConfig(ReplicationPeerConfig peerConfig) throws DoNotRetryIOException {
    String replicationEndpointImpl = peerConfig.getReplicationEndpointImpl();
-    boolean checkClusterKey = true;
+    ReplicationEndpoint endpoint = null;


nit = null is redundant.

...-server/src/main/java/org/apache/hadoop/hbase/master/replication/ReplicationPeerManager.java

bharathv · 2020-07-16T01:33:55Z

...-server/src/main/java/org/apache/hadoop/hbase/master/replication/ReplicationPeerManager.java

+      // Create the peer cluster config for get peer cluster id
+      Configuration peerConf = HBaseConfiguration.createClusterConf(conf, clusterKey);
+      ZKWatcher zkWatcher =
+        new ZKWatcher(peerConf, this + "check-peer-cluster-key", new Abortable() {


Looks like ZKWatcher is null-safe with abortable. Since we are not actually relying on it, just pass null?

...-server/src/main/java/org/apache/hadoop/hbase/master/replication/ReplicationPeerManager.java

Apache-HBase · 2020-07-16T04:32:56Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 47s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 39s	master passed
+1 💚	compile	1m 9s	master passed
+1 💚	shadedjars	6m 49s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 44s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 38s	the patch passed
+1 💚	compile	1m 12s	the patch passed
+1 💚	javac	1m 12s	the patch passed
+1 💚	shadedjars	6m 44s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 40s	the patch passed
		_ Other Tests _
-1 ❌	unit	227m 26s	hbase-server in the patch failed.
		257m 44s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2071/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2071
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 5fcf1debfa1f 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2505c77`
Default Java	1.8.0_232
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2071/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2071/2/testReport/
Max. process+thread count	3433 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2071/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-07-16T04:38:52Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 46s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	5m 17s	master passed
+1 💚	compile	1m 26s	master passed
+1 💚	shadedjars	7m 46s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 49s	hbase-server in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 45s	the patch passed
+1 💚	compile	1m 33s	the patch passed
+1 💚	javac	1m 33s	the patch passed
+1 💚	shadedjars	7m 47s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 51s	hbase-server in the patch failed.
		_ Other Tests _
-1 ❌	unit	228m 50s	hbase-server in the patch failed.
		263m 43s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2071/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2071
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux c7903439634c 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2505c77`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2071/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2071/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2071/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2071/2/testReport/
Max. process+thread count	2910 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2071/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-07-16T05:16:30Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 8s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 46s	master passed
+1 💚	checkstyle	1m 13s	master passed
+1 💚	spotbugs	2m 3s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 46s	the patch passed
-0 ⚠️	checkstyle	1m 12s	hbase-server: The patch generated 1 new + 114 unchanged - 0 fixed = 115 total (was 114)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 9s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	2m 16s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 11s	The patch does not generate ASF License warnings.
		35m 13s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2071/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2071
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux 50420a6cf4e1 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2505c77`
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2071/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	84 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2071/3/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-07-16T07:31:42Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 24s	master passed
+1 💚	compile	0m 55s	master passed
+1 💚	shadedjars	5m 39s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 39s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 29s	the patch passed
+1 💚	compile	0m 54s	the patch passed
+1 💚	javac	0m 54s	the patch passed
+1 💚	shadedjars	5m 36s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 36s	the patch passed
		_ Other Tests _
-1 ❌	unit	146m 46s	hbase-server in the patch failed.
		170m 25s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2071/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2071
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux e34379920a0a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2505c77`
Default Java	1.8.0_232
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2071/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2071/3/testReport/
Max. process+thread count	4644 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2071/3/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-07-16T08:30:36Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 2s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 30s	master passed
+1 💚	compile	1m 11s	master passed
+1 💚	shadedjars	6m 18s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 40s	hbase-server in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 28s	the patch passed
+1 💚	compile	1m 9s	the patch passed
+1 💚	javac	1m 9s	the patch passed
+1 💚	shadedjars	6m 21s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 41s	hbase-server in the patch failed.
		_ Other Tests _
-1 ❌	unit	201m 27s	hbase-server in the patch failed.
		229m 22s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2071/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2071
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 3680f72cba1e 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2505c77`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2071/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2071/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2071/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2071/3/testReport/
Max. process+thread count	3126 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2071/3/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-07-20T07:33:21Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 43s	master passed
+1 💚	checkstyle	1m 10s	master passed
+1 💚	spotbugs	1m 59s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 22s	the patch passed
+1 💚	checkstyle	1m 6s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 36s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	2m 8s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 15s	The patch does not generate ASF License warnings.
		32m 52s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2071/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2071
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux d942687798df 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `9b32943`
Max. process+thread count	94 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2071/4/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-07-20T11:08:50Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 24s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 58s	master passed
+1 💚	compile	1m 17s	master passed
+1 💚	shadedjars	6m 40s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 48s	hbase-server in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 47s	the patch passed
+1 💚	compile	1m 12s	the patch passed
+1 💚	javac	1m 12s	the patch passed
+1 💚	shadedjars	6m 43s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 51s	hbase-server in the patch failed.
		_ Other Tests _
+1 💚	unit	217m 41s	hbase-server in the patch passed.
		248m 20s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2071/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2071
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 6e059752a26e 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `9b32943`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2071/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2071/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2071/4/testReport/
Max. process+thread count	2903 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2071/4/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-07-20T11:19:15Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 24s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 57s	master passed
+1 💚	compile	0m 59s	master passed
+1 💚	shadedjars	6m 20s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 38s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 3s	the patch passed
+1 💚	compile	1m 1s	the patch passed
+1 💚	javac	1m 1s	the patch passed
+1 💚	shadedjars	6m 8s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 38s	the patch passed
		_ Other Tests _
+1 💚	unit	231m 45s	hbase-server in the patch passed.
		258m 44s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2071/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2071
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 6dddfc415a1b 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `9b32943`
Default Java	1.8.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2071/4/testReport/
Max. process+thread count	2900 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2071/4/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

…2071) Signed-off-by: Wellington Chevreuil <[email protected]> Signed-off-by: Bharath Vissapragada <[email protected]>

virajjasani · 2020-07-21T11:10:40Z

@infraio TestReplicationAdmin is consistently failing on branch-2.

…rlier (#2071)" This reverts commit 6cf013d. TestReplicationAdmin and TestReplicationShell are broken on branch-2 and master respectively

…rlier (#2071)" This reverts commit 5db3ec2. TestReplicationAdmin and TestReplicationShell are broken on branch-2 and master respectively

…pache#2071) Signed-off-by: Wellington Chevreuil <[email protected]> Signed-off-by: Bharath Vissapragada <[email protected]>

…rlier (apache#2071)" This reverts commit 5db3ec2. TestReplicationAdmin and TestReplicationShell are broken on branch-2 and master respectively

wchevreuil approved these changes Jul 15, 2020

View reviewed changes

...-server/src/main/java/org/apache/hadoop/hbase/master/replication/ReplicationPeerManager.java Show resolved Hide resolved

bharathv requested changes Jul 15, 2020

View reviewed changes

infraio force-pushed the HBASE-24743 branch from ac728de to 129d94a Compare July 16, 2020 00:05

bharathv reviewed Jul 16, 2020

View reviewed changes

infraio force-pushed the HBASE-24743 branch from 129d94a to ff7766f Compare July 16, 2020 02:03

bharathv approved these changes Jul 16, 2020

View reviewed changes

HBASE-24743 Reject to add a peer which replicate to itself earlier

ef5ee55

infraio force-pushed the HBASE-24743 branch from ff7766f to ef5ee55 Compare July 20, 2020 06:49

infraio merged commit 6cf013d into apache:master Jul 21, 2020

asfgit pushed a commit that referenced this pull request Jul 21, 2020

HBASE-24743 Reject to add a peer which replicate to itself earlier (#…

5db3ec2

…2071) Signed-off-by: Wellington Chevreuil <[email protected]> Signed-off-by: Bharath Vissapragada <[email protected]>

clarax pushed a commit to clarax/hbase that referenced this pull request Nov 15, 2020

HBASE-24743 Reject to add a peer which replicate to itself earlier (a…

9a5e2a3

…pache#2071) Signed-off-by: Wellington Chevreuil <[email protected]> Signed-off-by: Bharath Vissapragada <[email protected]>

HBASE-24743 Reject to add a peer which replicate to itself earlier #2071

HBASE-24743 Reject to add a peer which replicate to itself earlier #2071

Uh oh!

Conversation

infraio commented Jul 15, 2020

Uh oh!

Apache-HBase commented Jul 15, 2020

Uh oh!

wchevreuil left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Apache-HBase commented Jul 15, 2020

Uh oh!

Apache-HBase commented Jul 15, 2020

Uh oh!

Uh oh!

bharathv Jul 15, 2020

Choose a reason for hiding this comment

Uh oh!

infraio Jul 15, 2020

Choose a reason for hiding this comment

Uh oh!

infraio Jul 16, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Apache-HBase commented Jul 16, 2020

Uh oh!

bharathv left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bharathv Jul 16, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bharathv Jul 16, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Apache-HBase commented Jul 16, 2020

Uh oh!

Apache-HBase commented Jul 16, 2020

Uh oh!

Apache-HBase commented Jul 16, 2020

Uh oh!

Apache-HBase commented Jul 16, 2020

Uh oh!

Apache-HBase commented Jul 16, 2020

Uh oh!

Apache-HBase commented Jul 20, 2020

Uh oh!

Apache-HBase commented Jul 20, 2020

Uh oh!

Apache-HBase commented Jul 20, 2020

Uh oh!

virajjasani commented Jul 21, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants