HBASE-24694 Support flush a single column family of table #2179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wchevreuil
requested changes
Jul 31, 2020
hbase-server/src/main/java/org/apache/hadoop/hbase/procedure/flush/FlushTableSubprocedure.java
Outdated
Show resolved
Hide resolved
| void flush(TableName tableName) throws IOException; | ||
|
|
||
| /** | ||
| * Flush a table. Synchronous operation. |
Contributor
There was a problem hiding this comment.
We should explain better how this overloaded version differs from flush(TableName tableName).
| CompletableFuture<Void> flush(TableName tableName); | ||
|
|
||
| /** | ||
| * Flush a table. |
Contributor
There was a problem hiding this comment.
We should explain better how this overloaded version differs from flush(TableName tableName).
| try { | ||
| LOG.debug("Flush region " + region.toString() + " started..."); | ||
| region.flush(true); | ||
| region.flushcache(families, false, FlushLifeCycleTracker.DUMMY); |
Contributor
There was a problem hiding this comment.
Can this affect the other versions that don't specify any families, like flush(TableName tableName)? Because region.flush(true), internally, loads all families before delegating to flushcache(List<byte[]> families, boolean writeFlushRequestWalMarker, FlushLifeCycleTracker tracker), but it doesn't seem we are doing this now.
Contributor
Author
There was a problem hiding this comment.
You are right, it indeed affect, will fix.
Thanks.
...ain/java/org/apache/hadoop/hbase/procedure/flush/RegionServerFlushTableProcedureManager.java
Show resolved
Hide resolved
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
wchevreuil
approved these changes
Aug 5, 2020
Contributor
wchevreuil
left a comment
wchevreuil
left a comment
There was a problem hiding this comment.
lgtm +1, just small nits around javadocs and help output text.
| void flush(TableName tableName) throws IOException; | ||
|
|
||
| /** | ||
| * Flush a table with specified column family. Synchronous operation. |
Contributor
There was a problem hiding this comment.
Let's not leave any room for confusion: Flush the specified column family stores on all regions of the passed table. This runs as a synchronous operation.
Contributor
Author
There was a problem hiding this comment.
Will fix later.
Thanks.
| CompletableFuture<Void> flush(TableName tableName); | ||
|
|
||
| /** | ||
| * Flush a table with specified column family. |
Contributor
Author
There was a problem hiding this comment.
Will fix later.
Thanks.
| flush an individual region or a region server name whose format | ||
| is 'host,port,startcode', to flush all its regions. | ||
| You can also flush a single column family within a region. | ||
| You can also flush a single column family within a table or region. |
Contributor
There was a problem hiding this comment.
You can also flush a single column family for all regions within a table, or for an specific region only.
Contributor
Author
There was a problem hiding this comment.
Will fix later.
Thanks.
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Contributor
Author
|
Test failure on jdk11 seems unrelated to this PR. |
Contributor
Author
|
Thanks for you time. @wchevreuil |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.