Merge master into release-next#720
Merged
jetstack-bot merged 58 commits intocert-manager:release-nextfrom Oct 19, 2021
Merged
Conversation
A description of resource `Certificate` has `foo.example.com` and `bar.example.com` in the `dnsNames` section, which is different from the diagram that has `example.com` and `foo.example.com` domains. When I was looking at the schema in the article, I thought that the part related to `bar.example.com` is to follow, but it didn't and therefore was a bit confusing. Signed-off-by: Alex Litvinenko <alex@litvinenko.tech>
Signed-off-by: Maël Valais <mael@vls.dev>
"d" is not a valid character for a duration Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
Merge release-next into master for the 1.5 release
Signed-off-by: RinkiyaKeDad <arshsharma461@gmail.com>
Fix broken certificaterequest yaml
Signed-off-by: RinkiyaKeDad <arshsharma461@gmail.com>
Signed-off-by: RinkiyaKeDad <arshsharma461@gmail.com>
this follows cert-manager/testing#553 being merged Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
we never looked at the output from this command - it didn't fail the build. it also has so many false positives that it would take a significant amount of effort to be able to use it effectively. I like the idea of tools like this, but I don't think this specific tool - with the false-positives - is providing any value to us here. Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
Fix k8s versions we test against on master
forcing the value is harmful in environments which use a local caching GOPROXY Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
Remove alex check
Signed-off-by: irbekrm <irbekrm@gmail.com>
Signed-off-by: RinkiyaKeDad <arshsharma461@gmail.com>
Update plugin download command to always download latest version
Don't force GOPROXY when generating docs
Signed-off-by: RinkiyaKeDad <arshsharma461@gmail.com>
…1beta1) Signed-off-by: rtsp <git@rtsp.us>
…provider_tests adding docs for cloud provider tests
Signed-off-by: irbekrm <irbekrm@gmail.com>
The 'latest' GitHub release can be a patch for an older minor release, so we have to specify version number explicitly Signed-off-by: irbekrm <irbekrm@gmail.com>
…ctions Signed-off-by: irbekrm <irbekrm@gmail.com>
Bump helm installed cm version v1.5.0 -> v1.5.3
Signed-off-by: Aidan Jensen <aidan@artificial.com>
Remove trailing `/` in docker registry
fixes cert-manager#696 Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
Signed-off-by: James Westby <james@jameswestby.net>
Add snippet for plausible
|
✔️ Deploy Preview for cert-manager-website ready! 🔨 Explore the source changes: 1edc9be 🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/616edd0f959b630009ca5ccc 😎 Browse the preview: https://deploy-preview-720--cert-manager-website.netlify.app |
jetstack-bot
added
the
size/M
jetstack-bot
added
do-not-merge/cherry-pick-not-approved
JoshVanL
force-pushed
the
release-next-merge-v1.6.0-beta.0
branch
from
e50d3a9 to
912ac24
Compare
Contributor
Author
|
/dco override |
Contributor
Author
|
/dco-override |
Contributor
Author
|
/override dco |
Contributor
|
@JoshVanL: Overrode contexts on behalf of JoshVanL: dco DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Contributor
Author
|
/assign @jakexks |
JoshVanL
changed the title
JoshVanL
force-pushed
the
release-next-merge-v1.6.0-beta.0
branch
from
912ac24 to
1edc9be
Compare
Contributor
|
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits. 📝 Please follow instructions in the contributing guide to update your commits with the DCO Full details of the Developer Certificate of Origin can be found at developercertificate.org. The list of commits missing DCO signoff:
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
JoshVanL
changed the title
Contributor
Author
|
/override dco |
Contributor
|
@JoshVanL: Overrode contexts on behalf of JoshVanL: dco DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
jakexks
added
cherry-pick-approved
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jakexks, JoshVanL The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR mergees
masterintorelease-next. Here you can see the diff between this branch and the current master. The changes look sane../assign @jakexks