Skip to content

Update supported Bazel versions#708

Merged
jetstack-bot merged 1 commit intocert-manager:masterfrom
irbekrm:bazel_bump
Oct 1, 2021
Merged

Update supported Bazel versions#708
jetstack-bot merged 1 commit intocert-manager:masterfrom
irbekrm:bazel_bump

Conversation

@irbekrm
Copy link
Contributor

@irbekrm irbekrm commented Sep 27, 2021

This small PR updates the supported/required Bazel versions.

It is to be merged after cert-manager#4478 which enforces v4.0.0 as minimum Bazel version gets merged.

Signed-off-by: irbekrm irbekrm@gmail.com

Signed-off-by: irbekrm <irbekrm@gmail.com>
@jetstack-bot jetstack-bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Sep 27, 2021
@netlify
Copy link

netlify bot commented Sep 27, 2021

✔️ Deploy Preview for cert-manager-website ready!

🔨 Explore the source changes: bce30c4

🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/6151ceda799e200007c1deed

😎 Browse the preview: https://deploy-preview-708--cert-manager-website.netlify.app/docs/contributing/building

@jetstack-bot jetstack-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 27, 2021
Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

/lgtm
/hold

@jetstack-bot jetstack-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 30, 2021
@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2021
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irbekrm, wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@irbekrm
Copy link
Contributor Author

irbekrm commented Oct 1, 2021

Thanks Richard.

Unholding this as the PR that bumped Bazel version got merged.

/hold cancel

@jetstack-bot jetstack-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 1, 2021
@jetstack-bot jetstack-bot merged commit f77ac43 into cert-manager:master Oct 1, 2021
@irbekrm irbekrm deleted the bazel_bump branch October 1, 2021 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants