Don't force GOPROXY when generating docs#684
Don't force GOPROXY when generating docs#684jetstack-bot merged 1 commit intocert-manager:masterfrom
Conversation
forcing the value is harmful in environments which use a local caching GOPROXY Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
jetstack-bot
added
dco-signoff: yes
|
✔️ Deploy Preview for cert-manager-website ready! 🔨 Explore the source changes: e27d08d 🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/611557fb86e2ee0008c4c59b 😎 Browse the preview: https://deploy-preview-684--cert-manager-website.netlify.app |
jetstack-bot
added
the
size/XS
| # Create fake GOPATH | ||
| echo "+++ Creating temporary GOPATH" | ||
| export GOPATH="${tmpdir}/go" | ||
| export GOPROXY="https://proxy.golang.org" |
There was a problem hiding this comment.
It was probably added before this became the default
For versions earlier than Go 1.13, you can configure the go command to download modules using this module mirror by setting GOPROXY=https://proxy.golang.org.
-- https://proxy.golang.org/#EnvironmentSetup
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SgtCoDFish, wallrj The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
Forcing the value is harmful in environments which use a local caching GOPROXY (such as my own 😁)
This is very similar to something we did in the main cert-manager repo: cert-manager/cert-manager@c86f20f