Skip to content

Remove trailing / in docker registry#694

Merged
jetstack-bot merged 1 commit intocert-manager:masterfrom
aidandj:master
Sep 2, 2021
Merged

Remove trailing / in docker registry#694
jetstack-bot merged 1 commit intocert-manager:masterfrom
aidandj:master

Conversation

@aidandj
Copy link
Contributor

@aidandj aidandj commented Sep 1, 2021

Signed-off-by: Aidan Jensen aidan@artificial.com

Signed-off-by: Aidan Jensen <aidan@artificial.com>
@jetstack-bot jetstack-bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Sep 1, 2021
@netlify
Copy link

netlify bot commented Sep 1, 2021

✔️ Deploy Preview for cert-manager-website ready!

🔨 Explore the source changes: 1f24ddf

🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/612f954da2773100075c9021

😎 Browse the preview: https://deploy-preview-694--cert-manager-website.netlify.app/docs/contributing/building

@jetstack-bot jetstack-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 1, 2021
@jetstack-bot
Copy link
Contributor

Hi @artificial-aidan. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 1, 2021
@aidandj
Copy link
Contributor Author

aidandj commented Sep 1, 2021

/assign @munnerz

@irbekrm
Copy link
Contributor

irbekrm commented Sep 2, 2021

Thanks @artificial-aidan !

/ok-to-test
/approve
/lgtm

As a side note, I wonder if it would make sense to eventually replace these Bazel commands with the make ones from cert-manager/Makefile, to make this more contributor friendly.

@jetstack-bot jetstack-bot added ok-to-test lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 2, 2021
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: artificial-aidan, irbekrm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2021
@jetstack-bot jetstack-bot merged commit b4ae1eb into cert-manager:master Sep 2, 2021
@aidandj
Copy link
Contributor Author

aidandj commented Sep 2, 2021

Thanks @artificial-aidan !

/ok-to-test
/approve
/lgtm

As a side note, I wonder if it would make sense to eventually replace these Bazel commands with the make ones from cert-manager/Makefile, to make this more contributor friendly.

I actually had problems with the makefile commands. Bazel worked better odly enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants