Remove trailing / in docker registry#694
Conversation
Signed-off-by: Aidan Jensen <aidan@artificial.com>
|
✔️ Deploy Preview for cert-manager-website ready! 🔨 Explore the source changes: 1f24ddf 🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/612f954da2773100075c9021 😎 Browse the preview: https://deploy-preview-694--cert-manager-website.netlify.app/docs/contributing/building |
|
Hi @artificial-aidan. Thanks for your PR. I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @munnerz |
|
Thanks @artificial-aidan ! /ok-to-test As a side note, I wonder if it would make sense to eventually replace these Bazel commands with the make ones from cert-manager/Makefile, to make this more contributor friendly. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: artificial-aidan, irbekrm The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I actually had problems with the makefile commands. Bazel worked better odly enough. |
Signed-off-by: Aidan Jensen aidan@artificial.com