Skip to content

Clarify current status of compatibility with Autopilot GKE#713

Merged
jetstack-bot merged 1 commit intocert-manager:masterfrom
bradjones1:patch-1
Oct 14, 2021
Merged

Clarify current status of compatibility with Autopilot GKE#713
jetstack-bot merged 1 commit intocert-manager:masterfrom
bradjones1:patch-1

Conversation

@bradjones1
Copy link
Contributor

@jetstack-bot jetstack-bot added the dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. label Oct 12, 2021
@netlify
Copy link

netlify bot commented Oct 12, 2021

✔️ Deploy Preview for cert-manager-website ready!

🔨 Explore the source changes: b1357c4

🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/6165f40a9cd9a000073a06a2

😎 Browse the preview: https://deploy-preview-713--cert-manager-website.netlify.app/docs/installation/compatibility

@jetstack-bot jetstack-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 12, 2021
@jetstack-bot
Copy link
Contributor

Hi @bradjones1. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 12, 2021
@bradjones1
Copy link
Contributor Author

It should be noted there is existing documentation re: Autopilot on the release-next branch but it isn't on master and I am trying to follow the contribution guidelines.

Signed-off-by: Brad Jones <brad@bradjonesllc.com>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Oct 12, 2021
Copy link
Member

@jakexks jakexks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/approve
/lgtm

@jetstack-bot jetstack-bot added ok-to-test lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 14, 2021
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bradjones1, jakexks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2021
@jetstack-bot jetstack-bot merged commit 6881ab7 into cert-manager:master Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants