Skip to content

Fix the plusible snippet#705

Merged
jetstack-bot merged 1 commit intomasterfrom
plausible
Sep 20, 2021
Merged

Fix the plusible snippet#705
jetstack-bot merged 1 commit intomasterfrom
plausible

Conversation

@james-w
Copy link
Contributor

@james-w james-w commented Sep 20, 2021

When I added the Plausible snippet in e8a62ef
I copy and pasted the wrong tracking code, and used the one for
Clearbit instead of Plusible. This corrects that error and uses
the tracking code for Plausible.

@james-w james-w requested a review from maelvls September 20, 2021 14:36
@jetstack-bot jetstack-bot added dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 20, 2021
@netlify
Copy link

netlify bot commented Sep 20, 2021 •
edited
Loading

✔️ Deploy Preview for cert-manager-website ready!

🔨 Explore the source changes: a0809c2

🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/61489ceb4548e10007cdf86b

😎 Browse the preview: https://deploy-preview-705--cert-manager-website.netlify.app

@james-w
Copy link
Contributor Author

james-w commented Sep 20, 2021

This time I used /etc/hosts to be able to test from my local machine and verified that the
hits are appearing in plausible.io.

@james-w
Fix the plusible snippet
a0809c2 
When I added the Plausible snippet in e8a62ef
I copy and pasted the wrong tracking code, and used the one for
Clearbit instead of Plusible. This corrects that error and uses
the tracking code for Plausible.

Signed-off-by: James Westby <james@jameswestby.net>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Sep 20, 2021
@maelvls
Copy link
Member

maelvls commented Sep 20, 2021

/ok-to-test
/lgtm

@jetstack-bot jetstack-bot added ok-to-test lgtm Indicates that a PR is ready to be merged. labels Sep 20, 2021
maelvls
maelvls approved these changes Sep 20, 2021
View reviewed changes
Copy link
Member

@maelvls maelvls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@jetstack-bot
Copy link
Contributor

jetstack-bot commented Sep 20, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: james-w, maelvls

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2021
@jetstack-bot jetstack-bot merged commit 846b15d into master Sep 20, 2021
@jetstack-bot jetstack-bot mentioned this pull request Oct 19, 2021
Merged
@jetstack-bot jetstack-bot mentioned this pull request Oct 27, 2021
Merged
@SgtCoDFish SgtCoDFish deleted the plausible branch April 26, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maelvls maelvls maelvls approved these changes

Assignees

@maelvls maelvls

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@james-w @maelvls @jetstack-bot