Adjust list of Subject Alternative Names#650
Adjust list of Subject Alternative Names#650aazon wants to merge 1 commit intocert-manager:masterfrom aazon:patch-1
Conversation
A description of resource `Certificate` has `foo.example.com` and `bar.example.com` in the `dnsNames` section, which is different from the diagram that has `example.com` and `foo.example.com` domains. When I was looking at the schema in the article, I thought that the part related to `bar.example.com` is to follow, but it didn't and therefore was a bit confusing.
jetstack-bot
added
the
dco-signoff: no
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: aazon The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits. 📝 Please follow instructions in the contributing guide to update your commits with the DCO Full details of the Developer Certificate of Origin can be found at developercertificate.org. The list of commits missing DCO signoff:
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
✔️ Deploy Preview for cert-manager-website ready! 🔨 Explore the source changes: c218139 🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/60f6a573c17d5e0008fd0822 😎 Browse the preview: https://deploy-preview-650--cert-manager-website.netlify.app/docs/concepts/certificate |
|
Hi @aazon. Thanks for your PR. I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
jetstack-bot
added
needs-ok-to-test
|
Thank you @aazon! I realize that I should have update the certificate examples when I added the diagram 😅 /ok-to-test |
jetstack-bot
added
ok-to-test
and removed
needs-ok-to-test
|
@aazon: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
jetstack-bot
added
the
needs-rebase
Signed-off-by: Maël Valais <mael@vls.dev>
|
I rebased the commit and merged it in b11b774. Thank you for the patch! /close |
|
@maelvls: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
3 participants
A description of resource
Certificatehasfoo.example.comandbar.example.comin thednsNamessection, which is different from the diagram that hasexample.comandfoo.example.comdomains. When I was looking at the schema in the article, I thought that the part related tobar.example.comis to follow, but it didn't and therefore was a bit confusing.