Improve docs for fargate networking to avoid confusion#698
Improve docs for fargate networking to avoid confusion#698jetstack-bot merged 1 commit intocert-manager:masterfrom
Conversation
fixes cert-manager#696 Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
|
✔️ Deploy Preview for cert-manager-website ready! 🔨 Explore the source changes: 2d1ba18 🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/6137420fb142520007328e24 😎 Browse the preview: https://deploy-preview-698--cert-manager-website.netlify.app/docs/installation/compatibility |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Looks good. Would it be worth adding this report: https://kubernetes.slack.com/archives/C4NV3DWUC/p1631004960113100?thread_ts=1630950059.102500&cid=C4NV3DWUC to the docs too? (stating that runAsUser: 1001 was required on fargate)
I don't think I'm fully convinced that the reported issue relating to STS/IAM and I think pending further evidence that runAsUser is required I'd rather leave that advice out, or I'd worry it could become a cargo cult thing. |
|
@jakexks friendly prod:
do you think this is is required for this PR or can we get it merged as-is? |
|
/lgtm |
Fixes #696
/kind documentation