Skip to content

Improve docs for fargate networking to avoid confusion#698

Merged
jetstack-bot merged 1 commit intocert-manager:masterfrom
SgtCoDFish:fargatehost
Sep 14, 2021
Merged

Improve docs for fargate networking to avoid confusion#698
jetstack-bot merged 1 commit intocert-manager:masterfrom
SgtCoDFish:fargatehost

Conversation

@SgtCoDFish
Copy link
Copy Markdown
Member

Fixes #696

/kind documentation

fixes cert-manager#696

Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
@jetstack-bot jetstack-bot added kind/documentation Categorizes issue or PR as related to documentation. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Sep 7, 2021
@netlify
Copy link
Copy Markdown

netlify bot commented Sep 7, 2021

✔️ Deploy Preview for cert-manager-website ready!

🔨 Explore the source changes: 2d1ba18

🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/6137420fb142520007328e24

😎 Browse the preview: https://deploy-preview-698--cert-manager-website.netlify.app/docs/installation/compatibility

@jetstack-bot jetstack-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 7, 2021
@jetstack-bot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2021
Copy link
Copy Markdown
Member

@jakexks jakexks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Would it be worth adding this report: https://kubernetes.slack.com/archives/C4NV3DWUC/p1631004960113100?thread_ts=1630950059.102500&cid=C4NV3DWUC to the docs too? (stating that runAsUser: 1001 was required on fargate)

@SgtCoDFish
Copy link
Copy Markdown
Member Author

Looks good. Would it be worth adding this report: https://kubernetes.slack.com/archives/C4NV3DWUC/p1631004960113100?thread_ts=1630950059.102500&cid=C4NV3DWUC to the docs too? (stating that runAsUser: 1001 was required on fargate)

I don't think I'm fully convinced that the reported issue relating to STS/IAM and runAsUser are related, there. I don't see why runAsUser would have anything to do with that error 🤔

I think pending further evidence that runAsUser is required I'd rather leave that advice out, or I'd worry it could become a cargo cult thing.

@SgtCoDFish
Copy link
Copy Markdown
Member Author

SgtCoDFish commented Sep 14, 2021

@jakexks friendly prod:

Looks good. Would it be worth adding this report: https://kubernetes.slack.com/archives/C4NV3DWUC/p1631004960113100?thread_ts=1630950059.102500&cid=C4NV3DWUC to the docs too? (stating that runAsUser: 1001 was required on fargate)

do you think this is is required for this PR or can we get it merged as-is?

@jakexks
Copy link
Copy Markdown
Member

jakexks commented Sep 14, 2021

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2021
@jetstack-bot jetstack-bot merged commit d312795 into cert-manager:master Sep 14, 2021
@SgtCoDFish SgtCoDFish deleted the fargatehost branch September 14, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fargate caveats page made me think that I should set webhook.HostNetwork=true but you actually must not

3 participants