Skip to content

Remove stray space, breaking URL linking#717

Merged
jetstack-bot merged 1 commit intocert-manager:masterfrom
TBBle:patch-1
Oct 18, 2021
Merged

Remove stray space, breaking URL linking#717
jetstack-bot merged 1 commit intocert-manager:masterfrom
TBBle:patch-1

Conversation

@TBBle
Copy link
Contributor

@TBBle TBBle commented Oct 18, 2021

Current (Live at time of PR):
image

Fixed (from Netlify preview of PR):
image

Signed-off-by: Paul "Hampy" Hampson <p_hampson@wargaming.net>
@jetstack-bot jetstack-bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Oct 18, 2021
@netlify
Copy link

netlify bot commented Oct 18, 2021

✔️ Deploy Preview for cert-manager-website ready!

🔨 Explore the source changes: 800fe4d

🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/616d229e70b52a00073d1e3f

😎 Browse the preview: https://deploy-preview-717--cert-manager-website.netlify.app/docs/configuration/external

@jetstack-bot
Copy link
Contributor

Hi @TBBle. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 18, 2021
@JoshVanL
Copy link
Contributor

Thanks!
/ok-to-test
/lgtm
/approve

@jetstack-bot jetstack-bot added ok-to-test lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 18, 2021
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoshVanL, TBBle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2021
@jetstack-bot jetstack-bot merged commit 8b6bd53 into cert-manager:master Oct 18, 2021
@TBBle TBBle deleted the patch-1 branch October 18, 2021 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants