Bump helm installed cm version v1.5.0 -> v1.5.3#690
Bump helm installed cm version v1.5.0 -> v1.5.3#690jetstack-bot merged 3 commits intocert-manager:masterfrom
Conversation
Signed-off-by: irbekrm <irbekrm@gmail.com>
|
✔️ Deploy Preview for cert-manager-website ready! 🔨 Explore the source changes: 1a2f98b 🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/61262f4b0ae3360007d88ea7 😎 Browse the preview: https://deploy-preview-690--cert-manager-website.netlify.app |
wallrj
left a comment
There was a problem hiding this comment.
I agree.
We discovered yesterday that the use of "latest" in https://cert-manager.io/docs/installation/#default-static-install is also wrong.
It would redirect to the latest 1.4.x release if that happened to be released after the 1.5.x release. So that should also be changed to 1.5.3.
And there's another version reference in https://cert-manager.io/docs/installation/kubectl/
Maybe add a note to the release process doc explaining that these versions need to be updated as part of a patch release.
The 'latest' GitHub release can be a patch for an older minor release, so we have to specify version number explicitly Signed-off-by: irbekrm <irbekrm@gmail.com>
…ctions Signed-off-by: irbekrm <irbekrm@gmail.com>
|
Thanks @wallrj I've updated the PR.
Added that, but I guess eventually we'll need a better solution, maybe some script that always returns latest release number like https://kubernetes.io/docs/tasks/tools/install-kubectl-linux/#install-kubectl-on-linux |
wallrj
left a comment
There was a problem hiding this comment.
Strictly we should create a PR against the release-1.4 docs updating those too:
The release process is becoming such a bore!
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: irbekrm, wallrj The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I've added that in #691 . This is painful 😄 |
Bump Helm installed cert-manager version v1.5.0 -> v1.5.3
I think we should always encourage users who want to install a particular minor version to install the latest patch version for that minor version. It feels suboptimal to bump it here every time after releasing a patch. I am not sure what would be the best solution for that - it is possible to specify a range of versions to helm install command with
--version ^X.Y, but that doesn't seem to work for versions that are prefixed withv.Perhaps we should take the version out of the install command alltogether.
Signed-off-by: irbekrm irbekrm@gmail.com