Skip to content

Bump helm installed cm version v1.5.0 -> v1.5.3#690

Merged
jetstack-bot merged 3 commits intocert-manager:masterfrom
irbekrm:bump_version
Aug 25, 2021
Merged

Bump helm installed cm version v1.5.0 -> v1.5.3#690
jetstack-bot merged 3 commits intocert-manager:masterfrom
irbekrm:bump_version

Conversation

@irbekrm
Copy link
Contributor

@irbekrm irbekrm commented Aug 25, 2021

Bump Helm installed cert-manager version v1.5.0 -> v1.5.3

I think we should always encourage users who want to install a particular minor version to install the latest patch version for that minor version. It feels suboptimal to bump it here every time after releasing a patch. I am not sure what would be the best solution for that - it is possible to specify a range of versions to helm install command with --version ^X.Y, but that doesn't seem to work for versions that are prefixed with v.
Perhaps we should take the version out of the install command alltogether.

Signed-off-by: irbekrm irbekrm@gmail.com

Signed-off-by: irbekrm <irbekrm@gmail.com>
@jetstack-bot jetstack-bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Aug 25, 2021
@netlify
Copy link

netlify bot commented Aug 25, 2021

✔️ Deploy Preview for cert-manager-website ready!

🔨 Explore the source changes: 1a2f98b

🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/61262f4b0ae3360007d88ea7

😎 Browse the preview: https://deploy-preview-690--cert-manager-website.netlify.app

@jetstack-bot jetstack-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 25, 2021
Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree.

We discovered yesterday that the use of "latest" in https://cert-manager.io/docs/installation/#default-static-install is also wrong.
It would redirect to the latest 1.4.x release if that happened to be released after the 1.5.x release. So that should also be changed to 1.5.3.

And there's another version reference in https://cert-manager.io/docs/installation/kubectl/

Maybe add a note to the release process doc explaining that these versions need to be updated as part of a patch release.

The 'latest' GitHub release can be a patch for an older minor release, so we have to specify version number explicitly

Signed-off-by: irbekrm <irbekrm@gmail.com>
…ctions

Signed-off-by: irbekrm <irbekrm@gmail.com>
@jetstack-bot jetstack-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 25, 2021
@irbekrm
Copy link
Contributor Author

irbekrm commented Aug 25, 2021

Thanks @wallrj I've updated the PR.

Maybe add a note to the release process doc explaining that these versions need to be updated as part of a patch release.

Added that, but I guess eventually we'll need a better solution, maybe some script that always returns latest release number like https://kubernetes.io/docs/tasks/tools/install-kubectl-linux/#install-kubectl-on-linux

Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strictly we should create a PR against the release-1.4 docs updating those too:

The release process is becoming such a bore!

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2021
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irbekrm, wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot merged commit 6f340e4 into cert-manager:master Aug 25, 2021
@irbekrm irbekrm deleted the bump_version branch August 25, 2021 12:18
@irbekrm
Copy link
Contributor Author

irbekrm commented Aug 25, 2021

Strictly we should create a PR against the release-1.4 docs updating those too

I've added that in #691 .

This is painful 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants