Conversation
* Add tests for state check after selfdestruct * Aurora runner tracks storage usage to avoid underflow when storage is released in future transactions (#85) * Implement generational storage (#87) * Base precompile code between connectors (#73) * Base precompile code between connectors * Handle errors and validate input * Use proper result * Document `aurora encode-address` usage. * Cache cargo artifacts between CI runs. (#92) * Address comments from audit. (#86) * Validate register length in `read_input_arr20()` * Only read register length in `Engine::get_code_size` * Add `read_input_borsh()` * Ensure `method.args.len() == args_decoded.len()` * Ensure register size is 8 in `read_u64` * Use constant to specify the register ID used in `read_input()` * Reduce size of `cargo cache` in CI. (#95) * Define a `Wei` newtype for balances. (#96) * Fix evm-bully builds after recent refactoring. (#100) * Refactor `Engine::get_state` to return a `Result`. (#99) * Ensure that `Cargo.lock` in the repo is valid. (#101) * Remove unneeded nightly feature. (#102) * Implement BC generational storage. * fix address input * remove note * put key on the end of the storage key * remove pub from methods * Dispatch precompiles on the full address. (#107) * Support state migration on upgrade. (#103) * Implement the ETH connector. (#59) * Move when to call `set_generation` * Fix arg Co-authored-by: Marcelo Fornet <mfornet94@gmail.com> Co-authored-by: Arto Bendiken <arto@aurora.dev> Co-authored-by: Michael Birch <michael@near.org> Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com> Co-authored-by: Evgeny Ukhanov <mrlsd@ya.ru> * Fix layout of the key * Fix all tests (don't wipe the storage all the time) * Use correct generation in writing storage * Remove unnecessary references Co-authored-by: Michael Birch <michael@near.org> Co-authored-by: Joshua J. Bouw <dev@joshuajbouw.com> Co-authored-by: Arto Bendiken <arto@aurora.dev> Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com> Co-authored-by: Evgeny Ukhanov <mrlsd@ya.ru> Co-authored-by: Michael Birch <michael.birch@aurora.dev>
* Eth-connector: fixed u128 json parsing & tests. * fixed issue at tests: assert_execution_status_failure pattern * fixed all u128 tests for eth-connector - test_ft_transfer_max_value - test_ft_transfer_empty_value * Update tests/test_connector.rs Spell improvements Co-authored-by: Kirill <septengineering@pm.me> * JSON: `u128` - use JsonError. * JSON: `u128` - add error for using `Number`. Co-authored-by: Kirill <septengineering@pm.me> Co-authored-by: Septen <gammerxpower@gmail.com>
Co-authored-by: Arto Bendiken <arto@aurora.dev> Co-authored-by: Marcelo Fornet <marcelo@aurora.dev>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Michael Birch <michael@aurora.dev>
* JSON: add unit tests. * JSON: fix `u8`, `u64` out-of-range behaviour. * Stylystic fixes. * Extend json tests and fix u128 errors * Fix ft_on_transfer errors result * Extend json-bool tests * Modified: json array parser. Added: test_json_type_array * Json: remov map_err, Added derives, Added JsonOutOfRangeError * Extend errors types and tests * json: check overflow from i128 instead f64 * Remove json array & test * extend json u64 test for f64 precision * json fix formatting * json test parse_u64: u128 test and issue markers * JsonValue::u64 returns error for numbers greater than u64::MAX * Avoid i128 cast Co-authored-by: Evgeny Ukhanov <evgeny@aurora.dev> Co-authored-by: Evgeny Ukhanov <mrlsd@ya.ru> Co-authored-by: Michael Birch <michael.birch@aurora.dev>
* feat: storage layout for EvmErc20.sol * fix: lint errors
* Start defining AccessList transaction type * Mostly integrate AccessList transaction into the submit flow. Will not work properly without upstream changes. Also need to add tests * access list transaction signature includes the type byte * Use berlin pre-release from our fork * Migrate all workflows to self-hosted runners * EIP-2930 refactor and extra changes (#182) * Add initial work * Rest of changes * More verbose Co-authored-by: Joshua J. Bouw <joshua@aurora.dev> Co-authored-by: DimasGhost <strokovghost@gmail.com> Co-authored-by: Joshua J. Bouw <dev@joshuajbouw.com>
* Try speeding up workflow caching * Get rid of network cache, enable sccache, share parts of target dir across runs * Separate bully-build cache
* Add different networks to makefile * Add CI and different wasm contract bytes * unrelated: removing duplicate entry in .gitignore * Update readme * cargo fmt * Fix CI
* Update near dependencies * Use ecrecover host function * Use ripemd160 host function * Gate by testnet feature * factor out constants
* Optimize for performance instead of code size * Run test suite sequentially
* Parallelize test suits * Copy target instead of symlink * Disable target caching * Remove dependency of bully build to test jobs
* Add build-caching to testing workflow * Fix bully cache key * Temporary disable sccache * Temporary disable cache-util * Enable sccache * Enable cache-util * Fix bully cache key (again) * Prettify
* ERC-20 tests refactor * Sanity test refactor
joshuajbouw
approved these changes
Jul 30, 2021
Contributor
joshuajbouw
left a comment
joshuajbouw
left a comment
There was a problem hiding this comment.
Added two things that I had noticed. Rest looks fine to me.
* ERC-20: use lowercase NEP141 accountID for mapping. * ERC-20: add errors. Forbid invalid AccountIds. * Engine: Add `GetErc20FromNep141Error`, `RegisterTokenError` error types. * Engine: `register_token()` forbid using invalid NEP-141 AccountId as input. * Engine: `get_erc20_from_nep141()` forbid using invalid NEP-141 AccountId as input. * Engine: `register_token()` add logs. * Other minor improvements. Co-authored-by: Joshua J. Bouw <joshua@aurora.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.