Add mainnet, testnet, betanet; remove exit-precompiles compilation features#147
Merged
Add mainnet, testnet, betanet; remove exit-precompiles compilation features#147
mainnet, testnet, betanet; remove exit-precompiles compilation features#147Conversation
joshuajbouw
approved these changes
Jun 17, 2021
Contributor
joshuajbouw
left a comment
joshuajbouw
left a comment
There was a problem hiding this comment.
Also, straight forward.
Contributor
|
@sept-en I think you can go ahead and remove the |
artob
reviewed
Jun 17, 2021
artob
changed the title
mainnet, testnet, betanet compilation features.mainnet, testnet, betanet compilation features
sept-en
changed the title
mainnet, testnet, betanet compilation featuresmainnet, testnet, betanet; remove exit-precompiles compilation features
artob
approved these changes
Jun 17, 2021
artob
added a commit
that referenced
this pull request
Jun 18, 2021
* Implement EIP-2565 support. (#138) * Fix CI debug pipeline. (#145) * Enable `meta_call` only with feature flag. (#146) * Add `mainnet`, `testnet`, and `betanet` feature flags. (#147) * Prohibit static calls in exit precompiles. (#148) * Fix `clippy::unnecessary_unwrap`. (#149) * Fix all Clippy warnings. (#150) * Create the `ExitToNear` receiver account if it does not exist. (#151) Co-authored-by: Joshua J. Bouw <joshua@aurora.dev> Co-authored-by: Kirill <kirill@aurora.dev> Co-authored-by: Marcelo Fornet <marcelo@aurora.dev> Co-authored-by: Michael Birch <michael@aurora.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The purpose of PR is to be able to always build for a specific network (Mainnet/Testnet/Betanet) with explicitly defined set of features.
Please also note that
--always-makeor-Bparameter tomake(specified inREADME.md) is mandatory, otherwiseMakefilewon't rebuild with just only a different feature.The expected usage is: