Skip to content

Reduce size of cargo cache in CI#95

Merged
artob merged 3 commits intodevelopfrom
ci-caching-improvments
May 18, 2021
Merged

Reduce size of cargo cache in CI#95
artob merged 3 commits intodevelopfrom
ci-caching-improvments

Conversation

@birchmd
Copy link
Copy Markdown
Member

@birchmd birchmd commented May 18, 2021

Some low-hanging fruit to reduce the size of the CI cache, as suggested in #92 (comment)

@birchmd birchmd requested a review from artob May 18, 2021 13:39
@birchmd
Copy link
Copy Markdown
Member Author

birchmd commented May 18, 2021

cc @matklad (couldn't tag you as a reviewer for some reason)

@birchmd birchmd changed the base branch from master to develop May 18, 2021 13:41
@matklad
Copy link
Copy Markdown
Contributor

matklad commented May 18, 2021

LGTM! Might be a good idea to verify locally that these env vars do what I think they should do, as cargo won't warn you if there's a typo

@birchmd
Copy link
Copy Markdown
Member Author

birchmd commented May 18, 2021

Locally adding these environment variables reduces the size of target (freshly compiled after cargo clean) from 2.5 GB to 2.4 GB. Not a huge saving, but probably worth doing.

@matklad
Copy link
Copy Markdown
Contributor

matklad commented May 18, 2021

Aha, that's surprising (I'd expect something more like 3x reduction), but is explainable:

So we can remove profile envs, and leave the incremental one for a bright future when incremental is back again.

@artob artob self-assigned this May 18, 2021
@artob artob added A-ci Area: Continuous Integration (CI) C-enhancement Category: New feature or request labels May 18, 2021
@artob artob merged commit ca41305 into develop May 18, 2021
@artob artob deleted the ci-caching-improvments branch May 18, 2021 22:38
sept-en added a commit that referenced this pull request May 28, 2021
@sept-en @artob
@birchmd @matklad
Eth-connector: merge develop branch (#109)
540ccb1 
* Document `aurora encode-address` usage.

* Cache cargo artifacts between CI runs. (#92)

* Address comments from audit. (#86)

* Validate register length in `read_input_arr20()`
* Only read register length in `Engine::get_code_size`
* Add `read_input_borsh()`
* Ensure `method.args.len() == args_decoded.len()`
* Ensure register size is 8 in `read_u64`
* Use constant to specify the register ID used in `read_input()`

* Reduce size of `cargo cache` in CI. (#95)

* Define a `Wei` newtype for balances. (#96)

* Fix evm-bully builds after recent refactoring. (#100)

* Refactor `Engine::get_state` to return a `Result`. (#99)

* Ensure that `Cargo.lock` in the repo is valid. (#101)

* Remove unneeded nightly feature. (#102)

* Dispatch precompiles on the full address. (#107)

* Support state migration on upgrade. (#103)

* Remove resolved TODOs

* Fix state migration test

* Conditional compilation minor improvements.

Co-authored-by: Arto Bendiken <arto@aurora.dev>
Co-authored-by: Michael Birch <michael@near.org>
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
mfornet added a commit that referenced this pull request Jun 4, 2021
@joshuajbouw @mfornet
@artob @birchmd @matklad @mrLSD
Implement generational storage (#87)
d67b59e 
* Base precompile code between connectors (#73)

* Base precompile code between connectors

* Handle errors and validate input

* Use proper result

* Document `aurora encode-address` usage.

* Cache cargo artifacts between CI runs. (#92)

* Address comments from audit. (#86)

* Validate register length in `read_input_arr20()`
* Only read register length in `Engine::get_code_size`
* Add `read_input_borsh()`
* Ensure `method.args.len() == args_decoded.len()`
* Ensure register size is 8 in `read_u64`
* Use constant to specify the register ID used in `read_input()`

* Reduce size of `cargo cache` in CI. (#95)

* Define a `Wei` newtype for balances. (#96)

* Fix evm-bully builds after recent refactoring. (#100)

* Refactor `Engine::get_state` to return a `Result`. (#99)

* Ensure that `Cargo.lock` in the repo is valid. (#101)

* Remove unneeded nightly feature. (#102)

* Implement BC generational storage.

* fix address input

* remove note

* put key on the end of the storage key

* remove pub from methods

* Dispatch precompiles on the full address. (#107)

* Support state migration on upgrade. (#103)

* Implement the ETH connector. (#59)

* Move when to call `set_generation`

* Fix arg

Co-authored-by: Marcelo Fornet <mfornet94@gmail.com>
Co-authored-by: Arto Bendiken <arto@aurora.dev>
Co-authored-by: Michael Birch <michael@near.org>
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Co-authored-by: Evgeny Ukhanov <mrlsd@ya.ru>
mfornet added a commit that referenced this pull request Jun 10, 2021
@mfornet @birchmd
@joshuajbouw @artob @matklad @mrLSD
Implement generational storage with SELFDESTRUCT tests (#84)
2bf9b25 
* Add tests for state check after selfdestruct

* Aurora runner tracks storage usage to avoid underflow when storage is released in future transactions (#85)

* Implement generational storage (#87)

* Base precompile code between connectors (#73)

* Base precompile code between connectors

* Handle errors and validate input

* Use proper result

* Document `aurora encode-address` usage.

* Cache cargo artifacts between CI runs. (#92)

* Address comments from audit. (#86)

* Validate register length in `read_input_arr20()`
* Only read register length in `Engine::get_code_size`
* Add `read_input_borsh()`
* Ensure `method.args.len() == args_decoded.len()`
* Ensure register size is 8 in `read_u64`
* Use constant to specify the register ID used in `read_input()`

* Reduce size of `cargo cache` in CI. (#95)

* Define a `Wei` newtype for balances. (#96)

* Fix evm-bully builds after recent refactoring. (#100)

* Refactor `Engine::get_state` to return a `Result`. (#99)

* Ensure that `Cargo.lock` in the repo is valid. (#101)

* Remove unneeded nightly feature. (#102)

* Implement BC generational storage.

* fix address input

* remove note

* put key on the end of the storage key

* remove pub from methods

* Dispatch precompiles on the full address. (#107)

* Support state migration on upgrade. (#103)

* Implement the ETH connector. (#59)

* Move when to call `set_generation`

* Fix arg

Co-authored-by: Marcelo Fornet <mfornet94@gmail.com>
Co-authored-by: Arto Bendiken <arto@aurora.dev>
Co-authored-by: Michael Birch <michael@near.org>
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Co-authored-by: Evgeny Ukhanov <mrlsd@ya.ru>

* Fix layout of the key

* Fix all tests (don't wipe the storage all the time)

* Use correct generation in writing storage

* Remove unnecessary references

Co-authored-by: Michael Birch <michael@near.org>
Co-authored-by: Joshua J. Bouw <dev@joshuajbouw.com>
Co-authored-by: Arto Bendiken <arto@aurora.dev>
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Co-authored-by: Evgeny Ukhanov <mrlsd@ya.ru>
Co-authored-by: Michael Birch <michael.birch@aurora.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@artob artob artob approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@artob artob

Labels

A-ci Area: Continuous Integration (CI) C-enhancement Category: New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@birchmd @matklad @artob