Conversation
frankbraun
added
C-enhancement
sept-en
approved these changes
Jun 3, 2021
Contributor
sept-en
left a comment
sept-en
left a comment
There was a problem hiding this comment.
LGTM!
I also think that we should use develop as a base branch having the release protocol we have. I.e. the master points to the latest deployed version and the develop branch is the latest stable one that will be uploaded into master and released after that.
artob
suggested changes
Jun 3, 2021
Contributor
artob
left a comment
artob
left a comment
There was a problem hiding this comment.
This should be targeted at develop, not master. And there are copy-paste artifacts to remove.
The contract build for the evm-bully (`make evm-bully=yes`) often breaks. Add it to CI to prevent that from happening.
frankbraun
force-pushed
the
build_bully_artifact
branch
from
74c49e8 to
9397db4
Compare
Contributor
Author
|
I changed it to target |
artob
approved these changes
Jun 4, 2021
artob
added a commit
that referenced
this pull request
Jun 5, 2021
* Remove the dependency on Lunarity. (#115) * Fix Clippy complaint with +nightly. (#117) * Add an `evm-bully=yes` build to CI. (#121) * Fix evm-bully builds. (#130) * Handle transaction gas limit properly. (#123) * Add an `is_used_proof` interface. (#120) * Simplify the `sdk::read_u64` return type. (#118) Co-authored-by: Frank Braun <frank@near.org> Co-authored-by: Joshua J. Bouw <dev@joshuajbouw.com> Co-authored-by: Kirill Abramov <septengineering@pm.me> Co-authored-by: Michael Birch <michael@near.org>
artob
added a commit
that referenced
this pull request
Jun 17, 2021
* Introduce precompiles for the ETH & ERC-20 connectors. (#51) * Implement generational storage with `SELFDESTRUCT` tests. (#84) * Remove the dependency on Lunarity. (#115) * Fix Clippy complaint with `+nightly`. (#117) * Simplify the `sdk::read_u64` return type. (#118) * Add an `is_used_proof` interface. (#120) * Add an `evm-bully=yes` build to CI. (#121) * Handle transaction gas limit properly. (#123) * Fix u128 JSON parsing & tests in the ETH connector. (#125) * Fix evm-bully builds. (#130) * Add JSON custom error types. (#131) * Don't burn NEP-141 on deposit. (#133) * Fix needless borrows. (#135) * Improve and refactor the ETH connector. (#136) * Add a macro for logging. (#142) Co-authored-by: Aleksey Kladov <aleksey@near.org> Co-authored-by: Arto Bendiken <arto@aurora.dev> Co-authored-by: Evgeny Ukhanov <evgeny@aurora.dev> Co-authored-by: Frank Braun <frank@aurora.dev> Co-authored-by: Joshua J. Bouw <joshua@aurora.dev> Co-authored-by: Kirill <kirill@aurora.dev> Co-authored-by: Marcelo Fornet <marcelo@aurora.dev> Co-authored-by: Michael Birch <michael@aurora.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The contract build for the evm-bully (
make evm-bully=yes) often breaks.Add it to CI to prevent that from happening.