ETH connector by mrLSD · Pull Request #59 · aurora-is-near/aurora-engine

mrLSD · 2021-05-05T16:42:48Z

ETH connector contains fugible token logic for specific flow.
To verify logic:

DIagram - represent Diagram of algorithm and process flow
Formal specification - represent algorithm in a formal way as functional style code with full type inference.

… prover

* EIP712-Withdraw: fixed encoding rules and order. * EIP712-Withdraw: `verify_withdraw_eip712` returns `true` only if the sender address equals to the address of message signer. * EIP712-Withdraw: update tests. * EIP712-Withdraw: refactoring. * ethabit::encode_token_packed: use right-padded encoding for `Address`. * WithdrawFromEthCallArgs: fixed `amount` type conversion.

…ra-engine into evm-deposit-withdraw

sept-en · 2021-05-13T14:53:01Z

+            if fee > 0 {
+                let evm_relayer_address: EthAddress = engine
+                    .get_relayer(&message_data.relayer.as_bytes())
+                    .expect("ERR_WRONG_RELAYER_ID")
+                    .0;
+                self.mint_eth(evm_relayer_address, fee);
+            }


This part works incorrectly and actually is critical. Currently, this works like that:

If the fee is zero, the user receives the full amount, and the transaction is "Succeeded".

If the fee is greater than thero:
a) Query for the registered relayer, the relayer is registered. Then mint appropriate amount of fee to the relayer. The transaction is "Succeeded".
b) Query for the registered relayer, the relayer is NOT registered. So we panic with "ERR_WRONG_RELAYER_ID", the transaction is "Failed". The user is not receiving his money, the proof was recorded as used on the previous steps so it's not possible to finish the deposit for this transaction any more. So basically, it's easy to burn any produced proof by not registering the relayer.

The suggested solution for that is the following:

Make sure we never ever panic in the ft_on_transfer execution (at least for the ETH branch), as the proof was recorded on the previous steps so we won't be able to restore it.

If the fee > 0, but there's no registered relayer for the predecessor account, mint the fee to the recipient as well. If we don't mint the fee for the recipient, this amount won't be minted and there's no sense in it.

@mrLSD @joshuajbouw @artob

Note also the todo

Hugely important on what you said. If there is a proof, we need to be able to use it on the previous steps. They must ALWAYS be restorable, only once, of course.

There's no way to straight-forwardly revert the chain of promises at the moment. So this is correct that the proof is recorded in the previous step and only after that the tokens are minted. This protects from proof reusage and possible reentrancy attempts. We just need to try making all possible checks before storing the proof and don't let it panic at a later stage.

Good point!
@joshuajbouw FYI it's not related to Proof. We can reproduce it without Deposit call because ft_transfer_call is a public method.

@sept-en @joshuajbouw I fixed that issue. Also, I placed an early checker for all possible assertions in ft_on_transfer.

mrLSD · 2021-05-20T20:14:47Z

Improvements & proposals:
#98 #104

sept-en · 2021-05-20T21:01:16Z

+        } else {
+            None
+        }


This is wrong as according to the NEP-145 specs: If the account is unknown to the contract then the total account storage balance returned will be zero.
So we need to always return StorageBalance, and zero for unknown accounts.

Fixed at #98

Please note the appropriate issue in near-sdk-rs.

* Eugene's review 2021-05-08 * Eth connector improvements after review 2021-05-18 (#98) * Adde improvements afterreview - account checking, msg len check, json lib * Added json parser. Changed balance_of * Fixed balance_of test * json for ft_transfer & fix test * Json args for ft_transfer_call & fixed tests * Added json for FT storage methods * Fix ft_resolve transfer promise result check. Removed total_supply_near * Fix to NEP-145: storage_balance_of * Fix storage_balance_of to NEP-145 * Eth connector statistic (#104) * Added get_accounts_counter & tests * Clippy fix * Fixed: check accounts_contains_key & added comments * Lint: cargo fmt * Chanched key for Statistics * Update src/connector.rs Imptove comments Co-authored-by: Michael Birch <michael@near.org> * Changed: - get_accounts_counter - return le_bytes Added: - test_get_accounts_counter_and_transfer - check recalculation accounts Co-authored-by: Michael Birch <michael@near.org> Co-authored-by: Michael Birch <michael@near.org> Co-authored-by: Evgeny Ukhanov <mrlsd@ya.ru> Co-authored-by: Michael Birch <michael@near.org>

sept-en · 2021-05-27T14:40:48Z

+    Contract = 0x0,
+    FungibleToken = 0x1,
+    UsedEvent = 0x2,
+    StatisticsAuroraAccountsCounter = 0x3,


It makes sense to start statistics Id from something like 0xF or 0x10. So if other fields related to the contract itself are added in the future, they will come in order and not going to be mixed with Ids for Statistics.

I'll create a PR for that.

* Added tests: * test_deposit_near_with_zero_fee * test_deposit_evm_with_zero_fee * Added: * test_deposit_evm_amount_equal_fee_non_zero * check_execution_status_failure * Improved: * test_deposit_with_same_proof Added: * test_deposit_wrong_custodian_address * Added tests: * test_deposit_near_amount_less_fee * test_deposit_evm_amount_less_fee * test_deposit_near_amount_zero_fee_non_zero * test_deposit_evm_amount_zero_fee_non_zero * test_deposit_near_amount_equal_fee_non_zero * Changed: test_deposit_wrong_custodian_address

* EthConnector: make AdminControlled and pausable. * EthConnector: add AdminControlled&pausability tests. * Stylystic fixes. * AdminControlled: add panic message when paused. * AdminControlled: minor refactoring. * AdminControlled: add errors. Naming improvements. * AdminControlled: doc improvements. * Test fixes. * Fix fmt * AdminControlled: make IO in main contract module. * AdminControlled:explicitly check panic msg in tests.

* Rename `check_execution_status_failure()` method to `assert_execution_status_failure()`; * `assert_execution_status_failure()`: accept panic message as an arg. * Explicitly specify the panic message for each `assert_execution_status_failure()` if the promise didn't fail with the provided error message. * Eth-connector tests: improve checks for failure msg. * Usually the converted to string has either of the following two messages formats: "Action #0: Smart contract panicked: ERR_MSG [src/some_file.rs:LINE_NUMBER:COLUMN_NUMBER]" "right: 'MISMATCHED_DATA': ERR_MSG [src/some_file.rs:LINE_NUMBER:COLUMN_NUMBER]" So the ": ERR_MSG [" pattern should catch all invariants of error, even if one of the errors message is a subset of another one (e.g. `ERR_MSG_FAILED` is a subset of `ERR_MSG_FAILED_FOO`).

* Document `aurora encode-address` usage. * Cache cargo artifacts between CI runs. (#92) * Address comments from audit. (#86) * Validate register length in `read_input_arr20()` * Only read register length in `Engine::get_code_size` * Add `read_input_borsh()` * Ensure `method.args.len() == args_decoded.len()` * Ensure register size is 8 in `read_u64` * Use constant to specify the register ID used in `read_input()` * Reduce size of `cargo cache` in CI. (#95) * Define a `Wei` newtype for balances. (#96) * Fix evm-bully builds after recent refactoring. (#100) * Refactor `Engine::get_state` to return a `Result`. (#99) * Ensure that `Cargo.lock` in the repo is valid. (#101) * Remove unneeded nightly feature. (#102) * Dispatch precompiles on the full address. (#107) * Support state migration on upgrade. (#103) * Remove resolved TODOs * Fix state migration test * Conditional compilation minor improvements. Co-authored-by: Arto Bendiken <arto@aurora.dev> Co-authored-by: Michael Birch <michael@near.org> Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>

* Add `set_eth_connector_contract_data()` method. * Minor refactoring: `init_contract()` method now accepts `InitCallArgs` instead of making IO operations in it.

…gine into eth-connector-merge-develop-after-target-change

* Base precompile code between connectors (#73) * Base precompile code between connectors * Handle errors and validate input * Use proper result * Document `aurora encode-address` usage. * Cache cargo artifacts between CI runs. (#92) * Address comments from audit. (#86) * Validate register length in `read_input_arr20()` * Only read register length in `Engine::get_code_size` * Add `read_input_borsh()` * Ensure `method.args.len() == args_decoded.len()` * Ensure register size is 8 in `read_u64` * Use constant to specify the register ID used in `read_input()` * Reduce size of `cargo cache` in CI. (#95) * Define a `Wei` newtype for balances. (#96) * Fix evm-bully builds after recent refactoring. (#100) * Refactor `Engine::get_state` to return a `Result`. (#99) * Ensure that `Cargo.lock` in the repo is valid. (#101) * Remove unneeded nightly feature. (#102) * Implement BC generational storage. * fix address input * remove note * put key on the end of the storage key * remove pub from methods * Dispatch precompiles on the full address. (#107) * Support state migration on upgrade. (#103) * Implement the ETH connector. (#59) * Move when to call `set_generation` * Fix arg Co-authored-by: Marcelo Fornet <mfornet94@gmail.com> Co-authored-by: Arto Bendiken <arto@aurora.dev> Co-authored-by: Michael Birch <michael@near.org> Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com> Co-authored-by: Evgeny Ukhanov <mrlsd@ya.ru>

* Add tests for state check after selfdestruct * Aurora runner tracks storage usage to avoid underflow when storage is released in future transactions (#85) * Implement generational storage (#87) * Base precompile code between connectors (#73) * Base precompile code between connectors * Handle errors and validate input * Use proper result * Document `aurora encode-address` usage. * Cache cargo artifacts between CI runs. (#92) * Address comments from audit. (#86) * Validate register length in `read_input_arr20()` * Only read register length in `Engine::get_code_size` * Add `read_input_borsh()` * Ensure `method.args.len() == args_decoded.len()` * Ensure register size is 8 in `read_u64` * Use constant to specify the register ID used in `read_input()` * Reduce size of `cargo cache` in CI. (#95) * Define a `Wei` newtype for balances. (#96) * Fix evm-bully builds after recent refactoring. (#100) * Refactor `Engine::get_state` to return a `Result`. (#99) * Ensure that `Cargo.lock` in the repo is valid. (#101) * Remove unneeded nightly feature. (#102) * Implement BC generational storage. * fix address input * remove note * put key on the end of the storage key * remove pub from methods * Dispatch precompiles on the full address. (#107) * Support state migration on upgrade. (#103) * Implement the ETH connector. (#59) * Move when to call `set_generation` * Fix arg Co-authored-by: Marcelo Fornet <mfornet94@gmail.com> Co-authored-by: Arto Bendiken <arto@aurora.dev> Co-authored-by: Michael Birch <michael@near.org> Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com> Co-authored-by: Evgeny Ukhanov <mrlsd@ya.ru> * Fix layout of the key * Fix all tests (don't wipe the storage all the time) * Use correct generation in writing storage * Remove unnecessary references Co-authored-by: Michael Birch <michael@near.org> Co-authored-by: Joshua J. Bouw <dev@joshuajbouw.com> Co-authored-by: Arto Bendiken <arto@aurora.dev> Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com> Co-authored-by: Evgeny Ukhanov <mrlsd@ya.ru> Co-authored-by: Michael Birch <michael.birch@aurora.dev>

mrLSD and others added 30 commits April 1, 2021 19:48

Added prover & extended types

98b302a

Mode Borsh args from types to parameters

97a3759

Merge branch 'master' of github.com:aurora-is-near/aurora-engine into…

a889328

… prover

Added fungible tokens

25154f0

Added eth-connector

a0942a2

Modify assert for fee

5876814

Fix formatting

facc786

Extend eth-conenctor with EVM token logic

b055a54

Changed eth-connector deposit logic

eb9e361

Added changes for ETH deposit/withdraw and Engine changes

fcc1332

Mint ETH-tokens

978474b

Added: transfer_eth

041879e

ETH withdraw basic method

b5ffb23

eth-withdraw validation structure & modified Deposit-eth fields

a7e73f4

eth transfer and withdraw logic

45a5ca9

eip712 message verifier - started encoding

676a86c

added encode-packed

e345d71

virefy EIP712 message for withdraw

de7f36d

Changed EIP712 message fields

f1f6479

Modify logs for EIP712 messages

944b6e2

Test EIP712

1201a39

Tests EIP712

11dec10

Integration tests for encode_withdraw_eip712

89f572c

Integration tests for encode_withdraw_eip712

d6830ea

Extend tests for eth-connector

96b3c0e

Merge branch 'evm-deposit-withdraw' of github.com:aurora-is-near/auro…

348e5cc

…ra-engine into evm-deposit-withdraw

eth-connector test deposit & balance & total_supply

80f033b

Imporved tests

07251fd

FT tests

2de5af8

sept-en reviewed May 13, 2021

View reviewed changes

mrLSD and others added 7 commits May 13, 2021 20:50

Fix ft_on_transfer relayer fee mint

5b0e843

Early checking for ft_transfer_call message data

f2a24fe

Changed finish_deposit_near - asserts before save Proof hash

d7298dd

Use storage::bytes_to_key in EthConnectorContract::get_contract_key

3b3e2f2

Added test_ft_transfer_call_without_relayer

d7d902e

Added test_ft_transfer_call_fee_greater_than_amount

19fa058

Added overflow check: ft_transfer_call

f180a08

sept-en suggested changes May 20, 2021

View reviewed changes

Evgeny Kuzyakov and others added 2 commits May 26, 2021 10:16

Fix tests for eth-connector

b4a5d1e

sept-en reviewed May 27, 2021

View reviewed changes

mrLSD and others added 7 commits May 27, 2021 23:26

EthConnector: restrict connector init to owner. (#112)

29785ce

Add compilation feature for exit precompiles. (#111)

f86197d

Eth-connector:add the way to upgrade contract data. (#113)

ab69d39

* Add `set_eth_connector_contract_data()` method. * Minor refactoring: `init_contract()` method now accepts `InitCallArgs` instead of making IO operations in it.

artob changed the base branch from master to develop May 28, 2021 19:25

artob assigned sept-en and unassigned mrLSD May 28, 2021

Merge branch 'develop' of https://github.com/aurora-is-near/aurora-en…

60374b6

…gine into eth-connector-merge-develop-after-target-change

artob assigned artob and unassigned sept-en May 28, 2021

artob merged commit 5144281 into develop May 28, 2021

artob deleted the eth-connector branch May 28, 2021 20:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ETH connector#59

ETH connector#59
artob merged 119 commits into
developfrom
eth-connector

mrLSD commented May 5, 2021 •

edited

Loading

Uh oh!

sept-en May 13, 2021

Uh oh!

sept-en May 13, 2021

Uh oh!

joshuajbouw May 13, 2021

Uh oh!

joshuajbouw May 13, 2021

Uh oh!

sept-en May 13, 2021

Uh oh!

mrLSD May 13, 2021

Uh oh!

mrLSD May 13, 2021 •

edited

Loading

Uh oh!

mrLSD commented May 20, 2021 •

edited

Loading

Uh oh!

sept-en May 20, 2021

Uh oh!

mrLSD May 20, 2021

Uh oh!

sept-en May 20, 2021

Uh oh!

Uh oh!

sept-en May 27, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

mrLSD commented May 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mrLSD May 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mrLSD commented May 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mrLSD commented May 5, 2021 •

edited

Loading

mrLSD May 13, 2021 •

edited

Loading

mrLSD commented May 20, 2021 •

edited

Loading