Skip to content

Feat(engine): Use new math API host functions#190

Merged
joshuajbouw merged 6 commits intodevelopfrom
new-host-function-support
Jul 22, 2021
Merged

Feat(engine): Use new math API host functions#190
joshuajbouw merged 6 commits intodevelopfrom
new-host-function-support

Conversation

@birchmd
Copy link
Copy Markdown
Member

@birchmd birchmd commented Jul 19, 2021

Updates our contract to use the new host functions merged in near/nearcore#4380

Note: these host functions have not yet been released to mainnet, but they are on testnet. The host functions are in protocol version 46; you can see here that 46 is the version of testnet, while mainnet is still on 45.

Using the host functions (specifically ecrecover) makes simple ETH transfer on Aurora less than 1/5th the cost in terms of NEAR gas.

Requires #193 before merging.

@birchmd birchmd added the C-enhancement Category: New feature or request label Jul 19, 2021
Copy link
Copy Markdown
Contributor

@joshuajbouw joshuajbouw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should use the testnet feature so that we don't accidentally use it prematurely.

Comment thread src/sdk.rs Outdated
Comment thread src/sdk.rs
@birchmd
Copy link
Copy Markdown
Member Author

birchmd commented Jul 20, 2021

testnet feature

Done in 5c5544b

@birchmd birchmd requested a review from joshuajbouw July 20, 2021 13:01
@joshuajbouw
Copy link
Copy Markdown
Contributor

Requires #193 before merging.

@joshuajbouw joshuajbouw merged commit 4ffc159 into develop Jul 22, 2021
@joshuajbouw joshuajbouw deleted the new-host-function-support branch July 22, 2021 10:49
artob added a commit that referenced this pull request Jul 30, 2021
* JSON: fix bugs and add unit tests. (#141)
* Add storage layout debug support for `EvmErc20.sol`. (#178)
* ERC-20: forbid using invalid NEP-141 AccountID for mapping. (#179)
* Add EIP-2930 support. (#181, #182)
* Migrate all workflows to self-hosted runners. (#185)
* Speed up the workflow using build caching. (#189)
* Use the new math API host functions. (#190)
* Fix `clippy::enum_variant_names` warning. (#192)
* Add different networks to the Makefile. (#193)
* Update the network status in the README. (#194)
* Remove the toolchain installation step in workflows. (#195)
* Run all tests for all networks in CI. (#196)
* Optimize for performance instead of code size. (#197)
* Parallelize the test suites. (#198)
* Add build-caching to the testing workflow. (#201)
* Refactor tests to use Signer. (#203)
* Add options to the bench profile. (#204)
* Remove a duplicate test. (#205)
* Add a sanity test for access list handling. (#206)
* Update nearcore to the latest branch.
* Add feature gates to the SDK's new host functions.

Co-authored-by: Ahmed Ali <ahmed@aurora.dev>
Co-authored-by: Dmitry Strokov <dmitry@aurora.dev>
Co-authored-by: Evgeny Ukhanov <evgeny@aurora.dev>
Co-authored-by: Joshua J. Bouw <joshua@aurora.dev>
Co-authored-by: Kirill <kirill@aurora.dev>
Co-authored-by: Michael Birch <michael@aurora.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-enhancement Category: New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants