Skip to content

ERC-20: allow admin to change metadata#171

Merged
artob merged 7 commits intodevelopfrom
erc20-metadata
Jul 8, 2021
Merged

ERC-20: allow admin to change metadata#171
artob merged 7 commits intodevelopfrom
erc20-metadata

Conversation

@sept-en
Copy link
Copy Markdown
Contributor

@sept-en sept-en commented Jul 8, 2021

No description provided.

@sept-en sept-en added C-enhancement Category: New feature or request P-critical Priority: critical labels Jul 8, 2021
0x3bfc
0x3bfc reviewed Jul 8, 2021
View reviewed changes
Comment thread etc/eth-contracts/contracts/EvmErc20.sol
0x3bfc
0x3bfc reviewed Jul 8, 2021
View reviewed changes
Comment thread etc/eth-contracts/contracts/EvmErc20.sol
0x3bfc
0x3bfc reviewed Jul 8, 2021
View reviewed changes
Comment thread etc/eth-contracts/contracts/EvmErc20.sol
0x3bfc
0x3bfc suggested changes Jul 8, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@0x3bfc 0x3bfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes

mfornet
mfornet approved these changes Jul 8, 2021
View reviewed changes
Comment thread etc/eth-contracts/hardhat.config.js
@artob artob self-assigned this Jul 8, 2021
artob
artob approved these changes Jul 8, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@artob artob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

As a general note, as discussed with @sept-en today, we ought to be checking in the resulting Solidity bytecode as well, since it isn't necessarily 100% reproducible otherwise. I'll add that.

@artob artob merged commit 0bae6ec into develop Jul 8, 2021
@artob artob deleted the erc20-metadata branch July 8, 2021 19:36
artob added a commit that referenced this pull request Jul 8, 2021
@artob @mrLSD @sept-en
Release 1.4.3. (#172)
d2f2e32 
* Fix scheduled nightly clippy. (#160)
* Always compile tests with the `mainnet` feature. (#162)
* Move eth-connector tests to under `src/tests`. (#164)
* EIP-2718: Support typed transaction envelopes. (#165)
* Remove deprecated EIP-712 prover implementation. (#168)
* ERC-20: Allow admin to change token metadata. (#171)

Co-authored-by: Evgeny Ukhanov <evgeny@aurora.dev>
Co-authored-by: Kirill <kirill@aurora.dev>
Co-authored-by: Michael Birch <michael@aurora.dev>
@sept-en sept-en mentioned this pull request Jul 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@birchmd birchmd birchmd approved these changes

@joshuajbouw joshuajbouw Awaiting requested review from joshuajbouw

+3 more reviewers

@artob artob artob approved these changes

@0x3bfc 0x3bfc 0x3bfc approved these changes

@mfornet mfornet mfornet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@artob artob

Labels

C-enhancement Category: New feature or request P-critical Priority: critical

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sept-en @artob @0x3bfc @birchmd @mfornet