Add EIP-2565 support#138
Merged
Merged
Conversation
joshuajbouw
force-pushed
the
feat/berlin/eip_2565
branch
from
a377723 to
76e55d5
Compare
joshuajbouw
force-pushed
the
feat/berlin/eip_2565
branch
from
5c4027c to
592eff2
Compare
birchmd
reviewed
Jun 11, 2021
birchmd
reviewed
Jun 11, 2021
birchmd
requested changes
Jun 11, 2021
Member
birchmd
left a comment
birchmd
left a comment
There was a problem hiding this comment.
Actually, sorry, I found a small mistake, undoing my approve for now
birchmd
requested changes
Jun 11, 2021
birchmd
reviewed
Jun 11, 2021
birchmd
requested changes
Jun 14, 2021
Member
birchmd
left a comment
birchmd
left a comment
There was a problem hiding this comment.
Thanks for pushing the new changes! There are still a couple issues with the implementation I think. Maybe we need tests that use really big values for the inputs (bigger than could fit in a U256) because I think the issues would only appear from very large inputs.
Co-authored-by: Michael Birch <michael@near.org>
Co-authored-by: Michael Birch <michael@near.org>
joshuajbouw
force-pushed
the
feat/berlin/eip_2565
branch
from
5fdb031 to
58a913a
Compare
Contributor
Author
|
@birchmd I'll finish the rest up once I get back from some sleep. Exhausted right now. Thanks for the review. |
Co-authored-by: Michael Birch <michael@near.org>
Co-authored-by: Michael Birch <michael@near.org>
birchmd
requested changes
Jun 15, 2021
birchmd
approved these changes
Jun 15, 2021
Member
There was a problem hiding this comment.
I made several changes around overflow handling as well wrote some functions for dealing with the slices to avoid index out of bounds panics (this behaviour is the same as geth). I also added some tests to make sure it all works. Should be good to go now.
Contributor
Author
|
Thanks for the clean up. |
Contributor
|
@joshuajbouw I'd want to merge this to |
joshuajbouw
force-pushed
the
feat/berlin/eip_2565
branch
from
3ce740d to
4fcf44f
Compare
artob
approved these changes
Jun 17, 2021
artob
added a commit
that referenced
this pull request
Jun 18, 2021
* Implement EIP-2565 support. (#138) * Fix CI debug pipeline. (#145) * Enable `meta_call` only with feature flag. (#146) * Add `mainnet`, `testnet`, and `betanet` feature flags. (#147) * Prohibit static calls in exit precompiles. (#148) * Fix `clippy::unnecessary_unwrap`. (#149) * Fix all Clippy warnings. (#150) * Create the `ExitToNear` receiver account if it does not exist. (#151) Co-authored-by: Joshua J. Bouw <joshua@aurora.dev> Co-authored-by: Kirill <kirill@aurora.dev> Co-authored-by: Marcelo Fornet <marcelo@aurora.dev> Co-authored-by: Michael Birch <michael@aurora.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is EIP 1 out of 4 for the Berlin hardfork.
For this one, it's the
modexpgas cost changes. For more details, see the linked reference below.Reference: https://eips.ethereum.org/EIPS/eip-2565