Introduce precompiles to manage ERC20 connector by mfornet · Pull Request #51 · aurora-is-near/aurora-engine

mfornet · 2021-05-04T12:27:52Z

This creates two new precompiles:

exit_to_near
exit_to_ethereum

Their main role is scheduling a promise call outside of the EVM to another Near contract.
Check this diagram for reference.

Testing Plan

This are a set of basic tests that should be implemented before merging. This tests only include happy path for expected workflows, but it is important to cover with tests that other interaction are behaving as expected (tokens can't get lost or stolen).

(Rust Test) Can deploy ERC20 tokens from the EVM
(Rust Test) Can mint some tokens from admin access function
(Rust Test) ft_on_transfer from ERC20
(Rust Test) Register relayer (and check fee is ok from ft_on_transfer)
(Rust Test) Check that relayer gets payed
(Rust Test) Exit to Near
(Rust Test) Exit to Ethereum

Integration tests should spinup Ganache, and Localnet and run there, to make sure each workflow is behaving correctly in a environment closer to production.

(~~Integration~~ Manual Test) Send tokens from Near -> EVM
(~~Integration~~ Manual Test) Send tokens from EVM -> Near
(~~Integration~~ Manual Test) Send tokens from Ethereum -> EVM
(~~Integration~~ Manual Test) Send tokens from EVM -> Ethereum

Test contract_call is only scheduled appropriately:

Create a solidity with these functions:

A -> Call the precompile (which in turns schedule a contract_call on success)
B -> Call A as an external function and run require(false)
C -> Call B and catch the error (so the function doesn’t fail)
D -> Call C and Call A

Scenarios:

Call A and check contract call was emitted
Call B and check no contract call was emitted and tx failed
Call C and check no contract call was emitted and tx succeeded
Call D and check that ONLY one contract call was emitted and tx succeded
Previos set of tests should be executed with ExitToNear and ExitToEthereum

joshuajbouw

Just some small changes, and also to have it fit with the other precompiles. I believe it also needs to be added to the other precompile functions.

sept-en · 2021-05-04T14:58:37Z

@joshuajbouw thanks for your help, LGTM!
@mfornet please take a look at the updated code and approve if everything looks good for you as well.

* Add common code between #51 and #59 * Address comments * Avoid writing const prefix to the storage * Nit

* Add custom erc20 contract to the EVM. To compile the EVM it is required to compile ERC20 first if this change is used. Do this using the following steps: cd eth-contracts yarn yarn compile This will generate relevant binary in: `eth-contracts/res/EvmErc20.bin` * Move eth contract to etc and update Makefile * Fix CI * Add lint

joshuajbouw · 2021-06-10T17:18:20Z

I feel uncertain why we need an AuroraStackState, and why the precompiles now need the state implemented? I almost went down this path, but found solutions around not having to.

The reason is because we need to know what promises were asked to be created (from calls to exit precompiles), but we can't have the precompiles eagerly create the promises because then they cannot be rolled back if the transaction (or sub-call in a transaction) reverts.

The AuroraStackState keeps track of the data needed to construct the promises and only once the entire transaction is finished do we actually create them.

Right, I get the context now. I just saw this PR rust-ethereum/evm#34 as well. Makes sense. The design still feels a little off to me, but this is critical for our deliverable for the end of the week, so let's just roll with how it is for now. Eventually, maybe something will come up where it can be improved.

artob · 2021-06-11T10:19:01Z

@mfornet Please fix the merge conflicts and re-request reviews as needed.

artob

@mfornet Please note you have a lot of Clippy warnings and address those in a follow-up PR.

sept-en

LGTM! Great job!

There are some minor comments that I think need to be addressed and resolved.

* Introduce precompiles for the ETH & ERC-20 connectors. (#51) * Implement generational storage with `SELFDESTRUCT` tests. (#84) * Remove the dependency on Lunarity. (#115) * Fix Clippy complaint with `+nightly`. (#117) * Simplify the `sdk::read_u64` return type. (#118) * Add an `is_used_proof` interface. (#120) * Add an `evm-bully=yes` build to CI. (#121) * Handle transaction gas limit properly. (#123) * Fix u128 JSON parsing & tests in the ETH connector. (#125) * Fix evm-bully builds. (#130) * Add JSON custom error types. (#131) * Don't burn NEP-141 on deposit. (#133) * Fix needless borrows. (#135) * Improve and refactor the ETH connector. (#136) * Add a macro for logging. (#142) Co-authored-by: Aleksey Kladov <aleksey@near.org> Co-authored-by: Arto Bendiken <arto@aurora.dev> Co-authored-by: Evgeny Ukhanov <evgeny@aurora.dev> Co-authored-by: Frank Braun <frank@aurora.dev> Co-authored-by: Joshua J. Bouw <joshua@aurora.dev> Co-authored-by: Kirill <kirill@aurora.dev> Co-authored-by: Marcelo Fornet <marcelo@aurora.dev> Co-authored-by: Michael Birch <michael@aurora.dev>

* Introduce precompiles for the ETH & ERC-20 connectors. (#51) * Implement generational storage with `SELFDESTRUCT` tests. (#84) * Fix u128 JSON parsing & tests in the ETH connector. (#125) * Add JSON custom error types. (#131) * Don't burn NEP-141 on deposit. (#133) * Fix needless borrows. (#135) * Improve and refactor the ETH connector. (#136) * Add a macro for logging. (#142) Co-authored-by: Aleksey Kladov <aleksey@near.org> Co-authored-by: Arto Bendiken <arto@aurora.dev> Co-authored-by: Evgeny Ukhanov <evgeny@aurora.dev> Co-authored-by: Frank Braun <frank@aurora.dev> Co-authored-by: Joshua J. Bouw <joshua@aurora.dev> Co-authored-by: Kirill <kirill@aurora.dev> Co-authored-by: Marcelo Fornet <marcelo@aurora.dev> Co-authored-by: Michael Birch <michael@aurora.dev>

mfornet requested review from artob, frankbraun, joshuajbouw and sept-en and removed request for frankbraun May 4, 2021 12:27

artob added the C-enhancement Category: New feature or request label May 4, 2021

artob requested a review from birchmd May 4, 2021 12:51

joshuajbouw suggested changes May 4, 2021

View reviewed changes

artob requested a review from mrLSD May 4, 2021 13:18

sept-en force-pushed the erc20-precompiles branch from a309fce to 55e5457 Compare May 4, 2021 13:35

sept-en approved these changes May 4, 2021

View reviewed changes

mfornet requested review from joshuajbouw and sept-en May 4, 2021 15:35

mfornet marked this pull request as draft May 4, 2021 15:45

artob assigned mfornet May 5, 2021

mfornet mentioned this pull request May 5, 2021

Add custom erc20 contract to the EVM. #53

Merged

mrLSD requested changes May 5, 2021

View reviewed changes

Comment thread src/engine.rs Outdated

mfornet added a commit that referenced this pull request May 6, 2021

Add common code between #51 and #59

9c83967

mfornet force-pushed the erc20-precompiles branch from 98bce50 to ecc2b36 Compare May 6, 2021 21:24

mfornet added a commit that referenced this pull request May 6, 2021

Add common code between #51 and #59 (#62)

ccbc544

* Add common code between #51 and #59 * Address comments * Avoid writing const prefix to the storage * Nit

sept-en and others added 9 commits May 6, 2021 23:40

Add connector precompiles: WIP.

193418e

Update required precompiles for ERC20-Connector

c4b85a9

fix style and refactor

88faeec

Address comments

f54d3ab

Add map to register tokens in the evm (#52)

17fb6a6

rustfmt

9143800

rename gas related costs

1b97f2c

Implement ft_on_transfer and register_relayer

ebcda33

mfornet added 3 commits June 10, 2021 19:48

nit

d2106cb

Add doc string for register_len

386fcde

Update promise error

d323edd

mfornet requested a review from joshuajbouw June 10, 2021 18:37

sept-en reviewed Jun 10, 2021

View reviewed changes

Comment thread src/precompiles/native.rs Outdated

sept-en reviewed Jun 10, 2021

View reviewed changes

Comment thread src/precompiles/native.rs Outdated

birchmd mentioned this pull request Jun 15, 2021

Macro for logging #142

Merged

mfornet added 3 commits June 16, 2021 04:47

Update interface to communicate with token-connector

f643c8e

Fix precompile for eth-connector

9a58ab1

Merge branch 'develop' into erc20-precompiles

fdcaf44

sept-en reviewed Jun 16, 2021

View reviewed changes

Comment thread src/json.rs

sept-en reviewed Jun 16, 2021

View reviewed changes

Comment thread src/lib.rs Outdated

mfornet added 5 commits June 16, 2021 19:48

Refactor after merge

3b10f8c

Use Json for NEP141 interface

f5a3530

Merge remote-tracking branch 'origin/develop' into erc20-precompiles

221a3fd

Use clippy suggestion

c95e3af

Fix failing tests

abc8641

mfornet requested a review from sept-en June 17, 2021 00:59

mfornet added 2 commits June 17, 2021 03:04

Use upstream sputnik vm

3f46802

Use pre-computed selector

9cfb2fe

artob approved these changes Jun 17, 2021

View reviewed changes

artob merged commit cbb878f into develop Jun 17, 2021

artob deleted the erc20-precompiles branch June 17, 2021 08:44

artob mentioned this pull request Jun 17, 2021

Eth-connector: change total_supply behaviour. Refactoring. #136

Merged

sept-en reviewed Jun 17, 2021

View reviewed changes

Comment thread src/engine.rs

Comment thread src/lib.rs

Comment thread src/deposit_event.rs

joshuajbouw mentioned this pull request Apr 5, 2022

Feat(Engine): Add custom precompile for NEAR prepaid_gas #479

Merged

Conversation

mfornet commented May 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Testing Plan

Uh oh!

joshuajbouw left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sept-en commented May 4, 2021

Uh oh!

Uh oh!

joshuajbouw commented Jun 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

artob commented Jun 11, 2021

Uh oh!

Uh oh!

Uh oh!

artob left a comment

Choose a reason for hiding this comment

Uh oh!

sept-en left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mfornet commented May 4, 2021 •

edited

Loading

joshuajbouw commented Jun 10, 2021 •

edited

Loading

sept-en left a comment •

edited

Loading