Skip to content

Fix(engine): handle transaction gas limit properly#123

Merged
artob merged 5 commits into
aurora-is-near:developfrom
birchmd:119-intrinsic-gas
Jun 4, 2021
Merged

Fix(engine): handle transaction gas limit properly#123
artob merged 5 commits into
aurora-is-near:developfrom
birchmd:119-intrinsic-gas

Conversation

@birchmd
Copy link
Copy Markdown
Member

@birchmd birchmd commented Jun 3, 2021

Fixes #119

birchmd
birchmd commented Jun 3, 2021
View reviewed changes
Copy link
Copy Markdown
Member Author

@birchmd birchmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some clarifying questions:

Comment thread src/lib.rs
Comment thread src/lib.rs Outdated
Comment thread src/engine.rs Outdated
@artob artob added C-bug Category: Something isn't working. C-enhancement Category: New feature or request P-critical Priority: critical labels Jun 3, 2021
joshuajbouw
joshuajbouw approved these changes Jun 4, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@joshuajbouw joshuajbouw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight forward

sept-en
sept-en approved these changes Jun 4, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@sept-en sept-en left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

artob
artob approved these changes Jun 4, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@artob artob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Great work, @birchmd. The only thing that stuck out is that we might better define a max gas constant instead of using u64::MAX all over the place, but we can address that later.

@artob artob merged commit aaeec76 into aurora-is-near:develop Jun 4, 2021
@birchmd birchmd mentioned this pull request Jun 5, 2021
Closed
3 tasks
artob added a commit that referenced this pull request Jun 5, 2021
@artob @joshuajbouw
@sept-en @birchmd
Release 1.2.0. (#132)
f3d3982 
* Remove the dependency on Lunarity. (#115)
* Fix Clippy complaint with +nightly. (#117)
* Add an `evm-bully=yes` build to CI. (#121)
* Fix evm-bully builds. (#130)
* Handle transaction gas limit properly. (#123)
* Add an `is_used_proof` interface. (#120)
* Simplify the `sdk::read_u64` return type. (#118)

Co-authored-by: Frank Braun <frank@near.org>
Co-authored-by: Joshua J. Bouw <dev@joshuajbouw.com>
Co-authored-by: Kirill Abramov <septengineering@pm.me>
Co-authored-by: Michael Birch <michael@near.org>
@birchmd birchmd deleted the 119-intrinsic-gas branch June 7, 2021 15:22
artob added a commit that referenced this pull request Jun 17, 2021
@artob @mrLSD
@joshuajbouw @sept-en
Release 1.3.0 (#143)
7d01e62 
* Introduce precompiles for the ETH & ERC-20 connectors. (#51)
* Implement generational storage with `SELFDESTRUCT` tests. (#84)
* Remove the dependency on Lunarity. (#115)
* Fix Clippy complaint with `+nightly`. (#117)
* Simplify the `sdk::read_u64` return type. (#118)
* Add an `is_used_proof` interface. (#120)
* Add an `evm-bully=yes` build to CI. (#121)
* Handle transaction gas limit properly. (#123)
* Fix u128 JSON parsing & tests in the ETH connector. (#125)
* Fix evm-bully builds. (#130)
* Add JSON custom error types. (#131)
* Don't burn NEP-141 on deposit. (#133)
* Fix needless borrows. (#135)
* Improve and refactor the ETH connector. (#136)
* Add a macro for logging. (#142)

Co-authored-by: Aleksey Kladov <aleksey@near.org>
Co-authored-by: Arto Bendiken <arto@aurora.dev>
Co-authored-by: Evgeny Ukhanov <evgeny@aurora.dev>
Co-authored-by: Frank Braun <frank@aurora.dev>
Co-authored-by: Joshua J. Bouw <joshua@aurora.dev>
Co-authored-by: Kirill <kirill@aurora.dev>
Co-authored-by: Marcelo Fornet <marcelo@aurora.dev>
Co-authored-by: Michael Birch <michael@aurora.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrLSD mrLSD Awaiting requested review from mrLSD

3 more reviewers

@artob artob artob approved these changes

@sept-en sept-en sept-en approved these changes

@joshuajbouw joshuajbouw joshuajbouw approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@artob artob

Labels

C-bug Category: Something isn't working. C-enhancement Category: New feature or request P-critical Priority: critical

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@birchmd @artob @sept-en @joshuajbouw