Skip to content

Exit precompiles: forbid static calling context. ERC-20: don't use static calls.#148

Merged
artob merged 2 commits intodevelopfrom
erc20-dont-use-static-calls
Jun 17, 2021
Merged

Exit precompiles: forbid static calling context. ERC-20: don't use static calls.#148
artob merged 2 commits intodevelopfrom
erc20-dont-use-static-calls

Conversation

@sept-en
Copy link
Copy Markdown
Contributor

@sept-en sept-en commented Jun 17, 2021

No description provided.

@sept-en sept-en added C-bug Category: Something isn't working. P-critical Priority: critical labels Jun 17, 2021
Copy link
Copy Markdown
Member

@birchmd birchmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch

@artob artob self-assigned this Jun 17, 2021
@artob artob merged commit 1215c02 into develop Jun 17, 2021
@artob artob deleted the erc20-dont-use-static-calls branch June 17, 2021 20:08
artob added a commit that referenced this pull request Jun 18, 2021
* Implement EIP-2565 support. (#138)
* Fix CI debug pipeline. (#145)
* Enable `meta_call` only with feature flag. (#146)
* Add `mainnet`, `testnet`, and `betanet` feature flags. (#147)
* Prohibit static calls in exit precompiles. (#148)
* Fix `clippy::unnecessary_unwrap`. (#149)
* Fix all Clippy warnings. (#150)
* Create the `ExitToNear` receiver account if it does not exist. (#151)

Co-authored-by: Joshua J. Bouw <joshua@aurora.dev>
Co-authored-by: Kirill <kirill@aurora.dev>
Co-authored-by: Marcelo Fornet <marcelo@aurora.dev>
Co-authored-by: Michael Birch <michael@aurora.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-bug Category: Something isn't working. P-critical Priority: critical

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants