[RELEASE] 2.4.0 #5643
Merged
[RELEASE] 2.4.0 #5643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Description <!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change. --> Closes #<issue_number> **Type of change** <!-- Please delete options that are not relevant. Remember to title the PR according to the type of change --> - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Refactor (change restructuring the codebase without changing functionality) - Improvement (change adding some improvement to an existing functionality) - Documentation update **How Has This Been Tested** <!-- Please add some reference about how your feature has been tested. --> **Checklist** <!-- Please go over the list and make sure you've taken everything into account --> - I added relevant documentation - I followed the style guidelines of this project - I did a self-review of my code - I made corresponding changes to the documentation - I confirm My changes generate no new warnings - I have added tests that prove my fix is effective or that my feature works - I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/) --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Paco Aranda <[email protected]>
# Description A small refactor moving validation logic for `publish_dataset` context function to `DatasetPublishValidator` class. Once we merge this PR then I can do changes to the validations so we can increase flexibility to import datasets from the Hub. I was bored of creating "helper functions" for counting queries for database so I have added `count_by` function into our database models mixin class. I hope it can be useful. **Type of change** - Refactor (change restructuring the codebase without changing functionality) **How Has This Been Tested** - [x] Running test suite. **Checklist** - I added relevant documentation - I followed the style guidelines of this project - I did a self-review of my code - I made corresponding changes to the documentation - I confirm My changes generate no new warnings - I have added tests that prove my fix is effective or that my feature works - I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)
#5556) …nisation # Description <!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change. --> User `CREATOR_USER_ID` with this API https://huggingface.co/api/users/davidberenstein1957/overview **Type of change** <!-- Please delete options that are not relevant. Remember to title the PR according to the type of change --> - Improvement (change adding some improvement to an existing functionality) **How Has This Been Tested** <!-- Please add some reference about how your feature has been tested. --> **Checklist** <!-- Please go over the list and make sure you've taken everything into account --> - I added relevant documentation - I followed the style guidelines of this project - I did a self-review of my code - I made corresponding changes to the documentation - I confirm My changes generate no new warnings - I have added tests that prove my fix is effective or that my feature works - I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/) --------- Co-authored-by: Paco Aranda <[email protected]>
…es (#5575) # Description <!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change. --> This PR removes name pattern validations for datasets, workspaces, and users. **Type of change** <!-- Please delete options that are not relevant. Remember to title the PR according to the type of change --> - Refactor (change restructuring the codebase without changing functionality) - Improvement (change adding some improvement to an existing functionality) **How Has This Been Tested** <!-- Please add some reference about how your feature has been tested. --> **Checklist** <!-- Please go over the list and make sure you've taken everything into account --> - I added relevant documentation - I followed the style guidelines of this project - I did a self-review of my code - I made corresponding changes to the documentation - I confirm My changes generate no new warnings - I have added tests that prove my fix is effective or that my feature works - I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)
# Description <!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change. --> The env var had a slightly different name `SPACE_CREATOR_USER_ID`: https://huggingface.co/docs/hub/en/spaces-overview#helper-environment-variables Closes NA **Type of change** <!-- Please delete options that are not relevant. Remember to title the PR according to the type of change --> - Bug fix (non-breaking change which fixes an issue) **How Has This Been Tested** <!-- Please add some reference about how your feature has been tested. --> **Checklist** <!-- Please go over the list and make sure you've taken everything into account --> - I added relevant documentation
This PR updates the conditional logic to ensure that the field text is not duplicated.
# Description <!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change. --> Also, relax type casting for metadata values, accepting Any. **Type of change** <!-- Please delete options that are not relevant. Remember to title the PR according to the type of change --> - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Refactor (change restructuring the codebase without changing functionality) - Improvement (change adding some improvement to an existing functionality) - Documentation update **How Has This Been Tested** <!-- Please add some reference about how your feature has been tested. --> **Checklist** <!-- Please go over the list and make sure you've taken everything into account --> - I added relevant documentation - I followed the style guidelines of this project - I did a self-review of my code - I made corresponding changes to the documentation - I confirm My changes generate no new warnings - I have added tests that prove my fix is effective or that my feature works - I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)
…ies (#5594) # Description <!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change. --> This PR adapts the SDK to support changes included in #5589. This allows to define terms metadata properties with other values than str (boolean, a set of integers,...) **Type of change** <!-- Please delete options that are not relevant. Remember to title the PR according to the type of change --> - Improvement (change adding some improvement to an existing functionality) - Documentation update **How Has This Been Tested** <!-- Please add some reference about how your feature has been tested. --> **Checklist** <!-- Please go over the list and make sure you've taken everything into account --> - I added relevant documentation - I followed the style guidelines of this project - I did a self-review of my code - I made corresponding changes to the documentation - I confirm My changes generate no new warnings - I have added tests that prove my fix is effective or that my feature works - I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)
# Description
<!-- Please include a summary of the changes and the related issue.
Please also include relevant motivation and context. List any
dependencies that are required for this change. -->
This PR fixes problem with record fields containing empty strings. The
default behavior of pydantic is to cast as dicts {} (I really don't know
why).
Also, a custom validator was needed to process chat field content
properly. Otherwise, values as `[{"role": "content"}]` are automatically
converted to `{"role": "content"}`
**Type of change**
<!-- Please delete options that are not relevant. Remember to title the
PR according to the type of change -->
- Bug fix (non-breaking change which fixes an issue)
**How Has This Been Tested**
<!-- Please add some reference about how your feature has been tested.
-->
**Checklist**
<!-- Please go over the list and make sure you've taken everything into
account -->
- I added relevant documentation
- I followed the style guidelines of this project
- I did a self-review of my code
- I made corresponding changes to the documentation
- I confirm My changes generate no new warnings
- I have added tests that prove my fix is effective or that my feature
works
- I have added relevant notes to the CHANGELOG.md file (See
https://keepachangelog.com/)
# Description minor fix **Type of change** <!-- Please delete options that are not relevant. Remember to title the PR according to the type of change --> - Refactor (change restructuring the codebase without changing functionality)
… hub (#5547) # Description <!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change. --> Closes #5108 - sets USERNAME to `hf_token["username"]` - sets no PASSWORD and delegates this to the quickstart image - sets no WORKSPACE to `argilla` - sets API_KEY needs to be provided manually - sets`org_name` to `hf_token["username"]` - sets`repo_name` to `"argilla"` - default spaces and hardware, i.e. cpu basic and no persistant storage - if private, sets the correct connection headers. ```python import argilla as rg client = rg.Argilla.deploy_on_spaces(api_key="12345678") ``` ```python import argilla as rg client = rg.Argilla.deploy_on_spaces( repo_name="my-example", org_name=None, token=None, space_storage=None, space_hardware=None, private=False, ) ```  **Type of change** <!-- Please delete options that are not relevant. Remember to title the PR according to the type of change --> - New feature (non-breaking change which adds functionality) **How Has This Been Tested** <!-- Please add some reference about how your feature has been tested. --> **Checklist** <!-- Please go over the list and make sure you've taken everything into account --> - I added relevant documentation - I followed the style guidelines of this project - I did a self-review of my code - I made corresponding changes to the documentation - I confirm My changes generate no new warnings - I have added tests that prove my fix is effective or that my feature works - I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/) --------- Co-authored-by: Paco Aranda <[email protected]>
# Description
<!-- Please include a summary of the changes and the related issue.
Please also include relevant motivation and context. List any
dependencies that are required for this change. -->
Closes NA
```python
import argilla as rg
client = rg.Argilla.deploy_on_spaces(api_key="12345678")
```
```python
import argilla as rg
client = rg.Argilla.deploy_on_spaces(
repo_name="my-example",
org_name=None,
token=None,
space_storage=None,
space_hardware=None,
private=False,
)
```
**Type of change**
<!-- Please delete options that are not relevant. Remember to title the
PR according to the type of change -->
- Documentation update
**How Has This Been Tested**
<!-- Please add some reference about how your feature has been tested.
-->
**Checklist**
<!-- Please go over the list and make sure you've taken everything into
account -->
- I added relevant documentation
- I followed the style guidelines of this project
- I did a self-review of my code
- I made corresponding changes to the documentation
- I confirm My changes generate no new warnings
- I have added tests that prove my fix is effective or that my feature
works
- I have added relevant notes to the CHANGELOG.md file (See
https://keepachangelog.com/)
---------
Co-authored-by: Paco Aranda <[email protected]>
# Description <!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change. --> This PR moves all the record relationship validations (suggestions, responses, and vectors) inside the record validator. This helps centralize the validations and prevents objects from flushing into the DB early. **Type of change** <!-- Please delete options that are not relevant. Remember to title the PR according to the type of change --> - Refactor (change restructuring the codebase without changing functionality) **How Has This Been Tested** <!-- Please add some reference about how your feature has been tested. --> **Checklist** <!-- Please go over the list and make sure you've taken everything into account --> - I added relevant documentation - I followed the style guidelines of this project - I did a self-review of my code - I made corresponding changes to the documentation - I confirm My changes generate no new warnings - I have added tests that prove my fix is effective or that my feature works - I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)
) # Description <!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change. --> Changes introduced in #5600 include a but when the fields in the `RecordCreate` schema already contain `ChatFieldValue` object. This is the cause of [failing integration tests in the develop branch](https://github.com/argilla-io/argilla/actions/runs/11380531039/job/31660006108). The custom validator must skip these objects even if the `pre` flag is set to True. This PR fixes the error. **Type of change** <!-- Please delete options that are not relevant. Remember to title the PR according to the type of change --> - Bug fix (non-breaking change which fixes an issue) **How Has This Been Tested** <!-- Please add some reference about how your feature has been tested. --> **Checklist** <!-- Please go over the list and make sure you've taken everything into account --> - I added relevant documentation - I followed the style guidelines of this project - I did a self-review of my code - I made corresponding changes to the documentation - I confirm My changes generate no new warnings - I have added tests that prove my fix is effective or that my feature works - I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)
Hello team, I'm the maintainer of [Anteon](https://github.com/getanteon/anteon). We have created Gurubase.io with the mission of building a centralized, open-source tool-focused knowledge base. Essentially, each "guru" is equipped with custom knowledge to answer user questions based on collected data related to that tool. I wanted to update you that I've manually added the [Argilla Guru](https://gurubase.io/g/argilla) to Gurubase. Argilla Guru uses the data from this repo and data from the [docs](https://docs.argilla.io/latest/) to answer questions by leveraging the LLM. In this PR, I showcased the "Argilla Guru" badge, which highlights that Argilla now has an AI assistant available to help users with their questions. Please let me know your thoughts on this contribution. Additionally, if you want me to disable Argilla Guru in Gurubase, just let me know that's totally fine.
…rogress and metrics (#5618) # Description <!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change. --> Computing dataset progress and metrics using the search engine drastically reduces the time required to run the Argilla server in HF spaces when persistent storage is enabled. ## TODO - [x] Add search engine tests - [x] Adapt existing test to mock engine results **Type of change** <!-- Please delete options that are not relevant. Remember to title the PR according to the type of change --> - Refactor (change restructuring the codebase without changing functionality) - Improvement (change adding some improvement to an existing functionality) **How Has This Been Tested** <!-- Please add some reference about how your feature has been tested. --> **Checklist** <!-- Please go over the list and make sure you've taken everything into account --> - I added relevant documentation - I followed the style guidelines of this project - I did a self-review of my code - I made corresponding changes to the documentation - I confirm My changes generate no new warnings - I have added tests that prove my fix is effective or that my feature works - I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)
# Description <!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change. --> - Remove unnecessary extra SAVEPOINTS - Move out of the commit all search index operations - ~~the refresh parameter for es can be set to `wait_for` instead of `true` since index operations are out of transactions. This will help with the es performance.~~ **Type of change** <!-- Please delete options that are not relevant. Remember to title the PR according to the type of change --> - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Refactor (change restructuring the codebase without changing functionality) - Improvement (change adding some improvement to an existing functionality) - Documentation update **How Has This Been Tested** <!-- Please add some reference about how your feature has been tested. --> **Checklist** <!-- Please go over the list and make sure you've taken everything into account --> - I added relevant documentation - I followed the style guidelines of this project - I did a self-review of my code - I made corresponding changes to the documentation - I confirm My changes generate no new warnings - I have added tests that prove my fix is effective or that my feature works - I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)
# Description <!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change. --> Dataset progress and user metrics are not available for draft datasets. **Type of change** <!-- Please delete options that are not relevant. Remember to title the PR according to the type of change --> - Bug fix (non-breaking change which fixes an issue) **How Has This Been Tested** <!-- Please add some reference about how your feature has been tested. --> **Checklist** <!-- Please go over the list and make sure you've taken everything into account --> - I added relevant documentation - I followed the style guidelines of this project - I did a self-review of my code - I made corresponding changes to the documentation - I confirm My changes generate no new warnings - I have added tests that prove my fix is effective or that my feature works - I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)
# Refine German translations and update non-localized UI elements
- Corrected & added a few German translation in
argilla-frontend/translation/de.js
- Added a language aware placeholder to Label selection
(LabelSelection.component.vue & EntityLabelSelection.component.vue)
- $t('spanAnnotation.searchLabels') for filtering Labels in the span
Annotation
- The relatives dates in the created & updated field in the Dataset
Overview page where hardcoded to English
- BaseDate.vue -> timeAgo uses now `this.$i18n.locale`
- The argilla-frontend/docs/snippets/start_page.md sample code names the
default workspace `argilla` even though the server defaults to the
default workspace name `default` so I changed it.
- Set lang in app.vue dynamic to the actual language (important for the
screenreader)
**Type of change**
<!-- Please delete options that are not relevant. Remember to title the
PR according to the type of change -->
- Improvement (change adding some improvement to an existing
functionality)
**How Has This Been Tested**
Local front-end build.
**Checklist**
<!-- Please go over the list and make sure you've taken everything into
account -->
- I added relevant documentation
- I followed the style guidelines of this project
- I did a self-review of my code
- I made corresponding changes to the documentation
- I confirm My changes generate no new warnings
- I have added tests that prove my fix is effective or that my feature
works
- I have added relevant notes to the CHANGELOG.md file (See
https://keepachangelog.com/)
---------
Co-authored-by: Paul Bauriegel <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
# Description
<!-- Please include a summary of the changes and the related issue.
Please also include relevant motivation and context. List any
dependencies that are required for this change. -->
This PR fixes this snippet:
```python
import argilla as rg
from datasets import load_dataset
client = rg.Argilla(
api_url="https://frascuchon-argilla.hf.space", api_key="argilla.apikey"
)
ds = load_dataset("derek-thomas/ScienceQA", name="default", split="train")
dataset = client.datasets(name="science_qa", workspace="argilla")
dataset.records.log(
ds, mapping={"task": "text_0.suggestion", "subject": "text_1.suggestion"}
)
```
Closes #<issue_number>
**Type of change**
<!-- Please delete options that are not relevant. Remember to title the
PR according to the type of change -->
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- Refactor (change restructuring the codebase without changing
functionality)
- Improvement (change adding some improvement to an existing
functionality)
- Documentation update
**How Has This Been Tested**
<!-- Please add some reference about how your feature has been tested.
-->
**Checklist**
<!-- Please go over the list and make sure you've taken everything into
account -->
- I added relevant documentation
- I followed the style guidelines of this project
- I did a self-review of my code
- I made corresponding changes to the documentation
- I confirm My changes generate no new warnings
- I have added tests that prove my fix is effective or that my feature
works
- I have added relevant notes to the CHANGELOG.md file (See
https://keepachangelog.com/)
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Francisco Aranda <[email protected]>
# Description <!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change. --> Closes #5636 **Type of change** <!-- Please delete options that are not relevant. Remember to title the PR according to the type of change --> - Improvement (change adding some improvement to an existing functionality) **How Has This Been Tested** <!-- Please add some reference about how your feature has been tested. --> Passed `with_vectors` parameter to the search method while retrieving records and I could see the vectors in the response now. - I added relevant documentation - I followed the style guidelines of this project - I did a self-review of my code - I made corresponding changes to the documentation - I confirm My changes generate no new warnings - I have added tests that prove my fix is effective or that my feature works - I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/) --------- Co-authored-by: bharath <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…user metrics (#5641) # Description <!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change. --> Using search engine total instead of DB count to get the total number of records. This improves the performance when running the Argilla server on an HF space with persistent storage enabled. **Type of change** <!-- Please delete options that are not relevant. Remember to title the PR according to the type of change --> - Improvement (change adding some improvement to an existing functionality) **How Has This Been Tested** <!-- Please add some reference about how your feature has been tested. --> **Checklist** <!-- Please go over the list and make sure you've taken everything into account --> - I added relevant documentation - I followed the style guidelines of this project - I did a self-review of my code - I made corresponding changes to the documentation - I confirm My changes generate no new warnings - I have added tests that prove my fix is effective or that my feature works - I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)
…Cs (#5628) # Description I updated the Helm chart to allow the use of a default storage class when none is explicitly specified. This change is important because some Kubernetes environments, like k3d, do not have a 'standard' storage class by default. Without this change, the setup could fail in such environments, as Kubernetes would attempt to use an undefined or missing storage class. By not explicitly setting a storage class, I allow Kubernetes to default to whatever storage class is configured for the cluster. This ensures the chart works across various setups, including those that don't predefine a 'standard' storage class. **Type of change** - Improvement (change adding some improvement to an existing functionality) **How Has This Been Tested** Tested on a MacBook Pro M3 Max with k3d (v5.7.4) and Minikube (v1.34.0). **Checklist**: I added relevant documentation I followed the style guidelines of this project I did a self-review of my code I made corresponding changes to the documentation I confirm My changes generate no new warnings I have added tests that prove my fix is effective or that my feature works I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)
# Improve Accessibility for Screenreaders - Description & some structure
via Aria-Attributes
We are currently in the internal review in Deutsche Telekom how to
enable people with disabilities for our annotation process. One key-part
will be better usability with screen-readers. This PR tries to enable
basic functionality via aria attributes.
I tried to not touch the current HTML structure too much, but it might
make sense to change some of the aria-role="button" to actual html
button.
This would be the first of a couple of PR that we are proposing. In
future PR we would also want to add a MR for a high contrast mode, and
some optimizations for keyboard navigation for blind people.
Scope of this one: Description & some structure via Aria-Attributes.
- For a lot of icons in buttons: I added aria-hidden="true" as there are
not relevant for the screenreader
- The buttons and many other UI elements got a screenreader description
via aria-label
- For some items I added a aria-role such as role="button" or
role="table"
- There are some additional aria attributes such as:
- aria-expanded for collapse panel & drop-down menues
- or aria-multiselectable for multi-select labels
Next steps - one at a time:
- Aria Labels are not multi-lingual yet.
- It does not fix the tabindex order or general problems with keyboard
navigation for blind people.
- high contrast mode fixes
- Skip links for Screenreaders
- Alt Text for Image Field
We will most likely receive more feedback in our internal review process
that we will also try to integrate then.
**Type of change**
- New feature (non-breaking change which adds functionality)
**How Has This Been Tested**
Local Frontend Build w. Firefox tested w. VoiceOver
**Checklist**
- I added relevant documentation
- I followed the style guidelines of this project
- I did a self-review of my code
- I made corresponding changes to the documentation
- I confirm My changes generate no new warnings
- I have added tests that prove my fix is effective or that my feature
works
- I have added relevant notes to the CHANGELOG.md file (See
https://keepachangelog.com/)
---------
Co-authored-by: Paul Bauriegel <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Leire <[email protected]>
# Description Changes to support importing datasets from HF Hub. Refs argilla-io/roadmap#21 **Type of change** - New feature (non-breaking change which adds functionality) **How Has This Been Tested** - [x] Modifying test suite. **Checklist** - I added relevant documentation - I followed the style guidelines of this project - I did a self-review of my code - I made corresponding changes to the documentation - I confirm My changes generate no new warnings - I have added tests that prove my fix is effective or that my feature works - I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/) --------- Co-authored-by: Paco Aranda <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Francisco Aranda <[email protected]> Co-authored-by: burtenshaw <[email protected]> Co-authored-by: Natalia Elvira <[email protected]> Co-authored-by: Damián Pumar <[email protected]> Co-authored-by: Leire Aguirre <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5643 +/- ##
==========================================
- Coverage 91.40% 91.24% -0.16%
==========================================
Files 145 150 +5
Lines 6025 6250 +225
==========================================
+ Hits 5507 5703 +196
- Misses 518 547 +29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…5644) # Description Following the discussion at https://discord.com/channels/879548962464493619/1300627522135916604 we have removed unnecessary exposed ports at our Docker compose file, increasing the security. **Type of change** - Improvement (change adding some improvement to an existing functionality) **How Has This Been Tested** - [x] Running docker compose manually. **Checklist** - I added relevant documentation - I followed the style guidelines of this project - I did a self-review of my code - I made corresponding changes to the documentation - I confirm My changes generate no new warnings - I have added tests that prove my fix is effective or that my feature works - I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)
# Description <!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change. --> This change will allow at least to run the frontend build pipeline. Currently, we have no permissions to deploy on gcp from GitHub actions, so the PR preview is not available. cc @leiyre @damianpumar @Amelie-V @nataliaElv **Type of change** <!-- Please delete options that are not relevant. Remember to title the PR according to the type of change --> **How Has This Been Tested** <!-- Please add some reference about how your feature has been tested. --> **Checklist** <!-- Please go over the list and make sure you've taken everything into account --> - I added relevant documentation - I followed the style guidelines of this project - I did a self-review of my code - I made corresponding changes to the documentation - I confirm My changes generate no new warnings - I have added tests that prove my fix is effective or that my feature works - I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)
# Description <!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change. --> Closes #<issue_number> **Type of change** <!-- Please delete options that are not relevant. Remember to title the PR according to the type of change --> - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Refactor (change restructuring the codebase without changing functionality) - Improvement (change adding some improvement to an existing functionality) - Documentation update **How Has This Been Tested** <!-- Please add some reference about how your feature has been tested. --> **Checklist** <!-- Please go over the list and make sure you've taken everything into account --> - I added relevant documentation - I followed the style guidelines of this project - I did a self-review of my code - I made corresponding changes to the documentation - I confirm My changes generate no new warnings - I have added tests that prove my fix is effective or that my feature works - I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)
|
The URL of the deployed environment for this PR is https://argilla-quickstart-pr-5643-ki24f765kq-no.a.run.app |
# Description Adding some updates for our `CHANGELOG.md` for release `2.4.0` **Type of change** - Documentation update **How Has This Been Tested** - [x] Rendering markdowns 😄 **Checklist** - I added relevant documentation - I followed the style guidelines of this project - I did a self-review of my code - I made corresponding changes to the documentation - I confirm My changes generate no new warnings - I have added tests that prove my fix is effective or that my feature works - I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/) --------- Co-authored-by: Paco Aranda <[email protected]> Co-authored-by: Francisco Aranda <[email protected]>
jfcalvo
reviewed
Oct 30, 2024
jfcalvo
reviewed
Oct 30, 2024
argilla-server/src/argilla_server/api/handlers/v1/datasets/datasets.py
Outdated
Show resolved
Hide resolved
…file (#5651) # Description Small improvement moving the install of some dependencies before cleaning up. **Type of change** - Improvement (change adding some improvement to an existing functionality) **How Has This Been Tested** - [ ] Deploying it to a new HF space. **Checklist** - I added relevant documentation - I followed the style guidelines of this project - I did a self-review of my code - I made corresponding changes to the documentation - I confirm My changes generate no new warnings - I have added tests that prove my fix is effective or that my feature works - I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)
…not available (#5654) # Description This should fix errors raised by our pre-commit actions when trying to run `helm lint` and the `helm` command is not available. I have tried to add `helm` as additional dependency for the `helmlint` hook but is not possible so disabling it by now on CI. It is available when running it locally and you have `helm` installed. **Type of change** - Improvement (change adding some improvement to an existing functionality) **How Has This Been Tested** - [ ] GitHub Actions with pre-commit should now work as expected without errors. **Checklist** - I added relevant documentation - I followed the style guidelines of this project - I did a self-review of my code - I made corresponding changes to the documentation - I confirm My changes generate no new warnings - I have added tests that prove my fix is effective or that my feature works - I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)
# Description <!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change. --> Closes #<issue_number> **Type of change** <!-- Please delete options that are not relevant. Remember to title the PR according to the type of change --> - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Refactor (change restructuring the codebase without changing functionality) - Improvement (change adding some improvement to an existing functionality) - Documentation update **How Has This Been Tested** <!-- Please add some reference about how your feature has been tested. --> **Checklist** <!-- Please go over the list and make sure you've taken everything into account --> - I added relevant documentation - I followed the style guidelines of this project - I did a self-review of my code - I made corresponding changes to the documentation - I confirm My changes generate no new warnings - I have added tests that prove my fix is effective or that my feature works - I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/) --------- Co-authored-by: Leire Aguirre <[email protected]> Co-authored-by: José Francisco Calvo <[email protected]> Co-authored-by: José Francisco Calvo <[email protected]> Co-authored-by: Paco Aranda <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Damián Pumar <[email protected]> Co-authored-by: Francisco Aranda <[email protected]> Co-authored-by: burtenshaw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
How Has This Been Tested
Checklist