-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature - Improve Accessibility for Screenreaders #5634
Merged
leiyre
merged 11 commits into
argilla-io:develop
from
paulbauriegel:feature/aria-improvements
Oct 29, 2024
Merged
Feature - Improve Accessibility for Screenreaders #5634
leiyre
merged 11 commits into
argilla-io:develop
from
paulbauriegel:feature/aria-improvements
Oct 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Hi @paulbauriegel, this is great and the proposed future MRs sound awesome. |
@leiyre It's ready to be reviewed from my side. Let me know what you think. |
Hi @paulbauriegel, It looks great to me. I will review the HTML and change some tags in other PR. Thank you for this contribution |
leiyre
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve Accessibility for Screenreaders - Description & some structure via Aria-Attributes
We are currently in the internal review in Deutsche Telekom how to enable people with disabilities for our annotation process. One key-part will be better usability with screen-readers. This PR tries to enable basic functionality via aria attributes.
I tried to not touch the current HTML structure too much, but it might make sense to change some of the aria-role="button" to actual html button.
This would be the first of a couple of PR that we are proposing. In future PR we would also want to add a MR for a high contrast mode, and some optimizations for keyboard navigation for blind people.
Scope of this one: Description & some structure via Aria-Attributes.
Next steps - one at a time:
We will most likely receive more feedback in our internal review process that we will also try to integrate then.
Type of change
How Has This Been Tested
Local Frontend Build w. Firefox tested w. VoiceOver
Checklist