New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unnecesary exposed ports for Argilla Docker compose file #5644

Merged

jfcalvo merged 1 commit into releases/2.4.0 from fix/remove-unnecessary-exposed-ports-at-docker-compose

Oct 29, 2024

Member

jfcalvo commented Oct 29, 2024

Description

Following the discussion at https://discord.com/channels/879548962464493619/1300627522135916604 we have removed unnecessary exposed ports at our Docker compose file, increasing the security.

Type of change

Improvement (change adding some improvement to an existing functionality)

How Has This Been Tested

Running docker compose manually.

Checklist

I added relevant documentation
I followed the style guidelines of this project
I did a self-review of my code
I made corresponding changes to the documentation
I confirm My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)


          fix: remove unnecesary exposed ports for Argilla Docker compose file

bc309a8

jfcalvo requested a review from frascuchon

October 29, 2024 10:01

jfcalvo changed the base branch from develop to releases/2.4.0

October 29, 2024 10:26

frascuchon approved these changes

View reviewed changes

jfcalvo merged commit 1932210 into releases/2.4.0

1 check failed

jfcalvo deleted the fix/remove-unnecessary-exposed-ports-at-docker-compose branch

October 29, 2024 10:28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet