[BUGFIX] argilla server: parse fields for record schemas #5600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Define strict str as first option - Specific chat field validator
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5600 +/- ##
========================================
Coverage 91.22% 91.23%
========================================
Files 145 145
Lines 6030 6036 +6
========================================
+ Hits 5501 5507 +6
Misses 529 529
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jfcalvo
approved these changes
Oct 16, 2024
frascuchon
deleted the
bugfix/argilla-server/parse-fields-for-record-schemas
branch
frascuchon
added a commit
that referenced
this pull request
Oct 17, 2024
) # Description <!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change. --> Changes introduced in #5600 include a but when the fields in the `RecordCreate` schema already contain `ChatFieldValue` object. This is the cause of [failing integration tests in the develop branch](https://github.com/argilla-io/argilla/actions/runs/11380531039/job/31660006108). The custom validator must skip these objects even if the `pre` flag is set to True. This PR fixes the error. **Type of change** <!-- Please delete options that are not relevant. Remember to title the PR according to the type of change --> - Bug fix (non-breaking change which fixes an issue) **How Has This Been Tested** <!-- Please add some reference about how your feature has been tested. --> **Checklist** <!-- Please go over the list and make sure you've taken everything into account --> - I added relevant documentation - I followed the style guidelines of this project - I did a self-review of my code - I made corresponding changes to the documentation - I confirm My changes generate no new warnings - I have added tests that prove my fix is effective or that my feature works - I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes problem with record fields containing empty strings. The default behavior of pydantic is to cast as dicts {} (I really don't know why).
Also, a custom validator was needed to process chat field content properly. Otherwise, values as
[{"role": "content"}]are automatically converted to{"role": "content"}Type of change
How Has This Been Tested
Checklist