Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine German translations and update non-localized UI elements #5632

Merged
merged 10 commits into from
Oct 28, 2024

Conversation

paulbauriegel
Copy link
Contributor

@paulbauriegel paulbauriegel commented Oct 26, 2024

Refine German translations and update non-localized UI elements

  • Corrected & added a few German translation in argilla-frontend/translation/de.js
  • Added a language aware placeholder to Label selection (LabelSelection.component.vue & EntityLabelSelection.component.vue)
    • $t('spanAnnotation.searchLabels') for filtering Labels in the span Annotation
  • The relatives dates in the created & updated field in the Dataset Overview page where hardcoded to English
    • BaseDate.vue -> timeAgo uses now this.$i18n.locale
  • The argilla-frontend/docs/snippets/start_page.md sample code names the default workspace argilla even though the server defaults to the default workspace name default so I changed it.
  • Set lang in app.vue dynamic to the actual language (important for the screenreader)

Type of change

  • Improvement (change adding some improvement to an existing functionality)

How Has This Been Tested
Local front-end build.

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@leiyre
Copy link
Member

leiyre commented Oct 28, 2024

Thanks a lot, @paulbauriegel!!

@leiyre leiyre merged commit b02eba8 into argilla-io:develop Oct 28, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants