-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PERF] argilla server: Reduce general transaction time #5609
Merged
frascuchon
merged 13 commits into
develop
from
perf/argilla-server/reduce-transaction-time
Oct 23, 2024
Merged
[PERF] argilla server: Reduce general transaction time #5609
frascuchon
merged 13 commits into
develop
from
perf/argilla-server/reduce-transaction-time
Oct 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frascuchon
commented
Oct 17, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5609 +/- ##
===========================================
+ Coverage 91.21% 91.24% +0.03%
===========================================
Files 145 145
Lines 6065 6032 -33
===========================================
- Hits 5532 5504 -28
+ Misses 533 528 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
frascuchon
commented
Oct 17, 2024
frascuchon
changed the title
[DRAFT][PERF] argilla server: Reduce general transaction time
[PERF] argilla server: Reduce general transaction time
Oct 18, 2024
jfcalvo
requested changes
Oct 18, 2024
argilla-server/src/argilla_server/search_engine/elasticsearch.py
Outdated
Show resolved
Hide resolved
frascuchon
force-pushed
the
perf/argilla-server/reduce-transaction-time
branch
from
October 21, 2024 12:05
3a226d3
to
c34ebd9
Compare
jfcalvo
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
the refresh parameter for es can be set towait_for
instead oftrue
since index operations are out of transactions. This will help with the es performance.Type of change
How Has This Been Tested
Checklist