Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PERF] argilla server: Reduce general transaction time #5609

Merged
merged 13 commits into from
Oct 23, 2024

Conversation

frascuchon
Copy link
Member

@frascuchon frascuchon commented Oct 17, 2024

Description

  • Remove unnecessary extra SAVEPOINTS
  • Move out of the commit all search index operations
  • the refresh parameter for es can be set to wait_for instead of true since index operations are out of transactions. This will help with the es performance.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (change restructuring the codebase without changing functionality)
  • Improvement (change adding some improvement to an existing functionality)
  • Documentation update

How Has This Been Tested

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 91.46341% with 7 lines in your changes missing coverage. Please review.

Project coverage is 91.24%. Comparing base (66454e8) to head (dc7cb1a).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...lla-server/src/argilla_server/contexts/accounts.py 42.85% 4 Missing ⚠️
...ver/src/argilla_server/search_engine/opensearch.py 0.00% 2 Missing ⚠️
.../src/argilla_server/search_engine/elasticsearch.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5609      +/-   ##
===========================================
+ Coverage    91.21%   91.24%   +0.03%     
===========================================
  Files          145      145              
  Lines         6065     6032      -33     
===========================================
- Hits          5532     5504      -28     
+ Misses         533      528       -5     
Flag Coverage Δ
argilla-server 91.24% <91.46%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frascuchon frascuchon changed the title [DRAFT][PERF] argilla server: Reduce general transaction time [PERF] argilla server: Reduce general transaction time Oct 18, 2024
@frascuchon frascuchon requested a review from jfcalvo October 18, 2024 09:38
@frascuchon frascuchon requested a review from jfcalvo October 19, 2024 21:30
@frascuchon frascuchon force-pushed the perf/argilla-server/reduce-transaction-time branch from 3a226d3 to c34ebd9 Compare October 21, 2024 12:05
@frascuchon frascuchon merged commit b9dac8d into develop Oct 23, 2024
5 of 6 checks passed
@frascuchon frascuchon deleted the perf/argilla-server/reduce-transaction-time branch October 23, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants