Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip helmlint pre-commit hook on CI because helm command is not available #5654

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

jfcalvo
Copy link
Member

@jfcalvo jfcalvo commented Oct 30, 2024

Description

This should fix errors raised by our pre-commit actions when trying to run helm lint and the helm command is not available.

I have tried to add helm as additional dependency for the helmlint hook but is not possible so disabling it by now on CI. It is available when running it locally and you have helm installed.

Type of change

  • Improvement (change adding some improvement to an existing functionality)

How Has This Been Tested

  • GitHub Actions with pre-commit should now work as expected without errors.

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@jfcalvo jfcalvo merged commit 2247283 into releases/2.4.0 Oct 30, 2024
2 checks passed
@jfcalvo jfcalvo deleted the fix/dont-use-pre-commit-helmlint-on-ci branch October 30, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants