Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added support for with_vectors with query filter in sdk #5638

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

bharath97-git
Copy link
Contributor

Description

Closes #5636

Type of change

  • Improvement (change adding some improvement to an existing functionality)

How Has This Been Tested

Passed with_vectors parameter to the search method while retrieving records and I could see the vectors in the response now.

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

Copy link
Member

@frascuchon frascuchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bharath97-git !!

@frascuchon frascuchon merged commit 432f557 into argilla-io:develop Oct 28, 2024
6 of 7 checks passed
@bharath97-git bharath97-git deleted the fix-with-vectors branch October 29, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG-python/deployment] Unable to retrieve records along with the filter query
3 participants