-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 5108 feature add method to deploy on spaces through huggingface hub #5547
feat: 5108 feature add method to deploy on spaces through huggingface hub #5547
Conversation
secrets = [ | ||
{"key": "API_KEY", "value": api_key, "description": "The API key of the owner user."}, | ||
{"key": "USERNAME", "value": token_username, "description": "The username of the owner user."}, | ||
{"key": "PASSWORD", "value": api_key, "description": "The password of the owner user."}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@frascuchon WDYT of using the api_key as password? I think it would make it easier to simplify the flow given that we support OAuth. An alternative would be just creating a random uuid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the api_key==password is ok. The hf_key vs api_key is already complex enough for some users.
secrets = [ | ||
{"key": "API_KEY", "value": api_key, "description": "The API key of the owner user."}, | ||
{"key": "USERNAME", "value": token_username, "description": "The username of the owner user."}, | ||
{"key": "PASSWORD", "value": api_key, "description": "The password of the owner user."}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the api_key==password is ok. The hf_key vs api_key is already complex enough for some users.
Description
Closes #5108
hf_token["username"]
argilla
org_name
tohf_token["username"]
repo_name
to"argilla"
Type of change
How Has This Been Tested
Checklist