Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: small improvement installing dependencies for HF Spaces Dockerfile #5651

Merged

Conversation

jfcalvo
Copy link
Member

@jfcalvo jfcalvo commented Oct 30, 2024

Description

Small improvement moving the install of some dependencies before cleaning up.

Type of change

  • Improvement (change adding some improvement to an existing functionality)

How Has This Been Tested

  • Deploying it to a new HF space.

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@jfcalvo jfcalvo requested a review from frascuchon October 30, 2024 09:58
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.23%. Comparing base (3f99cdb) to head (e06e079).
Report is 2 commits behind head on releases/2.4.0.

Additional details and impacted files
@@                Coverage Diff                 @@
##           releases/2.4.0    #5651      +/-   ##
==================================================
- Coverage           91.24%   91.23%   -0.02%     
==================================================
  Files                 150      150              
  Lines                6250     6250              
==================================================
- Hits                 5703     5702       -1     
- Misses                547      548       +1     
Flag Coverage Δ
argilla-server 91.23% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jfcalvo jfcalvo merged commit ce9716a into releases/2.4.0 Oct 30, 2024
5 of 6 checks passed
@jfcalvo jfcalvo deleted the chore/small-improvement-on-spaces-dockerfile branch October 30, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants