Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PERF][IMPROVEMENT] argilla server: improve computation for dataset progress and metrics #5618

Conversation

frascuchon
Copy link
Member

@frascuchon frascuchon commented Oct 21, 2024

Description

Computing dataset progress and metrics using the search engine drastically reduces the time required to run the Argilla server in HF spaces when persistent storage is enabled.

TODO

  • Add search engine tests
  • Adapt existing test to mock engine results

Type of change

  • Refactor (change restructuring the codebase without changing functionality)
  • Improvement (change adding some improvement to an existing functionality)

How Has This Been Tested

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.21%. Comparing base (eb6741e) to head (79a578c).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...la-server/src/argilla_server/search_engine/base.py 77.77% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5618      +/-   ##
===========================================
- Coverage    91.22%   91.21%   -0.02%     
===========================================
  Files          145      145              
  Lines         6051     6065      +14     
===========================================
+ Hits          5520     5532      +12     
- Misses         531      533       +2     
Flag Coverage Δ
argilla-server 91.21% <95.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frascuchon frascuchon changed the title [DRAFT] [IMPROVEMENT] argilla server: improve computation for dataset progress and metrics [IMPROVEMENT] argilla server: improve computation for dataset progress and metrics Oct 22, 2024
@frascuchon frascuchon requested a review from jfcalvo October 22, 2024 07:50
@frascuchon frascuchon changed the base branch from feat/argilla-direct-feature-branch to develop October 22, 2024 08:37
@frascuchon frascuchon changed the base branch from develop to feat/argilla-direct-feature-branch October 22, 2024 08:37
@frascuchon frascuchon force-pushed the perf/argilla-server/improve-computation-for-dataset-progress-and-metrics branch from 41f2a1e to 71f0c99 Compare October 22, 2024 08:55
@frascuchon frascuchon changed the base branch from feat/argilla-direct-feature-branch to develop October 22, 2024 08:55
@frascuchon frascuchon changed the title [IMPROVEMENT] argilla server: improve computation for dataset progress and metrics [PERF][IMPROVEMENT] argilla server: improve computation for dataset progress and metrics Oct 22, 2024
@frascuchon frascuchon merged commit 66454e8 into develop Oct 23, 2024
5 of 6 checks passed
@frascuchon frascuchon deleted the perf/argilla-server/improve-computation-for-dataset-progress-and-metrics branch October 23, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants