Skip to content

Update UFS weather-model to 20250328 hash #3528

Merged
KateFriedman-NOAA merged 111 commits into
NOAA-EMC:developfrom
JessicaMeixner-NOAA:updateWW320250327
Apr 11, 2025
Merged

Update UFS weather-model to 20250328 hash #3528
KateFriedman-NOAA merged 111 commits into
NOAA-EMC:developfrom
JessicaMeixner-NOAA:updateWW320250327

Conversation

@JessicaMeixner-NOAA
Copy link
Copy Markdown
Contributor

@JessicaMeixner-NOAA JessicaMeixner-NOAA commented Mar 28, 2025

Description

Updates UFS weather model to hash from 20250328.
The last hash update of ufs requires wave point updates. The point job optimization brings the v16 point optimization by @AliS-Noaa and @dkokron to the develop branch.

Closes #3422
Closes #3365
Closes #3157
Refs #3226

Co-author @WenMeng-NOAA who provided updates for #3365 and @AliS-Noaa point optimization updates.

This PR combines the updates from @AliS-Noaa PR #3450

Notes on ufs-weather-model updates:

Commit date Commit hash/ PR Notes for g-w changes Baseline Changes
Feb 10, 2025 ufs-community/ufs-weather-model@d57779f n/a baseline changes in outgoing lw for history and coupling and Icepack related to ponds
Feb 12, 2025 ufs-community/ufs-weather-model@38da98c n/a no baseline change
Feb 14, 2025 ufs-community/ufs-weather-model@443df8e n/a no change to global
Feb 19, 2025 ufs-community/ufs-weather-model@8933749 n/a changes answers for updates with saSAS see ufs-community/ufs-weather-model#2597
Feb 24, 2025 ufs-community/ufs-weather-model@ad1c0d2 n/a Wave model update that changed answers ufs-community/ufs-weather-model#2550
Feb 27, 2025 ufs-community/ufs-weather-model@6cb9e1d n/a baselines changed
Mar 6, 2025 ufs-community/ufs-weather-model@9c754c7 n/a bug fix - answer changes
Mar 10, 2025 ufs-community/ufs-weather-model@9dc31e4 n/a no baseline change
Mar 11, 2025 ufs-community/ufs-weather-model@5304e09 UPP related updates baselines changed for gefs tests
Mar 13, 2025 ufs-community/ufs-weather-model@306e253 n/a no global model baseline change
Mar 20, 2025 ufs-community/ufs-weather-model@3113a5f New ICs for Waves needed no answer change, but requires new ICs
Mar 24, 2025 ufs-community/ufs-weather-model@a8c1628 n/a no global baseline change
Mar 26, 2025 ufs-community/ufs-weather-model@f7d8b0c new cmake variable UFS_COMPILER_SUITE (runs without any updates, but future updates might be needed) no baseline change
Mar 27, 2025 ufs-community/ufs-weather-model@c5f801e n/a no baseline change
March 28, 2025 ufs-community/ufs-weather-model@6ece76a requires updates to wave point job updates to global test because of wave point answer changes

Requires updates in ICs:

After updated, IC fix ver updates are needed in the code here.

Type of change

  • Routine update of UFS

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? YES
    • UFS-weather-model (to top of develop, PR is merged)

How has this been tested?

I ran two tests to check out the new ICs:
/scratch1/NCEPDEV/climate/Jessica.Meixner/UpdateUFSinGW/gefs03 C48_S2SWA_gefs.yaml
/scratch1/NCEPDEV/climate/Jessica.Meixner/UpdateUFSinGW/s2sw01 C48_S2SW.yaml

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

JessicaMeixner-NOAA and others added 30 commits January 22, 2025 18:10
fix broken logic so that we do not try to copy somethign to COM
… be compatible with the optimized ww3_outp fot netcdf point outputs, per_time_step
…tible with the new optimized ww3_outp program with the netcdf inputs
@emcbot emcbot added the CI-Wcoss2-Building CI testing is cloning/building on WCOSS2 label Apr 10, 2025
@KateFriedman-NOAA KateFriedman-NOAA removed the CI-Wcoss2-Ready PR is ready for CI testing on WCOSS2. label Apr 10, 2025
@emcbot emcbot added CI-Wcoss2-Failed CI testing on WCOSS for this PR has failed and removed CI-Wcoss2-Building CI testing is cloning/building on WCOSS2 labels Apr 10, 2025
@emcbot emcbot added the CI-Wcoss2-Building CI testing is cloning/building on WCOSS2 label Apr 10, 2025
@KateFriedman-NOAA KateFriedman-NOAA removed the CI-Wcoss2-Failed CI testing on WCOSS for this PR has failed label Apr 10, 2025
@emcbot emcbot added CI-Wcoss2-Running CI testing on WCOSS for this PR is in-progress and removed CI-Wcoss2-Building CI testing is cloning/building on WCOSS2 labels Apr 10, 2025
@emcbot
Copy link
Copy Markdown

emcbot commented Apr 10, 2025

CI Tests set up to run in /lfs/h2/emc/ptmp/emc.global/PR/PR_3528/RUNTESTS on WCOSS

@DavidHuber-NOAA
Copy link
Copy Markdown
Contributor

The epos jobs are failing on WCOSS2 for the C96C48_ufs_hybatmDA case. This appears to be a bug in the getsfcensmeanp.x executable. I opened issue NOAA-EMC/GSI-utils#72 to get assistance from the DA team on this. FYI @DavidNew-NOAA @RussTreadon-NOAA.

@KateFriedman-NOAA
Copy link
Copy Markdown
Contributor

CI passed on WCOSS2 minus the C96C48_ufs_hybatmDA test which requires investigation and should be disabled for now. Additionally, the SFS CI test only passed by including the hotfix in PR #3574.

******** C48_ATM_3528 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103231200        Done    Apr 10 2025 17:58:28    Apr 10 2025 19:30:30

******** C48mx500_3DVarAOWCDA_3528 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103241800        Done    Apr 10 2025 17:58:30    Apr 10 2025 18:15:37
202103250000        Done    Apr 10 2025 17:58:30    Apr 10 2025 19:50:24

******** C48mx500_hybAOWCDA_3528 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103241800        Done    Apr 10 2025 17:58:32    Apr 10 2025 18:15:41
202103250000        Done    Apr 10 2025 17:58:32    Apr 10 2025 19:30:37

******** C48_S2SW_3528 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103231200        Done    Apr 10 2025 17:58:34    Apr 10 2025 19:30:40

******** C48_S2SWA_gefs_3528 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103231200        Done    Apr 10 2025 17:58:36    Apr 10 2025 19:40:41

******** C96_atm3DVar_extended_3528 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201800        Done    Apr 10 2025 17:58:38    Apr 10 2025 18:15:54
202112210000        Done    Apr 10 2025 17:58:38    Apr 10 2025 22:45:44
202112210600        Done    Apr 10 2025 17:58:38    Apr 10 2025 23:10:39
202112211200        Done    Apr 10 2025 18:20:56    Apr 11 2025 00:00:50
202112211800        Done    Apr 10 2025 22:50:38    Apr 11 2025 03:30:59

******** C96C48_hybatmaerosnowDA_3528 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201200        Done    Apr 10 2025 17:58:41    Apr 10 2025 18:21:01
202112201800        Done    Apr 10 2025 17:58:41    Apr 10 2025 20:35:47
202112210000        Done    Apr 10 2025 17:58:41    Apr 10 2025 20:20:57

******** C96C48_hybatmDA_3528 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201800        Done    Apr 10 2025 17:58:42    Apr 10 2025 18:16:01
202112210000        Done    Apr 10 2025 17:58:42    Apr 10 2025 20:01:01
202112210600        Done    Apr 10 2025 17:58:42    Apr 10 2025 20:05:51

******** C96C48_ufs_hybatmDA_3528 ********
202402231800        enkfgdas_epos000                   191844307                DEAD                 -29         2        7860.0
202402231800        enkfgdas_epos001                   191865180                DEAD                 271         2         771.0
202402231800        enkfgdas_epos002                   191853786                DEAD                 271         2         657.0
202402231800        enkfgdas_epos003                   191844308                DEAD                 -29         2       20327.0
202402231800        enkfgdas_epos004                   191843844                DEAD                 -29         2        3967.0
202402231800        enkfgdas_epos005                   191830069                DEAD                 -29         2       26560.0
202402231800        enkfgdas_epos006                   191861001                DEAD                 -29         2         965.0

******** C96mx100_S2S_3528 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
199405010000        Done    Apr 10 2025 17:58:46    Apr 10 2025 20:40:55

@KateFriedman-NOAA KateFriedman-NOAA added CI-Wcoss2-Passed CI testing on WCOSS for this PR has completed successfully and removed CI-Wcoss2-Running CI testing on WCOSS for this PR is in-progress labels Apr 11, 2025
@KateFriedman-NOAA
Copy link
Copy Markdown
Contributor

@JessicaMeixner-NOAA please add wcoss2 and hera to the skip list for the C96C48_ufs_hybatmDA CI test in your PR branch. We will work to get it fixed and reenabled. Thanks!

Copy link
Copy Markdown
Contributor

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @JessicaMeixner-NOAA !

@KateFriedman-NOAA KateFriedman-NOAA merged commit 32be0cb into NOAA-EMC:develop Apr 11, 2025
@github-project-automation github-project-automation Bot moved this from In Progress to Done in GFS v17 Apr 11, 2025
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this pull request Apr 11, 2025
* origin/develop:
  Prepare for ops readiness - part 1 (NOAA-EMC#3557)
  Update UFS weather-model to 20250328 hash (NOAA-EMC#3528)
  Fix SFS fcst config (NOAA-EMC#3574)
  Use err_chk in GDAS j-jobs (NOAA-EMC#3570)
tsga added a commit to tsga/global-workflow that referenced this pull request May 1, 2025
* develop:
  Update GSI hash and GSI fix version to resolve bugs (NOAA-EMC#3626)
  Add missing marine DA files to archiving  (NOAA-EMC#3596)
  Add a low resolution test to mimic GFSv17 cycling as much as possible (NOAA-EMC#3617)
  Add the setting to use the reject list for station t/q observations in GSI based soil DA (NOAA-EMC#3599)
  GitLab CI Framework for schedule PR cases and ctests on multi hosts (NOAA-EMC#3603)
  Avoid parallel restart I/O on WCOSS2 (NOAA-EMC#3615)
  Enables user toggling of GDASApp g-w ctests (NOAA-EMC#3587)
  COM variable updates for prep and some external downstream jobs (NOAA-EMC#3608)
  Remove MOS from system (NOAA-EMC#3612)
  Updates to enable soil DA  (NOAA-EMC#3452)
  Unexport SHELLOPTS when running htar (NOAA-EMC#3601)
  Fix check for netcdf wave restart (NOAA-EMC#3594)
  Call err_chk/err_exit for fatal errors in post JJobs/ex-scripts (NOAA-EMC#3571)
  Remove support for Jet and S4 (NOAA-EMC#3572)
  Hotfix in GitLab pipline for Nightly (env MACHINE breaks build on head node) (NOAA-EMC#3578)
  [hotfix] Missed a path during merging develop (NOAA-EMC#3577)
  Prepare for ops readiness - part 1 (NOAA-EMC#3557)
  Update UFS weather-model to 20250328 hash (NOAA-EMC#3528)
  Fix SFS fcst config (NOAA-EMC#3574)
  Use err_chk in GDAS j-jobs (NOAA-EMC#3570)
  Perform compute builds on Gaea head nodes (NOAA-EMC#3560)
  Add initial capability to produce JEDI-based observation space summary stat files (NOAA-EMC#3471)
  Spread epos over more nodes on Hera to increase allocated memory (NOAA-EMC#3567)
  Create separate gists when multiple files are published on GitHub (NOAA-EMC#3551)
  Use err_chk in GSI J-Jobs and scripts (NOAA-EMC#3549)
  Add unified jinja obs list to marine DA (NOAA-EMC#3530)
  Save snow and aerosol analysis increments (and logs and YAMLs) every cycle (NOAA-EMC#3537)
  Add Dependencies to SFS Cleanup Job (NOAA-EMC#3559)
  Updates archiving to reflect current naming of marine anl output (NOAA-EMC#3541)
  Temporarily disable compute builds on C6 (NOAA-EMC#3558)
  Update gdas.cd hash to resolve msu prod_util failure (NOAA-EMC#3556)
  COMIN/COMOUT updates for enkf chgres and downstream product jobs (NOAA-EMC#3518)
  Call err_chk in forecast scripts for fatal errors (NOAA-EMC#3515)
  Add Rocoto Jobs for the Missing Products of GEFS (NOAA-EMC#3466)
  Download subset fix data with python script (NOAA-EMC#3400)
  Check that partition should be set (NOAA-EMC#3543)
  Rename wave output and refactor some wave scripts to use MPMD, and fix some bugzillas along the way (NOAA-EMC#3517)
  Add support for dual batch partitions on AWS NOAA-EMC#3483
  Update CI build and run directories for GitLab Nightlies on C6 and added GitLab support on Hera (NOAA-EMC#3536)
  Hotfix path for CI in Jenkins on Gaea C6 to it's world-share path (NOAA-EMC#3532)
  Create single ocean grib2 product file (NOAA-EMC#3529)
  Scheduled Nightly CI/CD Pipeline Script in GitLab on Gaea C6 (NOAA-EMC#3493)
  make sure cold starts are handled correctly when DOIAU=YES (issue NOAA-EMC#3516) (NOAA-EMC#3520)
  Add check for DO_AERO_FCST before copying fv_tracer files (NOAA-EMC#3485)
  Use jinja templates instead of `@VARNAME@` in config files (NOAA-EMC#3411)
  Replace "status" (or comparable) with "err" in preparation for moving to err_chk/err_exit (NOAA-EMC#3507)
  Error in Java launch script for CI (NOAA-EMC#3465)
  Delete DATAROOT when running generate_workflows.sh (NOAA-EMC#3504)
  Fix 3244 garbled change (NOAA-EMC#3492)
  Enable ensemble archiving via Globus (NOAA-EMC#3479)
  Update MSU FIX_DIR paths (NOAA-EMC#3488)
  Updates for AOWCDA and hybatmaerosnowDA cases on Gaea C6 (NOAA-EMC#3487)
  Update GOCART path for GDAS/GFS/GCAFS implementations  (NOAA-EMC#3455)
  Make RUN Variables Explicit in `config.resources` (NOAA-EMC#3478)
  Remove unused key from enkfgdas_earc_vrfy (NOAA-EMC#3473)
  Bug fix to the failing early cycle marine DA ensemble re-centering (NOAA-EMC#3454)
  Make marine LETKF optional (NOAA-EMC#3462)
  When sourcing for RUN=enkf*, use CASE_ENS (NOAA-EMC#3475)
  Updates for Gaea: verif-global tag, tracker tag, Fit2Obs tag, and C768 analysis resources (NOAA-EMC#3463)
  Update gefswave glo_025 mesh file with new mask (NOAA-EMC#3457)
  Update MSU glopara paths to new role-global space (NOAA-EMC#3443)
  Enable CI testing on AWS (NOAA-EMC#3459)
  Enable Gaea C5 Jenkins CI (NOAA-EMC#3447)
  Job reference removal from WMO product names (NOAA-EMC#3460)
  Turn off aerosol prognostic radiative feedback for GDAS NOAA-EMC#2926 (NOAA-EMC#3445)
  Add DO_GEMPAK check to postsnd subtask (NOAA-EMC#3451)
  Add a force option to setup_xml to ignore unwritable directories (NOAA-EMC#3448)
  Remove the eomg job (NOAA-EMC#3331)
  Migration to role account for Jenkins on Orion (NOAA-EMC#3440)
  Eliminate `_gfs`, `_gdas`, etc, variables and add necessary if blocks (NOAA-EMC#3420)
  Update workflow staging for sfcanl tiles and waveinit (NOAA-EMC#3429)
  Improve messaging to display clear warning when missing snogrb file (NOAA-EMC#3317)
  JEDI-based ensemble recentering and analysis calculation (NOAA-EMC#3312)
  Enable HPSS archiving on C5/6 (NOAA-EMC#3437)
  Check if HOMEDIR STMP and PTMP are writable (NOAA-EMC#3430)
  Update UFS_Utils and GFS-utils hashes to update Gaea support and ocean/ice post products (NOAA-EMC#3433)
  Enable C1152 forecasts on gaea C6 (NOAA-EMC#3438)
  Migration to role account for Jenkins on Hercules (NOAA-EMC#3423)
  Remove Direct Linking to COM from DATA for `extractvars` Job (NOAA-EMC#3379)
  Enable HPSS via Globus on Hercules and Orion
  Remove job name from product files & update GEMPAK module. (NOAA-EMC#3415)
  `link` instead of `copy` in staging jobs (NOAA-EMC#3410)
  Migrate CI Jenkins to role account on Hera (NOAA-EMC#3414)
  Add rocotorc documentation when using scrontab (NOAA-EMC#3417)
  Update jgdas atmos verfozn and verfrad with COMIN/COMOUT prefix instead of COM (NOAA-EMC#3342)
  Add configuration for empirically-corrected ozone parameters (NOAA-EMC#3386)
  Enable global-workflow to run C768C384 GSI on Gaea-C6 (NOAA-EMC#3412)
  Move logical checks into if blocks (NOAA-EMC#3339)
  Adding Jenkins CI to GaeaC6 using role account (NOAA-EMC#3389)
  Enable GDASApp g-w CI cases to run on wcoss2 (NOAA-EMC#3399)
  CI/CD Test on Gaea C5- And update config.gaea under ci/platform (NOAA-EMC#3280)
  Enable cycling support for Gaea C6 (NOAA-EMC#3323)
  Update enkf archive jobs to use COMIN/COMOUT (NOAA-EMC#3393)
  Copy marine ensemble output observation diags and spread (NOAA-EMC#3407)
  Ci testing on aws 2 (NOAA-EMC#3408)
  Disable METplus jobs on Hera (NOAA-EMC#3403)
  Add the mean EnKF soil increment to the deterministic member (NOAA-EMC#3295)
  Add mpich/8.1.19 to the WCOSS2 LD_LIBRARY_PATH for GDASApp jobs (NOAA-EMC#3396)
  Change order of RUNs (NOAA-EMC#3335)
  CI testing on aws (NOAA-EMC#3391)
  Rename Gulf of Mexico in bufr station list in GFSv17 (NOAA-EMC#3384)
  Enabling AWS CI/testing (NOAA-EMC#3383)
  Update issue templates to use new issue type field (NOAA-EMC#3369)
  Replace WAVECUR_DID variable with "rtofs" (NOAA-EMC#3337)
  Allow for C1152 ATM-Aero cycled DA to run on WCOSS2 (NOAA-EMC#3309)
  Remove Direct Linking to COM from DATA for `wavepostsbs` Job (NOAA-EMC#3303)
  Update jgdas enkf update job with COMIN or COMOUT prefix instead of COM (NOAA-EMC#3333)
  Add capability to run diff resolutions for marine anl and background (NOAA-EMC#3238)
  Update high resolution tests and fix minor wave issues  (NOAA-EMC#3289)
  Add sfs as valid system (NOAA-EMC#3243)
  Add missing arch_tars dependencies (NOAA-EMC#3319)
  Fix the empty aerosol DA aerostat tar file issue (NOAA-EMC#3332)
  Add missing file safeguard for IMS prep in snow analysis tasks (NOAA-EMC#3329)
  Fix memory unsetting on Gaea (NOAA-EMC#3325)
  Fix error log parsing in compute build CI (NOAA-EMC#3301)
  Remove marineanlvrfy task from global-workflow (NOAA-EMC#3314)
  Add `gfs_wavepostpnt` dependencies to gfs_cleanup (NOAA-EMC#3313)
  Increase the GDASApp build wallclock (NOAA-EMC#3298)
  Capture build fail in Jenkins pipeline when no error logs are produced (NOAA-EMC#3297)
  Add/update config files for Gaea and check existence before sourcing config files in generate_workflows.sh (NOAA-EMC#3286)
  Fix ocean restarts when cold starting with DOIAU=YES (NOAA-EMC#3278)
  Splitting up the archive task (NOAA-EMC#3242)
  CTests extended validation for C48_ATM and staged C48_S2SW for gfs_fcst and gfs_atmos (NOAA-EMC#3256)
  Add esnowanl to enkfgfs cycle (NOAA-EMC#3283)
  Add gfs cycles to C48mx500_3DVarAOWCDA (NOAA-EMC#3249)
  Add fetch job and update stage_ic to work with fetched ICs (NOAA-EMC#3141)
  Remove WAFS files and references from `develop` (NOAA-EMC#3263)
  fix intel stack version number on c5 (NOAA-EMC#3258)
  Update gsi_monitor and ufs_utils hashes to recent hashes for C5/C6 build and run (NOAA-EMC#3252)
  Enable DA cycling on gaea C5/C6 (NOAA-EMC#3255)
  Copy post-processed sea ice increment for diagnostics (NOAA-EMC#3235)
@JessicaMeixner-NOAA JessicaMeixner-NOAA deleted the updateWW320250327 branch June 26, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-Gaeac6-Passed **Bot use only** CI testing on Gaea C6 for this PR has completed successfully CI-Hercules-Passed **Bot use only** CI testing on Hercules for this PR has completed successfully CI-Wcoss2-Passed CI testing on WCOSS for this PR has completed successfully

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Updating WW3 ICs after UFS PR is merged Add ICEG and ICETMP back as the GFS ATMOS Products Update wave point jobs after ww3 optimization for v17

9 participants