Skip to content

GFSv17 optimized netcdf wave point output#3450

Closed
AliS-Noaa wants to merge 37 commits into
NOAA-EMC:developfrom
AliS-Noaa:optoutp
Closed

GFSv17 optimized netcdf wave point output#3450
AliS-Noaa wants to merge 37 commits into
NOAA-EMC:developfrom
AliS-Noaa:optoutp

Conversation

@AliS-Noaa
Copy link
Copy Markdown

@AliS-Noaa AliS-Noaa commented Mar 14, 2025

Description

Following @dkokron and @AliS-Noaa previous work on optimizing the ww3_outp program to read per time step binary point output and create bull, cbull, and spec files, this version is optimizing the ww3_outp program to process the netcdf point output and create different point outputs. Addressing #3157

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? YES (If YES, please add a link to any PRs that are pending.)

How has this been tested?

This is develop version, so a ci test case (C48) with binary point output without optimized ww3_outp and a test case with optimized ww3_outp with netcdf point output. The bull, cbull, and spec point outputs were identical, however, the optimized netcdf ww3_outp is much more efficient in time and computation resources . These tests are conducted on WCOSS2.

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

JessicaMeixner-NOAA and others added 30 commits January 22, 2025 18:10
fix broken logic so that we do not try to copy somethign to COM
… be compatible with the optimized ww3_outp fot netcdf point outputs, per_time_step
…tible with the new optimized ww3_outp program with the netcdf inputs
Comment thread scripts/exgfs_wave_post_pnt.sh Fixed
Comment thread scripts/exgfs_wave_post_pnt.sh Fixed
Comment thread scripts/exgfs_wave_post_pnt.sh Fixed
@AliS-Noaa
Copy link
Copy Markdown
Author

We are waiting for a ufs-weather-model PR before converting the draft PR to open or opening the PR

@JessicaMeixner-NOAA
Copy link
Copy Markdown
Contributor

The UFS PR has not been created as we are waiting for a PR that is being tested right now. Will have a PR soon to update this.

Comment thread parm/wave/ww3_outp_bull.inp.tmpl Outdated
$ WAVEWATCH III Point output post-processing
$ ------------------------------------------
TIME DT 999
TIME DT 999 1 gfswave
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AliS-Noaa this should be templated because we will want gdaswave for the GDAS runs.

Comment thread scripts/exgfs_wave_post_pnt.sh Outdated
sed -e "s/TIME/${tstart}/g" \
-e "s/DT/${DTPNT_WAV}/g" \
-e "s/999/$N/g" \
-e "s/PREFIX/$RUNwave/g" \
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

${RUN}wave

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also below this needs to be fixed.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JessicaMeixner-NOAA Thanks, its done!

@AliS-Noaa
Copy link
Copy Markdown
Author

This PR is moving into #3528

@aerorahul
Copy link
Copy Markdown
Contributor

OBE
Changes were absorbed in #3528

@aerorahul aerorahul closed this Apr 11, 2025
@github-project-automation github-project-automation Bot moved this to Done in GFS v17 Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants