Enables user toggling of GDASApp g-w ctests#3587
Conversation
KateFriedman-NOAA
left a comment
There was a problem hiding this comment.
Looks good but question, how would a user specify WORKFLOW_BUILD or WORKFLOW_TESTS to override the build_gdas.sh defaults?
|
@RussTreadon-NOAA I am the only g-w CM available to approve and merge this week. Would you like either Rahul or Dave to review this before I run CI and potentially merge this? Also, I just merged a couple PRs into |
|
@KateFriedman-NOAA , thank you contacting me. I've been running CI for this PR on my own to identify & fix issues. There are some related threads it would be good to get closure on (e.g., g-w issue #3593) before we run the official CI on this PR |
|
@RussTreadon-NOAA Sounds good, let me know when you're ready for official CI to run on this. |
|
GDASApp g-w CI GDASApp ctests run subset of jobs from g-w CI cases. Install |
guillaumevernieres
left a comment
There was a problem hiding this comment.
Thanks @RussTreadon-NOAA
|
CI Failed on Hercules in Build# 3 |
|
CI Passed on Gaeac6 in Build# 4 |
|
CI Passed on Hera in Build# 5 |
|
Hercules g-w CI Install All jobs in all cases ran to completion. |
|
Check the log files for the Log file Same message in Log file Same message in These appear to be system and/or automated CI driver errors. |
|
@TerrenceMcGuinness-NOAA Could you take a look at the Hercules failure? Based on this message, it seems that perhaps the CI system may have rebooted at some point?? Are we safe to add the label again? |
|
CI Tests set up to run in /lfs/h2/emc/ptmp/emc.global/PR/PR_3587/RUNTESTS on WCOSS |
|
Orion g-w CI Install All jobs in all cases ran to completion. |
|
CI Passed on Hercules in Build# 7 |
|
WCOSS2 g-w CI Below are results from All jobs ran to completion in all cases. |
DavidHuber-NOAA
left a comment
There was a problem hiding this comment.
Changes look good. All CI passed. Approve.
|
Thank you @DavidHuber-NOAA and @KateFriedman-NOAA for the approvals. Thank you @DavidHuber-NOAA for merging these changes into g-w |
Description
This PR allows users to toggle on/off creation of g-w based CI tests when building GDASApp. Setting
WORKFLOW_TESTS=ONin the user environment turns on the creation of g-w based CI tests when building GDASApp.WORKFLOW_TESTS=OFFis the default.Resolves #3579
Resolves #3593
Resolves #3595
Resolves #3338
Type of change
Change characteristics
How has this been tested?
Clone, build, and run GDASApp 136 ctests on Hera and Hercules
Checklist