Improve messaging to display clear warning when missing snogrb file by KateFriedman-NOAA · Pull Request #3317 · NOAA-EMC/global-workflow

KateFriedman-NOAA · 2025-02-11T19:38:22Z

Description

This PR resolves bugzilla 1373 (Display clear warning when missing snogrb file). The following changes are included in this PR to resolve the bugzilla:

add "INFO" message when final snogrb file is decided in script
add "FATAL ERROR" message when decided-upon snogrb file is missing, exit if so

Also included in this PR are a related bug fix uncovered during work to resolve bugzilla and needed COMIN/COMOUT updates, which are part of a larger initiative. Those changes are:

fix bug with res variable setting in scripts/exgdas_enkf_sfc.sh
COMIN/COMOUT updates for the sfcanl jobs

Also included in this PR is the removal of getges.sh from the related scripts and removal of GETGES mention in some wave job scripts. Full removal of getges.sh will be done in a separate PR.

Refs #2451
Refs #1041
Resolves #2500

Type of change

Bugzilla resolution and bug fix

Change characteristics

Error handling and messaging updates in related workflow scripts.

How has this been tested?

Ran C96_atm3DVar CI test on Hercules.

- Add INFO echo to state which snogrb file will be used in log - Also fix bug with res setting in exgdas_enkf_sfc.sh Resolves bugzilla 1373 Refs NOAA-EMC#2500

- Add "FATAL ERROR" message if either snogrb file is missing. - Update COMIN/COMOUT variable settings (needed) Refs NOAA-EMC#2500

Combine the INFO and FATAL ERROR messaging for snogrb files into the same if-block. Refs NOAA-EMC#2500

Refs NOAA-EMC#2500

CoryMartin-NOAA

one suggestion in several places just to make things clearer in the logs

Refs NOAA-EMC#2500

GeorgeGayno-NOAA · 2025-02-12T13:36:36Z

After looking at the script logic more closely, I think there is a way to avoid a FATAL error. Note this logic. New snow is only created once per day (around 00z), but there are snow files every six hours. In most cases, these are simply copies of the 00z file with a new file name. Snow is only applied in the cycling if there is new snow. Hence, the check here on the internal date/time stamp. If FNSNOA and FNSNOG contain the same time stamp, the snow update is shut off by setting FNSNOW="" and CYCLVARS to 99999.

if [[ $(${WGRIB} -4yr "${FNSNOA}" 2>/dev/null | grep -i snowc | awk -F: '{print $3}' | awk -F= '{print $2}') -le \
  $(${WGRIB} -4yr "${snoprv}" 2>/dev/null | grep -i snowc | awk -F: '{print $3}' | awk -F= '{print $2}') ]] ; then
  export FNSNOA=" "
  export CYCLVARS="FSNOL=99999.,FSNOS=99999.,"
else

If FNSNOA or FNSNOG are missing, the same settings could be done and a WARNING message be printed. The script will continue, and the cycling will not update snow.

The snow data is created by an upstream job which has a logic to always populate FNSNOA and FNSNOG files. So I can't envision this ever happening. But if it does, we can continue running and have the SPA investigate the warning.

KateFriedman-NOAA · 2025-02-12T16:03:41Z

If I understand the discussion above, we don't want to FATAL ERROR and exit if either snogrb file is missing, instead we want to print a WARNING but continue on. Is that correct? If so:

export FNSNOA=${FNSNOA:-${COMIN_OBS}/${OPREFIX}snogrb_t${JCAP_CASE}.${LONB_CASE}.${LATB_CASE}}
# Check if resolution specific FNSNOA exists, if not use t1534 version
[[ ! -f ${FNSNOA} ]] && export FNSNOA="${COMIN_OBS}/${OPREFIX}snogrb_t1534.3072.1536"
if [[ ! -f ${FNSNOA} ]]; then
  echo "WARNING: Current cycle snow file ${FNSNOA} is not available. Job will continue but not update snow."
else
  echo "INFO: Current cycle snow file is ${FNSNOA}"
fi
export FNSNOG=${FNSNOG:-${COMIN_OBS_PREV}/${GPREFIX}snogrb_t${JCAP_CASE}.${LONB_CASE}.${LATB_CASE}}
# Check if resolution specific FNSNOG exists, if not use t1534 version
[[ ! -f ${FNSNOG} ]] && export FNSNOG="${COMIN_OBS_PREV}/${GPREFIX}snogrb_t1534.3072.1536"
if [[ ! -f ${FNSNOG} ]]; then
  echo "WARNING: Previous cycle snow file ${FNSNOG} is not available. Job will continue but not update snow."
else
  echo "INFO: Previous cycle snow file is ${FNSNOG}"
fi

GeorgeGayno-NOAA · 2025-02-12T16:50:15Z

If I understand the discussion above, we don't want to FATAL ERROR and exit if either snogrb file is missing, instead we want to print a WARNING but continue on. Is that correct? If so:

export FNSNOA=${FNSNOA:-${COMIN_OBS}/${OPREFIX}snogrb_t${JCAP_CASE}.${LONB_CASE}.${LATB_CASE}}
# Check if resolution specific FNSNOA exists, if not use t1534 version
[[ ! -f ${FNSNOA} ]] && export FNSNOA="${COMIN_OBS}/${OPREFIX}snogrb_t1534.3072.1536"
if [[ ! -f ${FNSNOA} ]]; then
  echo "WARNING: Current cycle snow file ${FNSNOA} is not available. Job will continue but not update snow."
else
  echo "INFO: Current cycle snow file is ${FNSNOA}"
fi
export FNSNOG=${FNSNOG:-${COMIN_OBS_PREV}/${GPREFIX}snogrb_t${JCAP_CASE}.${LONB_CASE}.${LATB_CASE}}
# Check if resolution specific FNSNOG exists, if not use t1534 version
[[ ! -f ${FNSNOG} ]] && export FNSNOG="${COMIN_OBS_PREV}/${GPREFIX}snogrb_t1534.3072.1536"
if [[ ! -f ${FNSNOG} ]]; then
  echo "WARNING: Previous cycle snow file ${FNSNOG} is not available. Job will continue but not update snow."
else
  echo "INFO: Previous cycle snow file is ${FNSNOG}"
fi

Yes, print a warning, but these variables also must be set:

 export FNSNOA=" "
 export CYCLVARS="FSNOL=99999.,FSNOS=99999.,"

KateFriedman-NOAA · 2025-02-12T19:27:52Z

export FNSNOA=" "
export CYCLVARS="FSNOL=99999.,FSNOS=99999.,"

Gotcha. Set those for both the missing current cycle and previous cycle snogrb files? Should these if-blocks get merged for any reason?

Like:

export FNSNOA=${FNSNOA:-${COMIN_OBS}/${OPREFIX}snogrb_t${JCAP_CASE}.${LONB_CASE}.${LATB_CASE}}
# Check if resolution specific FNSNOA exists, if not use t1534 version
[[ ! -f ${FNSNOA} ]] && export FNSNOA="${COMIN_OBS}/${OPREFIX}snogrb_t1534.3072.1536"
if [[ ! -f ${FNSNOA} ]]; then
  echo "WARNING: Current cycle snow file ${FNSNOA} is not available. Job will continue but not update snow."
  export FNSNOA=" "
  export CYCLVARS="FSNOL=99999.,FSNOS=99999.,"
else
  echo "INFO: Current cycle snow file is ${FNSNOA}"
fi
export FNSNOG=${FNSNOG:-${COMIN_OBS_PREV}/${GPREFIX}snogrb_t${JCAP_CASE}.${LONB_CASE}.${LATB_CASE}}
# Check if resolution specific FNSNOG exists, if not use t1534 version
[[ ! -f ${FNSNOG} ]] && export FNSNOG="${COMIN_OBS_PREV}/${GPREFIX}snogrb_t1534.3072.1536"
if [[ ! -f ${FNSNOG} ]]; then
  echo "WARNING: Previous cycle snow file ${FNSNOG} is not available. Job will continue but not update snow."
  export FNSNOA=" "
  export CYCLVARS="FSNOL=99999.,FSNOS=99999.,"
else
  echo "INFO: Previous cycle snow file is ${FNSNOG}"
fi

GeorgeGayno-NOAA · 2025-02-12T21:45:08Z

Something like (not sure the syntax is exactly correct):

# one or both files dont exist. turn off cycling of snow.
if [[ -f ${FNSNOA} ]] || [ -f ${snoprv} ]]; then
    export FNSNOA=" "
    export CYCLVARS="FSNOL=99999.,FSNOS=99999.,"
# both files exist. check grib date of each file. if the current data it not newer than the previous data, turn off cycling.
elif [ $($WGRIB -4yr $FNSNOA 2>/dev/null | grep -i snowc | awk -F: '{print $3}' | awk -F= '{print $2}') -le \
     $($WGRIB -4yr $snoprv 2>/dev/null | grep -i snowc | awk -F: '{print $3}' | awk -F= '{print $2}') ] ; then
    export FNSNOA=" "
    export CYCLVARS="FSNOL=99999.,FSNOS=99999.,"
# current data is newer than previous data. apply snow.
else
    export SNOW_NUDGE_COEFF=${SNOW_NUDGE_COEFF:-0.}
    export CYCLVARS="FSNOL=${SNOW_NUDGE_COEFF},$CYCLVARS"
fi

I think that will work. There may be a way to combine the first two branches. Also, how is $snoprv set when GETGES is called? Can we do a '-f' check on it?

KateFriedman-NOAA · 2025-02-14T16:58:30Z

how is $snoprv set when GETGES is called?

When RUN_GETGES=NO it uses the value of FNSNOG:

+ exgdas_enkf_sfc.sh[108]: snoprv=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS_test/COMROOT/C96C48_hybatmDA/gdas.20211221/00/obs/gdas.t00z.snogrb_t1534.3072.1536

If RUN_GETGES=YES then it would invoke this line:

snoprv=$($GETGESSH -q -t snogrb_$JCAP_CASE -e $gesenvir -n $GDUMP -v $GDATE)

I tried that by hardcoding RUN_GETGES=YES and hit a bunch of unbound variables and issues. Can tell we never invoke getges.sh in our v17 testing. I think we should rework this part and/or consider updating getges.sh or doing away with it. Thoughts?

KateFriedman-NOAA · 2025-02-24T18:25:41Z

@GeorgeGayno-NOAA checking in on your thoughts from my last comment. Thanks!

GeorgeGayno-NOAA · 2025-02-24T18:49:33Z

@GeorgeGayno-NOAA checking in on your thoughts from my last comment. Thanks!

If getges.sh is not used and if it is not required for operations, then I would get rid of it.

JessicaMeixner-NOAA

Approve these changes to the wave related files, did not look at others.

KateFriedman-NOAA · 2025-03-10T18:22:02Z

@GeorgeGayno-NOAA checking in on your thoughts from my last comment. Thanks!

If getges.sh is not used and if it is not required for operations, then I would get rid of it.

@GeorgeGayno-NOAA please see the updated changeset in this PR. I removed the usage of getges.sh from the sfc scripts and by doing so I also removed the snoprv variable. Let me know if these changes look good to resolve the bugzilla. Thanks!

GeorgeGayno-NOAA · 2025-03-10T19:50:20Z

@KateFriedman-NOAA - we can avoid a FATAL error and instead issue a warning. On Hera, see my updates to exglobal_atmos_sfcanl.sh in /scratch2/NCEPDEV/stmp1/George.Gayno/global-workflow/scripts. If that logic works, I can add it to exgdas_enkf_sfc.sh.

How can we test this?

DavidHuber-NOAA

Looking through @GeorgeGayno-NOAA's suggestions in /scratch2/NCEPDEV/stmp1/George.Gayno/global-workflow/scripts/exglobal_atmos_sfcanl.sh, I think I am OK with issuing a warning instead of a FATAL ERROR. I've added suggestions from his script (please check my suggestions, George). Thoughts @KateFriedman-NOAA?

Similar changes would need to be added to exgdas_enkf_sfc.sh.

DavidHuber-NOAA · 2025-03-12T15:23:18Z

@GeorgeGayno-NOAA I think we could test this locally in a one-off test case by adding an rm -f "${COMIN_OBS}/${OPREFIX}snogrb_t1534.3072.1536" to the beginning of exglobal_atmos_sfcanl.sh and exgdas_enkf_sfc.sh. You could then run a C96C48_hybatmaerosnowDA test case.

Refs NOAA-EMC#2500

GeorgeGayno-NOAA · 2025-03-12T17:47:04Z

@GeorgeGayno-NOAA I think we could test this locally in a one-off test case by adding an rm -f "${COMIN_OBS}/${OPREFIX}snogrb_t1534.3072.1536" to the beginning of exglobal_atmos_sfcanl.sh and exgdas_enkf_sfc.sh. You could then run a C96C48_hybatmaerosnowDA test case.

Sounds good. I am happy to look at test results.

KateFriedman-NOAA · 2025-03-13T13:23:52Z

@GeorgeGayno-NOAA Please see the following log on Hera:
/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/logs/2021122018/gfs_sfcanl.log

I added the suggested file removal from @DavidHuber-NOAA and it worked to show some of the logic. 1) The t1534 snow file was removed from the obs folder, 2) the lower res file isn't available so it set it for the t1534 file, 3) the t1534 file isn't available (since we removed it), so it kicked off the WARNING message.

+ exglobal_atmos_sfcanl.sh[56]: JCAP_CASE=190
+ exglobal_atmos_sfcanl.sh[57]: LATB_CASE=192
+ exglobal_atmos_sfcanl.sh[58]: LONB_CASE=384
+ exglobal_atmos_sfcanl.sh[60]: rm -f /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gfs.20211220/18/obs/gfs.t18z.snogrb_t1534.3072.1536
+ exglobal_atmos_sfcanl.sh[63]: export 'FNTSFA=        '
+ exglobal_atmos_sfcanl.sh[63]: FNTSFA='        '
+ exglobal_atmos_sfcanl.sh[64]: export FNACNA=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gfs.20211220/18/obs/gfs.t18z.seaice.5min.blend.grb
+ exglobal_atmos_sfcanl.sh[64]: FNACNA=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gfs.20211220/18/obs/gfs.t18z.seaice.5min.blend.grb
+ exglobal_atmos_sfcanl.sh[65]: export FNSNOA=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gfs.20211220/18/obs/gfs.t18z.snogrb_t190.384.192
+ exglobal_atmos_sfcanl.sh[65]: FNSNOA=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gfs.20211220/18/obs/gfs.t18z.snogrb_t190.384.192
+ exglobal_atmos_sfcanl.sh[67]: [[ ! -f /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gfs.20211220/18/obs/gfs.t18z.snogrb_t190.384.192 ]]
+ exglobal_atmos_sfcanl.sh[68]: export FNSNOA=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gfs.20211220/18/obs/gfs.t18z.snogrb_t1534.3072.1536
+ exglobal_atmos_sfcanl.sh[68]: FNSNOA=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gfs.20211220/18/obs/gfs.t18z.snogrb_t1534.3072.1536
+ exglobal_atmos_sfcanl.sh[70]: [[ ! -f /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gfs.20211220/18/obs/gfs.t18z.snogrb_t1534.3072.1536 ]]
+ exglobal_atmos_sfcanl.sh[71]: echo 'WARNING: Current cycle snow file /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gfs.20211220/18/obs/gfs.t18z.snogrb_t1534.3072.1536 is missing.  Snow coverage will not be updated.'
WARNING: Current cycle snow file /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gfs.20211220/18/obs/gfs.t18z.snogrb_t1534.3072.1536 is missing.  Snow coverage will not be updated.
+ exglobal_atmos_sfcanl.sh[75]: export FNSNOG=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/12/obs/gdas.t12z.snogrb_t190.384.192
+ exglobal_atmos_sfcanl.sh[75]: FNSNOG=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/12/obs/gdas.t12z.snogrb_t190.384.192
+ exglobal_atmos_sfcanl.sh[77]: [[ ! -f /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/12/obs/gdas.t12z.snogrb_t190.384.192 ]]
+ exglobal_atmos_sfcanl.sh[78]: export FNSNOG=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/12/obs/gdas.t12z.snogrb_t1534.3072.1536
+ exglobal_atmos_sfcanl.sh[78]: FNSNOG=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/12/obs/gdas.t12z.snogrb_t1534.3072.1536
+ exglobal_atmos_sfcanl.sh[80]: [[ ! -f /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/12/obs/gdas.t12z.snogrb_t1534.3072.1536 ]]
+ exglobal_atmos_sfcanl.sh[83]: echo 'INFO: Previous cycle snow file is /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/12/obs/gdas.t12z.snogrb_t1534.3072.1536'
INFO: Previous cycle snow file is /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/12/obs/gdas.t12z.snogrb_t1534.3072.1536
+ exglobal_atmos_sfcanl.sh[87]: [[ ! -f /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gfs.20211220/18/obs/gfs.t18z.snogrb_t1534.3072.1536 ]]

GeorgeGayno-NOAA · 2025-03-13T17:29:48Z

@GeorgeGayno-NOAA Please see the following log on Hera: /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/logs/2021122018/gfs_sfcanl.log

I added the suggested file removal from @DavidHuber-NOAA and it worked to show some of the logic. 1) The t1534 snow file was removed from the obs folder, 2) the lower res file isn't available so it set it for the t1534 file, 3) the t1534 file isn't available (since we removed it), so it kicked off the WARNING message.

+ exglobal_atmos_sfcanl.sh[56]: JCAP_CASE=190
+ exglobal_atmos_sfcanl.sh[57]: LATB_CASE=192
+ exglobal_atmos_sfcanl.sh[58]: LONB_CASE=384
+ exglobal_atmos_sfcanl.sh[60]: rm -f /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gfs.20211220/18/obs/gfs.t18z.snogrb_t1534.3072.1536
+ exglobal_atmos_sfcanl.sh[63]: export 'FNTSFA=        '
+ exglobal_atmos_sfcanl.sh[63]: FNTSFA='        '
+ exglobal_atmos_sfcanl.sh[64]: export FNACNA=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gfs.20211220/18/obs/gfs.t18z.seaice.5min.blend.grb
+ exglobal_atmos_sfcanl.sh[64]: FNACNA=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gfs.20211220/18/obs/gfs.t18z.seaice.5min.blend.grb
+ exglobal_atmos_sfcanl.sh[65]: export FNSNOA=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gfs.20211220/18/obs/gfs.t18z.snogrb_t190.384.192
+ exglobal_atmos_sfcanl.sh[65]: FNSNOA=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gfs.20211220/18/obs/gfs.t18z.snogrb_t190.384.192
+ exglobal_atmos_sfcanl.sh[67]: [[ ! -f /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gfs.20211220/18/obs/gfs.t18z.snogrb_t190.384.192 ]]
+ exglobal_atmos_sfcanl.sh[68]: export FNSNOA=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gfs.20211220/18/obs/gfs.t18z.snogrb_t1534.3072.1536
+ exglobal_atmos_sfcanl.sh[68]: FNSNOA=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gfs.20211220/18/obs/gfs.t18z.snogrb_t1534.3072.1536
+ exglobal_atmos_sfcanl.sh[70]: [[ ! -f /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gfs.20211220/18/obs/gfs.t18z.snogrb_t1534.3072.1536 ]]
+ exglobal_atmos_sfcanl.sh[71]: echo 'WARNING: Current cycle snow file /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gfs.20211220/18/obs/gfs.t18z.snogrb_t1534.3072.1536 is missing.  Snow coverage will not be updated.'
WARNING: Current cycle snow file /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gfs.20211220/18/obs/gfs.t18z.snogrb_t1534.3072.1536 is missing.  Snow coverage will not be updated.
+ exglobal_atmos_sfcanl.sh[75]: export FNSNOG=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/12/obs/gdas.t12z.snogrb_t190.384.192
+ exglobal_atmos_sfcanl.sh[75]: FNSNOG=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/12/obs/gdas.t12z.snogrb_t190.384.192
+ exglobal_atmos_sfcanl.sh[77]: [[ ! -f /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/12/obs/gdas.t12z.snogrb_t190.384.192 ]]
+ exglobal_atmos_sfcanl.sh[78]: export FNSNOG=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/12/obs/gdas.t12z.snogrb_t1534.3072.1536
+ exglobal_atmos_sfcanl.sh[78]: FNSNOG=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/12/obs/gdas.t12z.snogrb_t1534.3072.1536
+ exglobal_atmos_sfcanl.sh[80]: [[ ! -f /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/12/obs/gdas.t12z.snogrb_t1534.3072.1536 ]]
+ exglobal_atmos_sfcanl.sh[83]: echo 'INFO: Previous cycle snow file is /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/12/obs/gdas.t12z.snogrb_t1534.3072.1536'
INFO: Previous cycle snow file is /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/12/obs/gdas.t12z.snogrb_t1534.3072.1536
+ exglobal_atmos_sfcanl.sh[87]: [[ ! -f /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gfs.20211220/18/obs/gfs.t18z.snogrb_t1534.3072.1536 ]]

The logic is working. Do you want to test the other possible permutations?

KateFriedman-NOAA · 2025-03-13T18:11:32Z

The logic is working. Do you want to test the other possible permutations?

Yep, rerunning with the prior file also missing. Will share log and snippet when run.

KateFriedman-NOAA · 2025-03-13T18:24:11Z

Logic works when both current and previous snow files are missing. See log:
/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/logs/2021122100/gdas_sfcanl.log

+ exglobal_atmos_sfcanl.sh[60]: rm -f /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211221/00/obs/gdas.t00z.snogrb_t1534.3072.1536
+ exglobal_atmos_sfcanl.sh[61]: rm -f /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/18/obs/gdas.t18z.snogrb_t1534.3072.1536
+ exglobal_atmos_sfcanl.sh[64]: export 'FNTSFA=        '
+ exglobal_atmos_sfcanl.sh[64]: FNTSFA='        '
+ exglobal_atmos_sfcanl.sh[65]: export FNACNA=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211221/00/obs/gdas.t00z.seaice.5min.blend.grb
+ exglobal_atmos_sfcanl.sh[65]: FNACNA=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211221/00/obs/gdas.t00z.seaice.5min.blend.grb
+ exglobal_atmos_sfcanl.sh[66]: export FNSNOA=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211221/00/obs/gdas.t00z.snogrb_t190.384.192
+ exglobal_atmos_sfcanl.sh[66]: FNSNOA=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211221/00/obs/gdas.t00z.snogrb_t190.384.192
+ exglobal_atmos_sfcanl.sh[68]: [[ ! -f /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211221/00/obs/gdas.t00z.snogrb_t190.384.192 ]]
+ exglobal_atmos_sfcanl.sh[69]: export FNSNOA=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211221/00/obs/gdas.t00z.snogrb_t1534.3072.1536
+ exglobal_atmos_sfcanl.sh[69]: FNSNOA=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211221/00/obs/gdas.t00z.snogrb_t1534.3072.1536
+ exglobal_atmos_sfcanl.sh[71]: [[ ! -f /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211221/00/obs/gdas.t00z.snogrb_t1534.3072.1536 ]]
+ exglobal_atmos_sfcanl.sh[72]: echo 'WARNING: Current cycle snow file /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211221/00/obs/gdas.t00z.snogrb_t1534.3072.1536 is missing.  Snow coverage will not be updated.'
WARNING: Current cycle snow file /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211221/00/obs/gdas.t00z.snogrb_t1534.3072.1536 is missing.  Snow coverage will not be updated.+ exglobal_atmos_sfcanl.sh[76]: export FNSNOG=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/18/obs/gdas.t18z.snogrb_t190.384.192
+ exglobal_atmos_sfcanl.sh[76]: FNSNOG=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/18/obs/gdas.t18z.snogrb_t190.384.192
+ exglobal_atmos_sfcanl.sh[78]: [[ ! -f /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/18/obs/gdas.t18z.snogrb_t190.384.192 ]]
+ exglobal_atmos_sfcanl.sh[79]: export FNSNOG=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/18/obs/gdas.t18z.snogrb_t1534.3072.1536
+ exglobal_atmos_sfcanl.sh[79]: FNSNOG=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/18/obs/gdas.t18z.snogrb_t1534.3072.1536
+ exglobal_atmos_sfcanl.sh[81]: [[ ! -f /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/18/obs/gdas.t18z.snogrb_t1534.3072.1536 ]]
+ exglobal_atmos_sfcanl.sh[82]: echo 'WARNING: Previous cycle snow file /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/18/obs/gdas.t18z.snogrb_t1534.3072.1536 is missing.  Snow coverage will not be updated.'
WARNING: Previous cycle snow file /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/18/obs/gdas.t18z.snogrb_t1534.3072.1536 is missing.  Snow coverage will not be updated.
+ exglobal_atmos_sfcanl.sh[88]: [[ ! -f /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211221/00/obs/gdas.t00z.snogrb_t1534.3072.1536 ]]
+ exglobal_atmos_sfcanl.sh[89]: export 'FNSNOA= '
+ exglobal_atmos_sfcanl.sh[89]: FNSNOA=' '
+ exglobal_atmos_sfcanl.sh[90]: export CYCLVARS=FSNOL=99999.,FSNOS=99999.,
+ exglobal_atmos_sfcanl.sh[90]: CYCLVARS=FSNOL=99999.,FSNOS=99999.,
+ exglobal_atmos_sfcanl.sh[101]: [[ YES == \Y\E\S ]]

Any other condition to test?

GeorgeGayno-NOAA · 2025-03-13T20:01:28Z

Logic works when both current and previous snow files are missing. See log: /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/logs/2021122100/gdas_sfcanl.log

+ exglobal_atmos_sfcanl.sh[60]: rm -f /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211221/00/obs/gdas.t00z.snogrb_t1534.3072.1536
+ exglobal_atmos_sfcanl.sh[61]: rm -f /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/18/obs/gdas.t18z.snogrb_t1534.3072.1536
+ exglobal_atmos_sfcanl.sh[64]: export 'FNTSFA=        '
+ exglobal_atmos_sfcanl.sh[64]: FNTSFA='        '
+ exglobal_atmos_sfcanl.sh[65]: export FNACNA=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211221/00/obs/gdas.t00z.seaice.5min.blend.grb
+ exglobal_atmos_sfcanl.sh[65]: FNACNA=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211221/00/obs/gdas.t00z.seaice.5min.blend.grb
+ exglobal_atmos_sfcanl.sh[66]: export FNSNOA=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211221/00/obs/gdas.t00z.snogrb_t190.384.192
+ exglobal_atmos_sfcanl.sh[66]: FNSNOA=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211221/00/obs/gdas.t00z.snogrb_t190.384.192
+ exglobal_atmos_sfcanl.sh[68]: [[ ! -f /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211221/00/obs/gdas.t00z.snogrb_t190.384.192 ]]
+ exglobal_atmos_sfcanl.sh[69]: export FNSNOA=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211221/00/obs/gdas.t00z.snogrb_t1534.3072.1536
+ exglobal_atmos_sfcanl.sh[69]: FNSNOA=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211221/00/obs/gdas.t00z.snogrb_t1534.3072.1536
+ exglobal_atmos_sfcanl.sh[71]: [[ ! -f /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211221/00/obs/gdas.t00z.snogrb_t1534.3072.1536 ]]
+ exglobal_atmos_sfcanl.sh[72]: echo 'WARNING: Current cycle snow file /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211221/00/obs/gdas.t00z.snogrb_t1534.3072.1536 is missing.  Snow coverage will not be updated.'
WARNING: Current cycle snow file /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211221/00/obs/gdas.t00z.snogrb_t1534.3072.1536 is missing.  Snow coverage will not be updated.+ exglobal_atmos_sfcanl.sh[76]: export FNSNOG=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/18/obs/gdas.t18z.snogrb_t190.384.192
+ exglobal_atmos_sfcanl.sh[76]: FNSNOG=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/18/obs/gdas.t18z.snogrb_t190.384.192
+ exglobal_atmos_sfcanl.sh[78]: [[ ! -f /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/18/obs/gdas.t18z.snogrb_t190.384.192 ]]
+ exglobal_atmos_sfcanl.sh[79]: export FNSNOG=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/18/obs/gdas.t18z.snogrb_t1534.3072.1536
+ exglobal_atmos_sfcanl.sh[79]: FNSNOG=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/18/obs/gdas.t18z.snogrb_t1534.3072.1536
+ exglobal_atmos_sfcanl.sh[81]: [[ ! -f /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/18/obs/gdas.t18z.snogrb_t1534.3072.1536 ]]
+ exglobal_atmos_sfcanl.sh[82]: echo 'WARNING: Previous cycle snow file /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/18/obs/gdas.t18z.snogrb_t1534.3072.1536 is missing.  Snow coverage will not be updated.'
WARNING: Previous cycle snow file /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/18/obs/gdas.t18z.snogrb_t1534.3072.1536 is missing.  Snow coverage will not be updated.
+ exglobal_atmos_sfcanl.sh[88]: [[ ! -f /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211221/00/obs/gdas.t00z.snogrb_t1534.3072.1536 ]]
+ exglobal_atmos_sfcanl.sh[89]: export 'FNSNOA= '
+ exglobal_atmos_sfcanl.sh[89]: FNSNOA=' '
+ exglobal_atmos_sfcanl.sh[90]: export CYCLVARS=FSNOL=99999.,FSNOS=99999.,
+ exglobal_atmos_sfcanl.sh[90]: CYCLVARS=FSNOL=99999.,FSNOS=99999.,
+ exglobal_atmos_sfcanl.sh[101]: [[ YES == \Y\E\S ]]

Any other condition to test?

If we want to be thorough, we should test the case when the current data is available, but the previous cycle data is missing.

KateFriedman-NOAA · 2025-03-14T12:54:19Z

Good thinking...see this rerun with the current file in place but not the prior:
/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/logs/2021122100/gdas_sfcanl.log

+ exglobal_atmos_sfcanl.sh[61]: rm -f /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/18/obs/gdas.t18z.snogrb_t1534.3072.1536
+ exglobal_atmos_sfcanl.sh[64]: export 'FNTSFA=        '
+ exglobal_atmos_sfcanl.sh[64]: FNTSFA='        '
+ exglobal_atmos_sfcanl.sh[65]: export FNACNA=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211221/00/obs/gdas.t00z.seaice.5min.blend.grb
+ exglobal_atmos_sfcanl.sh[65]: FNACNA=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211221/00/obs/gdas.t00z.seaice.5min.blend.grb
+ exglobal_atmos_sfcanl.sh[66]: export FNSNOA=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211221/00/obs/gdas.t00z.snogrb_t190.384.192
+ exglobal_atmos_sfcanl.sh[66]: FNSNOA=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211221/00/obs/gdas.t00z.snogrb_t190.384.192
+ exglobal_atmos_sfcanl.sh[68]: [[ ! -f /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211221/00/obs/gdas.t00z.snogrb_t190.384.192 ]]
+ exglobal_atmos_sfcanl.sh[69]: export FNSNOA=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211221/00/obs/gdas.t00z.snogrb_t1534.3072.1536
+ exglobal_atmos_sfcanl.sh[69]: FNSNOA=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211221/00/obs/gdas.t00z.snogrb_t1534.3072.1536
+ exglobal_atmos_sfcanl.sh[71]: [[ ! -f /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211221/00/obs/gdas.t00z.snogrb_t1534.3072.1536 ]]
+ exglobal_atmos_sfcanl.sh[74]: echo 'INFO: Current cycle snow file is /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211221/00/obs/gdas.t00z.snogrb_t1534.3072.1536'
INFO: Current cycle snow file is /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211221/00/obs/gdas.t00z.snogrb_t1534.3072.1536
+ exglobal_atmos_sfcanl.sh[76]: export FNSNOG=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/18/obs/gdas.t18z.snogrb_t190.384.192
+ exglobal_atmos_sfcanl.sh[76]: FNSNOG=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/18/obs/gdas.t18z.snogrb_t190.384.192
+ exglobal_atmos_sfcanl.sh[78]: [[ ! -f /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/18/obs/gdas.t18z.snogrb_t190.384.192 ]]
+ exglobal_atmos_sfcanl.sh[79]: export FNSNOG=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/18/obs/gdas.t18z.snogrb_t1534.3072.1536
+ exglobal_atmos_sfcanl.sh[79]: FNSNOG=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/18/obs/gdas.t18z.snogrb_t1534.3072.1536
+ exglobal_atmos_sfcanl.sh[81]: [[ ! -f /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/18/obs/gdas.t18z.snogrb_t1534.3072.1536 ]]
+ exglobal_atmos_sfcanl.sh[82]: echo 'WARNING: Previous cycle snow file /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/18/obs/gdas.t18z.snogrb_t1534.3072.1536 is missing.  Snow coverage will not be updated.'
WARNING: Previous cycle snow file /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/18/obs/gdas.t18z.snogrb_t1534.3072.1536 is missing.  Snow coverage will not be updated.
+ exglobal_atmos_sfcanl.sh[88]: [[ ! -f /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211221/00/obs/gdas.t00z.snogrb_t1534.3072.1536 ]]
+ exglobal_atmos_sfcanl.sh[88]: [[ ! -f /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/18/obs/gdas.t18z.snogrb_t1534.3072.1536 ]]
+ exglobal_atmos_sfcanl.sh[89]: export 'FNSNOA= '
+ exglobal_atmos_sfcanl.sh[89]: FNSNOA=' '
+ exglobal_atmos_sfcanl.sh[90]: export CYCLVARS=FSNOL=99999.,FSNOS=99999.,
+ exglobal_atmos_sfcanl.sh[90]: CYCLVARS=FSNOL=99999.,FSNOS=99999.,
+ exglobal_atmos_sfcanl.sh[101]: [[ YES == \Y\E\S ]]

GeorgeGayno-NOAA · 2025-03-14T13:10:47Z

Good thinking...see this rerun with the current file in place but not the prior: /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/logs/2021122100/gdas_sfcanl.log

+ exglobal_atmos_sfcanl.sh[61]: rm -f /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/18/obs/gdas.t18z.snogrb_t1534.3072.1536
+ exglobal_atmos_sfcanl.sh[64]: export 'FNTSFA=        '
+ exglobal_atmos_sfcanl.sh[64]: FNTSFA='        '
+ exglobal_atmos_sfcanl.sh[65]: export FNACNA=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211221/00/obs/gdas.t00z.seaice.5min.blend.grb
+ exglobal_atmos_sfcanl.sh[65]: FNACNA=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211221/00/obs/gdas.t00z.seaice.5min.blend.grb
+ exglobal_atmos_sfcanl.sh[66]: export FNSNOA=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211221/00/obs/gdas.t00z.snogrb_t190.384.192
+ exglobal_atmos_sfcanl.sh[66]: FNSNOA=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211221/00/obs/gdas.t00z.snogrb_t190.384.192
+ exglobal_atmos_sfcanl.sh[68]: [[ ! -f /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211221/00/obs/gdas.t00z.snogrb_t190.384.192 ]]
+ exglobal_atmos_sfcanl.sh[69]: export FNSNOA=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211221/00/obs/gdas.t00z.snogrb_t1534.3072.1536
+ exglobal_atmos_sfcanl.sh[69]: FNSNOA=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211221/00/obs/gdas.t00z.snogrb_t1534.3072.1536
+ exglobal_atmos_sfcanl.sh[71]: [[ ! -f /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211221/00/obs/gdas.t00z.snogrb_t1534.3072.1536 ]]
+ exglobal_atmos_sfcanl.sh[74]: echo 'INFO: Current cycle snow file is /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211221/00/obs/gdas.t00z.snogrb_t1534.3072.1536'
INFO: Current cycle snow file is /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211221/00/obs/gdas.t00z.snogrb_t1534.3072.1536
+ exglobal_atmos_sfcanl.sh[76]: export FNSNOG=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/18/obs/gdas.t18z.snogrb_t190.384.192
+ exglobal_atmos_sfcanl.sh[76]: FNSNOG=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/18/obs/gdas.t18z.snogrb_t190.384.192
+ exglobal_atmos_sfcanl.sh[78]: [[ ! -f /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/18/obs/gdas.t18z.snogrb_t190.384.192 ]]
+ exglobal_atmos_sfcanl.sh[79]: export FNSNOG=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/18/obs/gdas.t18z.snogrb_t1534.3072.1536
+ exglobal_atmos_sfcanl.sh[79]: FNSNOG=/scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/18/obs/gdas.t18z.snogrb_t1534.3072.1536
+ exglobal_atmos_sfcanl.sh[81]: [[ ! -f /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/18/obs/gdas.t18z.snogrb_t1534.3072.1536 ]]
+ exglobal_atmos_sfcanl.sh[82]: echo 'WARNING: Previous cycle snow file /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/18/obs/gdas.t18z.snogrb_t1534.3072.1536 is missing.  Snow coverage will not be updated.'
WARNING: Previous cycle snow file /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/18/obs/gdas.t18z.snogrb_t1534.3072.1536 is missing.  Snow coverage will not be updated.
+ exglobal_atmos_sfcanl.sh[88]: [[ ! -f /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211221/00/obs/gdas.t00z.snogrb_t1534.3072.1536 ]]
+ exglobal_atmos_sfcanl.sh[88]: [[ ! -f /scratch1/NCEPDEV/stmp4/Kate.Friedman/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA/gdas.20211220/18/obs/gdas.t18z.snogrb_t1534.3072.1536 ]]
+ exglobal_atmos_sfcanl.sh[89]: export 'FNSNOA= '
+ exglobal_atmos_sfcanl.sh[89]: FNSNOA=' '
+ exglobal_atmos_sfcanl.sh[90]: export CYCLVARS=FSNOL=99999.,FSNOS=99999.,
+ exglobal_atmos_sfcanl.sh[90]: CYCLVARS=FSNOL=99999.,FSNOS=99999.,
+ exglobal_atmos_sfcanl.sh[101]: [[ YES == \Y\E\S ]]

Looks good. The logic is working. So, did we satisfy the bugzilla?

KateFriedman-NOAA · 2025-03-14T14:14:21Z

So, did we satisfy the bugzilla?

Yes, the bugzilla asked us to "produce a clear warning if the file is missing". I believe that has been achieved in this PR.

@GeorgeGayno-NOAA Please proceed with approving if you're good with the changes and we'll update the bugzilla to let NCO know it has been resolved in GFSv17. Thanks for your help with this @GeorgeGayno-NOAA and @DavidHuber-NOAA !

DavidHuber-NOAA

Looks good to me! Thanks for the work on this @KateFriedman-NOAA @GeorgeGayno-NOAA!

DavidHuber-NOAA · 2025-03-14T14:18:51Z

I don't think additional testing is required for this PR and it is ready to merge.

* develop: Delete DATAROOT when running generate_workflows.sh (NOAA-EMC#3504) Fix 3244 garbled change (NOAA-EMC#3492) Enable ensemble archiving via Globus (NOAA-EMC#3479) Update MSU FIX_DIR paths (NOAA-EMC#3488) Updates for AOWCDA and hybatmaerosnowDA cases on Gaea C6 (NOAA-EMC#3487) Update GOCART path for GDAS/GFS/GCAFS implementations (NOAA-EMC#3455) Make RUN Variables Explicit in `config.resources` (NOAA-EMC#3478) Remove unused key from enkfgdas_earc_vrfy (NOAA-EMC#3473) Bug fix to the failing early cycle marine DA ensemble re-centering (NOAA-EMC#3454) Make marine LETKF optional (NOAA-EMC#3462) When sourcing for RUN=enkf*, use CASE_ENS (NOAA-EMC#3475) Updates for Gaea: verif-global tag, tracker tag, Fit2Obs tag, and C768 analysis resources (NOAA-EMC#3463) Update gefswave glo_025 mesh file with new mask (NOAA-EMC#3457) Update MSU glopara paths to new role-global space (NOAA-EMC#3443) Enable CI testing on AWS (NOAA-EMC#3459) Enable Gaea C5 Jenkins CI (NOAA-EMC#3447) Job reference removal from WMO product names (NOAA-EMC#3460) Turn off aerosol prognostic radiative feedback for GDAS NOAA-EMC#2926 (NOAA-EMC#3445) Add DO_GEMPAK check to postsnd subtask (NOAA-EMC#3451) Add a force option to setup_xml to ignore unwritable directories (NOAA-EMC#3448) Remove the eomg job (NOAA-EMC#3331) Migration to role account for Jenkins on Orion (NOAA-EMC#3440) Eliminate `_gfs`, `_gdas`, etc, variables and add necessary if blocks (NOAA-EMC#3420) Update workflow staging for sfcanl tiles and waveinit (NOAA-EMC#3429) Improve messaging to display clear warning when missing snogrb file (NOAA-EMC#3317) JEDI-based ensemble recentering and analysis calculation (NOAA-EMC#3312) Enable HPSS archiving on C5/6 (NOAA-EMC#3437) Check if HOMEDIR STMP and PTMP are writable (NOAA-EMC#3430) Update UFS_Utils and GFS-utils hashes to update Gaea support and ocean/ice post products (NOAA-EMC#3433) Enable C1152 forecasts on gaea C6 (NOAA-EMC#3438) Migration to role account for Jenkins on Hercules (NOAA-EMC#3423) Remove Direct Linking to COM from DATA for `extractvars` Job (NOAA-EMC#3379) Enable HPSS via Globus on Hercules and Orion Remove job name from product files & update GEMPAK module. (NOAA-EMC#3415) `link` instead of `copy` in staging jobs (NOAA-EMC#3410) Migrate CI Jenkins to role account on Hera (NOAA-EMC#3414) Add rocotorc documentation when using scrontab (NOAA-EMC#3417) Update jgdas atmos verfozn and verfrad with COMIN/COMOUT prefix instead of COM (NOAA-EMC#3342) Add configuration for empirically-corrected ozone parameters (NOAA-EMC#3386) Enable global-workflow to run C768C384 GSI on Gaea-C6 (NOAA-EMC#3412) Move logical checks into if blocks (NOAA-EMC#3339) Adding Jenkins CI to GaeaC6 using role account (NOAA-EMC#3389) Enable GDASApp g-w CI cases to run on wcoss2 (NOAA-EMC#3399) CI/CD Test on Gaea C5- And update config.gaea under ci/platform (NOAA-EMC#3280) Enable cycling support for Gaea C6 (NOAA-EMC#3323) Update enkf archive jobs to use COMIN/COMOUT (NOAA-EMC#3393) Copy marine ensemble output observation diags and spread (NOAA-EMC#3407) Ci testing on aws 2 (NOAA-EMC#3408) Disable METplus jobs on Hera (NOAA-EMC#3403) Add the mean EnKF soil increment to the deterministic member (NOAA-EMC#3295) Add mpich/8.1.19 to the WCOSS2 LD_LIBRARY_PATH for GDASApp jobs (NOAA-EMC#3396) Change order of RUNs (NOAA-EMC#3335) CI testing on aws (NOAA-EMC#3391) Rename Gulf of Mexico in bufr station list in GFSv17 (NOAA-EMC#3384) Enabling AWS CI/testing (NOAA-EMC#3383) Update issue templates to use new issue type field (NOAA-EMC#3369) Replace WAVECUR_DID variable with "rtofs" (NOAA-EMC#3337) Allow for C1152 ATM-Aero cycled DA to run on WCOSS2 (NOAA-EMC#3309) Remove Direct Linking to COM from DATA for `wavepostsbs` Job (NOAA-EMC#3303) Update jgdas enkf update job with COMIN or COMOUT prefix instead of COM (NOAA-EMC#3333) Add capability to run diff resolutions for marine anl and background (NOAA-EMC#3238) Update high resolution tests and fix minor wave issues (NOAA-EMC#3289) Add sfs as valid system (NOAA-EMC#3243) Add missing arch_tars dependencies (NOAA-EMC#3319) Fix the empty aerosol DA aerostat tar file issue (NOAA-EMC#3332) Add missing file safeguard for IMS prep in snow analysis tasks (NOAA-EMC#3329)

* develop: Update GSI hash and GSI fix version to resolve bugs (NOAA-EMC#3626) Add missing marine DA files to archiving (NOAA-EMC#3596) Add a low resolution test to mimic GFSv17 cycling as much as possible (NOAA-EMC#3617) Add the setting to use the reject list for station t/q observations in GSI based soil DA (NOAA-EMC#3599) GitLab CI Framework for schedule PR cases and ctests on multi hosts (NOAA-EMC#3603) Avoid parallel restart I/O on WCOSS2 (NOAA-EMC#3615) Enables user toggling of GDASApp g-w ctests (NOAA-EMC#3587) COM variable updates for prep and some external downstream jobs (NOAA-EMC#3608) Remove MOS from system (NOAA-EMC#3612) Updates to enable soil DA (NOAA-EMC#3452) Unexport SHELLOPTS when running htar (NOAA-EMC#3601) Fix check for netcdf wave restart (NOAA-EMC#3594) Call err_chk/err_exit for fatal errors in post JJobs/ex-scripts (NOAA-EMC#3571) Remove support for Jet and S4 (NOAA-EMC#3572) Hotfix in GitLab pipline for Nightly (env MACHINE breaks build on head node) (NOAA-EMC#3578) [hotfix] Missed a path during merging develop (NOAA-EMC#3577) Prepare for ops readiness - part 1 (NOAA-EMC#3557) Update UFS weather-model to 20250328 hash (NOAA-EMC#3528) Fix SFS fcst config (NOAA-EMC#3574) Use err_chk in GDAS j-jobs (NOAA-EMC#3570) Perform compute builds on Gaea head nodes (NOAA-EMC#3560) Add initial capability to produce JEDI-based observation space summary stat files (NOAA-EMC#3471) Spread epos over more nodes on Hera to increase allocated memory (NOAA-EMC#3567) Create separate gists when multiple files are published on GitHub (NOAA-EMC#3551) Use err_chk in GSI J-Jobs and scripts (NOAA-EMC#3549) Add unified jinja obs list to marine DA (NOAA-EMC#3530) Save snow and aerosol analysis increments (and logs and YAMLs) every cycle (NOAA-EMC#3537) Add Dependencies to SFS Cleanup Job (NOAA-EMC#3559) Updates archiving to reflect current naming of marine anl output (NOAA-EMC#3541) Temporarily disable compute builds on C6 (NOAA-EMC#3558) Update gdas.cd hash to resolve msu prod_util failure (NOAA-EMC#3556) COMIN/COMOUT updates for enkf chgres and downstream product jobs (NOAA-EMC#3518) Call err_chk in forecast scripts for fatal errors (NOAA-EMC#3515) Add Rocoto Jobs for the Missing Products of GEFS (NOAA-EMC#3466) Download subset fix data with python script (NOAA-EMC#3400) Check that partition should be set (NOAA-EMC#3543) Rename wave output and refactor some wave scripts to use MPMD, and fix some bugzillas along the way (NOAA-EMC#3517) Add support for dual batch partitions on AWS NOAA-EMC#3483 Update CI build and run directories for GitLab Nightlies on C6 and added GitLab support on Hera (NOAA-EMC#3536) Hotfix path for CI in Jenkins on Gaea C6 to it's world-share path (NOAA-EMC#3532) Create single ocean grib2 product file (NOAA-EMC#3529) Scheduled Nightly CI/CD Pipeline Script in GitLab on Gaea C6 (NOAA-EMC#3493) make sure cold starts are handled correctly when DOIAU=YES (issue NOAA-EMC#3516) (NOAA-EMC#3520) Add check for DO_AERO_FCST before copying fv_tracer files (NOAA-EMC#3485) Use jinja templates instead of `@VARNAME@` in config files (NOAA-EMC#3411) Replace "status" (or comparable) with "err" in preparation for moving to err_chk/err_exit (NOAA-EMC#3507) Error in Java launch script for CI (NOAA-EMC#3465) Delete DATAROOT when running generate_workflows.sh (NOAA-EMC#3504) Fix 3244 garbled change (NOAA-EMC#3492) Enable ensemble archiving via Globus (NOAA-EMC#3479) Update MSU FIX_DIR paths (NOAA-EMC#3488) Updates for AOWCDA and hybatmaerosnowDA cases on Gaea C6 (NOAA-EMC#3487) Update GOCART path for GDAS/GFS/GCAFS implementations (NOAA-EMC#3455) Make RUN Variables Explicit in `config.resources` (NOAA-EMC#3478) Remove unused key from enkfgdas_earc_vrfy (NOAA-EMC#3473) Bug fix to the failing early cycle marine DA ensemble re-centering (NOAA-EMC#3454) Make marine LETKF optional (NOAA-EMC#3462) When sourcing for RUN=enkf*, use CASE_ENS (NOAA-EMC#3475) Updates for Gaea: verif-global tag, tracker tag, Fit2Obs tag, and C768 analysis resources (NOAA-EMC#3463) Update gefswave glo_025 mesh file with new mask (NOAA-EMC#3457) Update MSU glopara paths to new role-global space (NOAA-EMC#3443) Enable CI testing on AWS (NOAA-EMC#3459) Enable Gaea C5 Jenkins CI (NOAA-EMC#3447) Job reference removal from WMO product names (NOAA-EMC#3460) Turn off aerosol prognostic radiative feedback for GDAS NOAA-EMC#2926 (NOAA-EMC#3445) Add DO_GEMPAK check to postsnd subtask (NOAA-EMC#3451) Add a force option to setup_xml to ignore unwritable directories (NOAA-EMC#3448) Remove the eomg job (NOAA-EMC#3331) Migration to role account for Jenkins on Orion (NOAA-EMC#3440) Eliminate `_gfs`, `_gdas`, etc, variables and add necessary if blocks (NOAA-EMC#3420) Update workflow staging for sfcanl tiles and waveinit (NOAA-EMC#3429) Improve messaging to display clear warning when missing snogrb file (NOAA-EMC#3317) JEDI-based ensemble recentering and analysis calculation (NOAA-EMC#3312) Enable HPSS archiving on C5/6 (NOAA-EMC#3437) Check if HOMEDIR STMP and PTMP are writable (NOAA-EMC#3430) Update UFS_Utils and GFS-utils hashes to update Gaea support and ocean/ice post products (NOAA-EMC#3433) Enable C1152 forecasts on gaea C6 (NOAA-EMC#3438) Migration to role account for Jenkins on Hercules (NOAA-EMC#3423) Remove Direct Linking to COM from DATA for `extractvars` Job (NOAA-EMC#3379) Enable HPSS via Globus on Hercules and Orion Remove job name from product files & update GEMPAK module. (NOAA-EMC#3415) `link` instead of `copy` in staging jobs (NOAA-EMC#3410) Migrate CI Jenkins to role account on Hera (NOAA-EMC#3414) Add rocotorc documentation when using scrontab (NOAA-EMC#3417) Update jgdas atmos verfozn and verfrad with COMIN/COMOUT prefix instead of COM (NOAA-EMC#3342) Add configuration for empirically-corrected ozone parameters (NOAA-EMC#3386) Enable global-workflow to run C768C384 GSI on Gaea-C6 (NOAA-EMC#3412) Move logical checks into if blocks (NOAA-EMC#3339) Adding Jenkins CI to GaeaC6 using role account (NOAA-EMC#3389) Enable GDASApp g-w CI cases to run on wcoss2 (NOAA-EMC#3399) CI/CD Test on Gaea C5- And update config.gaea under ci/platform (NOAA-EMC#3280) Enable cycling support for Gaea C6 (NOAA-EMC#3323) Update enkf archive jobs to use COMIN/COMOUT (NOAA-EMC#3393) Copy marine ensemble output observation diags and spread (NOAA-EMC#3407) Ci testing on aws 2 (NOAA-EMC#3408) Disable METplus jobs on Hera (NOAA-EMC#3403) Add the mean EnKF soil increment to the deterministic member (NOAA-EMC#3295) Add mpich/8.1.19 to the WCOSS2 LD_LIBRARY_PATH for GDASApp jobs (NOAA-EMC#3396) Change order of RUNs (NOAA-EMC#3335) CI testing on aws (NOAA-EMC#3391) Rename Gulf of Mexico in bufr station list in GFSv17 (NOAA-EMC#3384) Enabling AWS CI/testing (NOAA-EMC#3383) Update issue templates to use new issue type field (NOAA-EMC#3369) Replace WAVECUR_DID variable with "rtofs" (NOAA-EMC#3337) Allow for C1152 ATM-Aero cycled DA to run on WCOSS2 (NOAA-EMC#3309) Remove Direct Linking to COM from DATA for `wavepostsbs` Job (NOAA-EMC#3303) Update jgdas enkf update job with COMIN or COMOUT prefix instead of COM (NOAA-EMC#3333) Add capability to run diff resolutions for marine anl and background (NOAA-EMC#3238) Update high resolution tests and fix minor wave issues (NOAA-EMC#3289) Add sfs as valid system (NOAA-EMC#3243) Add missing arch_tars dependencies (NOAA-EMC#3319) Fix the empty aerosol DA aerostat tar file issue (NOAA-EMC#3332) Add missing file safeguard for IMS prep in snow analysis tasks (NOAA-EMC#3329) Fix memory unsetting on Gaea (NOAA-EMC#3325) Fix error log parsing in compute build CI (NOAA-EMC#3301) Remove marineanlvrfy task from global-workflow (NOAA-EMC#3314) Add `gfs_wavepostpnt` dependencies to gfs_cleanup (NOAA-EMC#3313) Increase the GDASApp build wallclock (NOAA-EMC#3298) Capture build fail in Jenkins pipeline when no error logs are produced (NOAA-EMC#3297) Add/update config files for Gaea and check existence before sourcing config files in generate_workflows.sh (NOAA-EMC#3286) Fix ocean restarts when cold starting with DOIAU=YES (NOAA-EMC#3278) Splitting up the archive task (NOAA-EMC#3242) CTests extended validation for C48_ATM and staged C48_S2SW for gfs_fcst and gfs_atmos (NOAA-EMC#3256) Add esnowanl to enkfgfs cycle (NOAA-EMC#3283) Add gfs cycles to C48mx500_3DVarAOWCDA (NOAA-EMC#3249) Add fetch job and update stage_ic to work with fetched ICs (NOAA-EMC#3141) Remove WAFS files and references from `develop` (NOAA-EMC#3263) fix intel stack version number on c5 (NOAA-EMC#3258) Update gsi_monitor and ufs_utils hashes to recent hashes for C5/C6 build and run (NOAA-EMC#3252) Enable DA cycling on gaea C5/C6 (NOAA-EMC#3255) Copy post-processed sea ice increment for diagnostics (NOAA-EMC#3235)

KateFriedman-NOAA added 3 commits February 11, 2025 15:43

Improve messaging for snogrb setting

28c5fb3

- Add INFO echo to state which snogrb file will be used in log - Also fix bug with res setting in exgdas_enkf_sfc.sh Resolves bugzilla 1373 Refs NOAA-EMC#2500

Add FATAL ERROR exit and update COM variables

dad2758

- Add "FATAL ERROR" message if either snogrb file is missing. - Update COMIN/COMOUT variable settings (needed) Refs NOAA-EMC#2500

Move new INFO message inside if-block

e6c5e05

Combine the INFO and FATAL ERROR messaging for snogrb files into the same if-block. Refs NOAA-EMC#2500

KateFriedman-NOAA requested review from DavidHuber-NOAA, WalterKolczynski-NOAA and aerorahul February 11, 2025 19:38

KateFriedman-NOAA requested review from CatherineThomas-NOAA, CoryMartin-NOAA, GeorgeGayno-NOAA and RussTreadon-NOAA as code owners February 11, 2025 19:38

github-advanced-security AI found potential problems Feb 11, 2025

View reviewed changes

Comment thread scripts/exglobal_atmos_sfcanl.sh Fixed

Comment thread scripts/exglobal_atmos_sfcanl.sh Fixed

Comment thread scripts/exglobal_atmos_sfcanl.sh Fixed

Comment thread scripts/exglobal_atmos_sfcanl.sh Fixed

Resolve shellcheck warnings

5a55a10

Refs NOAA-EMC#2500

CoryMartin-NOAA reviewed Feb 11, 2025

View reviewed changes

Update new snow file messaging to clarify cycle

500aeca

Refs NOAA-EMC#2500

CoryMartin-NOAA previously approved these changes Feb 11, 2025

View reviewed changes

WalterKolczynski-NOAA requested changes Feb 12, 2025

View reviewed changes

Comment thread scripts/exgdas_enkf_sfc.sh Outdated

Comment thread scripts/exgdas_enkf_sfc.sh Outdated

Comment thread scripts/exglobal_atmos_sfcanl.sh

Merge branch 'NOAA-EMC:develop' into feature/bugzilla_1373

742e376

KateFriedman-NOAA added 2 commits February 19, 2025 13:36

Merge branch 'NOAA-EMC:develop' into feature/bugzilla_1373

134ba21

Merge branch 'NOAA-EMC:develop' into feature/bugzilla_1373

80ab616

Merge branch 'NOAA-EMC:develop' into feature/bugzilla_1373

bfd9ff4

KateFriedman-NOAA added 2 commits February 25, 2025 12:05

Merge branch 'NOAA-EMC:develop' into feature/bugzilla_1373

d3c197f

Merge branch 'NOAA-EMC:develop' into feature/bugzilla_1373

caf08c1

KateFriedman-NOAA dismissed CoryMartin-NOAA’s stale review via 6de1f91 March 10, 2025 18:15

KateFriedman-NOAA requested review from JessicaMeixner-NOAA and sbanihash as code owners March 10, 2025 18:15

KateFriedman-NOAA requested a review from CoryMartin-NOAA March 10, 2025 18:18

JessicaMeixner-NOAA previously approved these changes Mar 10, 2025

View reviewed changes

DavidHuber-NOAA requested changes Mar 12, 2025

View reviewed changes

Comment thread scripts/exglobal_atmos_sfcanl.sh

Comment thread scripts/exglobal_atmos_sfcanl.sh Outdated

Comment thread scripts/exglobal_atmos_sfcanl.sh

Change FATAL to WARNING

135930b

Refs NOAA-EMC#2500

KateFriedman-NOAA dismissed JessicaMeixner-NOAA’s stale review via 135930b March 12, 2025 15:58

KateFriedman-NOAA requested a review from DavidHuber-NOAA March 12, 2025 16:03

Merge branch 'NOAA-EMC:develop' into feature/bugzilla_1373

1a3a727

Merge branch 'NOAA-EMC:develop' into feature/bugzilla_1373

2cd7d9f

Merge branch 'develop' into feature/bugzilla_1373

c2d77ea

DavidHuber-NOAA approved these changes Mar 14, 2025

View reviewed changes

KateFriedman-NOAA merged commit 8e70ec4 into NOAA-EMC:develop Mar 14, 2025

KateFriedman-NOAA deleted the feature/bugzilla_1373 branch March 14, 2025 14:25

Conversation

KateFriedman-NOAA commented Feb 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

Change characteristics

How has this been tested?

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

GeorgeGayno-NOAA commented Feb 12, 2025

Uh oh!

KateFriedman-NOAA commented Feb 12, 2025

Uh oh!

GeorgeGayno-NOAA commented Feb 12, 2025

Uh oh!

KateFriedman-NOAA commented Feb 12, 2025

Uh oh!

GeorgeGayno-NOAA commented Feb 12, 2025

Uh oh!

KateFriedman-NOAA commented Feb 14, 2025

Uh oh!

KateFriedman-NOAA commented Feb 24, 2025

Uh oh!

GeorgeGayno-NOAA commented Feb 24, 2025

Uh oh!

JessicaMeixner-NOAA left a comment

Choose a reason for hiding this comment

Uh oh!

KateFriedman-NOAA commented Mar 10, 2025

Uh oh!

GeorgeGayno-NOAA commented Mar 10, 2025

Uh oh!

DavidHuber-NOAA left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DavidHuber-NOAA commented Mar 12, 2025

Uh oh!

GeorgeGayno-NOAA commented Mar 12, 2025

Uh oh!

KateFriedman-NOAA commented Mar 13, 2025

Uh oh!

GeorgeGayno-NOAA commented Mar 13, 2025

Uh oh!

KateFriedman-NOAA commented Mar 13, 2025

Uh oh!

KateFriedman-NOAA commented Mar 13, 2025

Uh oh!

GeorgeGayno-NOAA commented Mar 13, 2025

Uh oh!

KateFriedman-NOAA commented Mar 14, 2025

Uh oh!

GeorgeGayno-NOAA commented Mar 14, 2025

Uh oh!

KateFriedman-NOAA commented Mar 14, 2025

Uh oh!

DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

Uh oh!

DavidHuber-NOAA commented Mar 14, 2025

KateFriedman-NOAA commented Feb 11, 2025 •

edited

Loading

DavidHuber-NOAA left a comment •

edited

Loading