Skip to content

Update GSI hash and GSI fix version to resolve bugs#3626

Merged
KateFriedman-NOAA merged 1 commit into
NOAA-EMC:developfrom
KateFriedman-NOAA:hotfix/gsi_hash_update
May 1, 2025
Merged

Update GSI hash and GSI fix version to resolve bugs#3626
KateFriedman-NOAA merged 1 commit into
NOAA-EMC:developfrom
KateFriedman-NOAA:hotfix/gsi_hash_update

Conversation

@KateFriedman-NOAA
Copy link
Copy Markdown
Contributor

Description

This PR resolves issues reported in bug issue #3625. The resolution includes:

  • new GSI hash (d635cb9)
  • update gsi_ver=20250430

Resolves #3625
Refs #3546

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? YES

How has this been tested?

@RussTreadon-NOAA reran failed analysis job on Hercules with updated GSI hash and reported successful completion of job (NOAA-EMC/GSI#870 (comment))

- new GSI hash d635cb9
- update gsi_ver=20250430

Refs NOAA-EMC#3625
Refs NOAA-EMC#3546
@KateFriedman-NOAA KateFriedman-NOAA added the bug Something isn't working label Apr 30, 2025
@KateFriedman-NOAA KateFriedman-NOAA self-assigned this Apr 30, 2025
@KateFriedman-NOAA KateFriedman-NOAA added the CI-Wcoss2-Ready PR is ready for CI testing on WCOSS2. label Apr 30, 2025
@emcbot emcbot added CI-Wcoss2-Building CI testing is cloning/building on WCOSS2 and removed CI-Wcoss2-Ready PR is ready for CI testing on WCOSS2. labels Apr 30, 2025
@KateFriedman-NOAA
Copy link
Copy Markdown
Contributor Author

@CoryMartin-NOAA @RussTreadon-NOAA are there any other changes in the GSI code that come with this new hash that we should note?

@emcbot emcbot added CI-Wcoss2-Running CI testing on WCOSS for this PR is in-progress and removed CI-Wcoss2-Building CI testing is cloning/building on WCOSS2 labels Apr 30, 2025
@emcbot
Copy link
Copy Markdown

emcbot commented Apr 30, 2025

CI Tests set up to run in /lfs/h2/emc/ptmp/emc.global/PR/PR_3626/RUNTESTS on WCOSS

@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor

Currently g-w develop uses gsi_enkf.fd @ 0912493. This PR updates to gsi_enkf.fd @ d635cb9. There are two GSI commits between these to hashes, GSI PRs #863 and #868. Both of these PRs (commits) are for the RTMA.

Copy link
Copy Markdown
Contributor

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve.

@KateFriedman-NOAA
Copy link
Copy Markdown
Contributor Author

WCOSS2 CI completed successfully (although a gempak job hit it's walltime again in the extended test, will look into that outside of this PR. Rerunning the gempak job in question now to get it to complete.).

Thu May  1 12:45:28 UTC 2025
******** C48_ATM_3626 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103231200        Done    Apr 30 2025 21:46:18    Apr 30 2025 23:01:27

******** C48mx500_3DVarAOWCDA_3626 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103241800        Done    Apr 30 2025 21:46:21    Apr 30 2025 22:06:16
202103250000        Done    Apr 30 2025 21:46:21    Apr 30 2025 23:41:13

******** C48mx500_hybAOWCDA_3626 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103241800        Done    Apr 30 2025 21:46:25    Apr 30 2025 22:06:22
202103250000        Done    Apr 30 2025 21:46:25    Apr 30 2025 23:16:17

******** C48_S2SW_3626 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103231200        Done    Apr 30 2025 21:46:28    Apr 30 2025 23:01:40

******** C48_S2SWA_gefs_3626 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103231200        Done    Apr 30 2025 21:46:30    Apr 30 2025 23:11:30

******** C96_atm3DVar_extended_3626 ********
202112210000    gfs_gempak_f123-f144    druby://clogin01.cactus.wcoss2.ncep.noaa.gov:44385          SUBMITTING                   -         3           0.0

******** C96C48_hybatmaerosnowDA_3626 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201200        Done    Apr 30 2025 21:46:38    Apr 30 2025 22:12:11
202112201800        Done    Apr 30 2025 21:46:38    May 01 2025 00:16:42
202112210000        Done    Apr 30 2025 21:46:38    May 01 2025 00:06:18

******** C96C48_hybatmDA_3626 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201800        Done    Apr 30 2025 21:46:43    Apr 30 2025 22:06:56
202112210000        Done    Apr 30 2025 21:46:43    May 01 2025 00:11:41
202112210600        Done    Apr 30 2025 21:46:43    May 01 2025 00:01:35

******** C96C48mx500_S2SW_cyc_gfs_3626 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201200        Done    Apr 30 2025 21:46:48    Apr 30 2025 22:07:11
202112201800        Done    Apr 30 2025 21:46:48    May 01 2025 00:11:45
202112210000        Done    Apr 30 2025 21:46:48    May 01 2025 01:21:53
202112211800        Done    Apr 30 2025 22:12:17    May 01 2025 01:21:53

******** C96C48_ufs_hybatmDA_3626 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202402231800        Done    Apr 30 2025 21:46:52    Apr 30 2025 22:07:22
202402240000        Done    Apr 30 2025 21:46:52    May 01 2025 00:41:36
202402240600        Done    Apr 30 2025 21:46:52    May 01 2025 00:26:38

******** C96mx100_S2S_3626 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
199405010000        Done    Apr 30 2025 21:46:56    Apr 30 2025 23:21:44

A check of the fix/gsi/20250430/rejectlist_global.txt file shows the timestamp is unchanged from the one it had after being added to the developmental fix set:

WCOSS2 (BACKUPSYS-C) FIX> ll fix/gsi/20250430/rejectlist_global.txt
-rw-r--r-- 1 emc.global global 58 Apr 30 18:37 fix/gsi/20250430/rejectlist_global.txt

@CoryMartin-NOAA @RussTreadon-NOAA @jiaruidong2017 did you want to look at the CI output on WCOSS2 before this gets merged?

@KateFriedman-NOAA KateFriedman-NOAA added CI-Wcoss2-Passed CI testing on WCOSS for this PR has completed successfully and removed CI-Wcoss2-Running CI testing on WCOSS for this PR is in-progress labels May 1, 2025
@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor

A check of gdas_anal.log for the 20211221 06Z from C96C48_hybatmDA_3626 shows

+ exglobal_atmos_analysis.sh[302]BLACKLST=/lfs/h2/emc/ptmp/emc.global/PR/PR_3626/global-workflow/fix/gsi/rejectlist_global.txt
+ exglobal_atmos_analysis.sh[376]/bin/ln -sf /lfs/h2/emc/ptmp/emc.global/PR/PR_3626/global-workflow/fix/gsi/rejectlist_global.txt blacklist

File rejectlist_global.txt exists and contains

!IOTYPE  ikx stn_id
 t       181 71464
 q       181 71464

When gsi.x runs we see the following in the run time output

BLACKLST        = T,

...

nid002101.cactus.wcoss2.ncep.noaa.gov 79:  READ_PREPBUFR: blacklist station 71464   for obstype t and kx=         181
nid002101.cactus.wcoss2.ncep.noaa.gov 79:  READ_PREPBUFR: blacklist station 71464   for obstype t and kx=         181

...

nid002101.cactus.wcoss2.ncep.noaa.gov 81:  READ_PREPBUFR: blacklist station 71464   for obstype q and kx=         181
nid002101.cactus.wcoss2.ncep.noaa.gov 81:  READ_PREPBUFR: blacklist station 71464   for obstype q and kx=         181

It's interesting that the blacklist station message is written twice. Not a big deal but we don't need the same message printed twice. @jiaruidong2017 , we should clean this up in a future GSI PR.

@CoryMartin-NOAA
Copy link
Copy Markdown
Contributor

@RussTreadon-NOAA I think that it depends on what processor(s) read in those station IDs, so it might not be easy to do

@KateFriedman-NOAA
Copy link
Copy Markdown
Contributor Author

@RussTreadon-NOAA thanks for taking a look at the CI output for this PR on WCOSS2 and reporting what you see.

If there are no objections from anyone, I will merge this at 9:30am ET. Thanks all!

@KateFriedman-NOAA KateFriedman-NOAA merged commit 85bed5f into NOAA-EMC:develop May 1, 2025
5 checks passed
@KateFriedman-NOAA KateFriedman-NOAA deleted the hotfix/gsi_hash_update branch May 1, 2025 13:31
@KateFriedman-NOAA
Copy link
Copy Markdown
Contributor Author

The extended test completed successfully after the noted gempak job was resubmitted:

******** C96_atm3DVar_extended_3626 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201800        Done    Apr 30 2025 21:46:35    Apr 30 2025 22:06:43
202112210000        Done    Apr 30 2025 21:46:35    May 01 2025 13:21:06
202112210600        Done    Apr 30 2025 21:46:35    May 01 2025 03:11:30
202112211200        Done    Apr 30 2025 22:12:05    May 01 2025 03:56:21
202112211800        Done    May 01 2025 03:16:28    May 01 2025 08:26:03

tsga added a commit to tsga/global-workflow that referenced this pull request May 1, 2025
* develop:
  Update GSI hash and GSI fix version to resolve bugs (NOAA-EMC#3626)
  Add missing marine DA files to archiving  (NOAA-EMC#3596)
  Add a low resolution test to mimic GFSv17 cycling as much as possible (NOAA-EMC#3617)
  Add the setting to use the reject list for station t/q observations in GSI based soil DA (NOAA-EMC#3599)
  GitLab CI Framework for schedule PR cases and ctests on multi hosts (NOAA-EMC#3603)
  Avoid parallel restart I/O on WCOSS2 (NOAA-EMC#3615)
  Enables user toggling of GDASApp g-w ctests (NOAA-EMC#3587)
  COM variable updates for prep and some external downstream jobs (NOAA-EMC#3608)
  Remove MOS from system (NOAA-EMC#3612)
  Updates to enable soil DA  (NOAA-EMC#3452)
  Unexport SHELLOPTS when running htar (NOAA-EMC#3601)
  Fix check for netcdf wave restart (NOAA-EMC#3594)
  Call err_chk/err_exit for fatal errors in post JJobs/ex-scripts (NOAA-EMC#3571)
  Remove support for Jet and S4 (NOAA-EMC#3572)
  Hotfix in GitLab pipline for Nightly (env MACHINE breaks build on head node) (NOAA-EMC#3578)
  [hotfix] Missed a path during merging develop (NOAA-EMC#3577)
  Prepare for ops readiness - part 1 (NOAA-EMC#3557)
  Update UFS weather-model to 20250328 hash (NOAA-EMC#3528)
  Fix SFS fcst config (NOAA-EMC#3574)
  Use err_chk in GDAS j-jobs (NOAA-EMC#3570)
  Perform compute builds on Gaea head nodes (NOAA-EMC#3560)
  Add initial capability to produce JEDI-based observation space summary stat files (NOAA-EMC#3471)
  Spread epos over more nodes on Hera to increase allocated memory (NOAA-EMC#3567)
  Create separate gists when multiple files are published on GitHub (NOAA-EMC#3551)
  Use err_chk in GSI J-Jobs and scripts (NOAA-EMC#3549)
  Add unified jinja obs list to marine DA (NOAA-EMC#3530)
  Save snow and aerosol analysis increments (and logs and YAMLs) every cycle (NOAA-EMC#3537)
  Add Dependencies to SFS Cleanup Job (NOAA-EMC#3559)
  Updates archiving to reflect current naming of marine anl output (NOAA-EMC#3541)
  Temporarily disable compute builds on C6 (NOAA-EMC#3558)
  Update gdas.cd hash to resolve msu prod_util failure (NOAA-EMC#3556)
  COMIN/COMOUT updates for enkf chgres and downstream product jobs (NOAA-EMC#3518)
  Call err_chk in forecast scripts for fatal errors (NOAA-EMC#3515)
  Add Rocoto Jobs for the Missing Products of GEFS (NOAA-EMC#3466)
  Download subset fix data with python script (NOAA-EMC#3400)
  Check that partition should be set (NOAA-EMC#3543)
  Rename wave output and refactor some wave scripts to use MPMD, and fix some bugzillas along the way (NOAA-EMC#3517)
  Add support for dual batch partitions on AWS NOAA-EMC#3483
  Update CI build and run directories for GitLab Nightlies on C6 and added GitLab support on Hera (NOAA-EMC#3536)
  Hotfix path for CI in Jenkins on Gaea C6 to it's world-share path (NOAA-EMC#3532)
  Create single ocean grib2 product file (NOAA-EMC#3529)
  Scheduled Nightly CI/CD Pipeline Script in GitLab on Gaea C6 (NOAA-EMC#3493)
  make sure cold starts are handled correctly when DOIAU=YES (issue NOAA-EMC#3516) (NOAA-EMC#3520)
  Add check for DO_AERO_FCST before copying fv_tracer files (NOAA-EMC#3485)
  Use jinja templates instead of `@VARNAME@` in config files (NOAA-EMC#3411)
  Replace "status" (or comparable) with "err" in preparation for moving to err_chk/err_exit (NOAA-EMC#3507)
  Error in Java launch script for CI (NOAA-EMC#3465)
  Delete DATAROOT when running generate_workflows.sh (NOAA-EMC#3504)
  Fix 3244 garbled change (NOAA-EMC#3492)
  Enable ensemble archiving via Globus (NOAA-EMC#3479)
  Update MSU FIX_DIR paths (NOAA-EMC#3488)
  Updates for AOWCDA and hybatmaerosnowDA cases on Gaea C6 (NOAA-EMC#3487)
  Update GOCART path for GDAS/GFS/GCAFS implementations  (NOAA-EMC#3455)
  Make RUN Variables Explicit in `config.resources` (NOAA-EMC#3478)
  Remove unused key from enkfgdas_earc_vrfy (NOAA-EMC#3473)
  Bug fix to the failing early cycle marine DA ensemble re-centering (NOAA-EMC#3454)
  Make marine LETKF optional (NOAA-EMC#3462)
  When sourcing for RUN=enkf*, use CASE_ENS (NOAA-EMC#3475)
  Updates for Gaea: verif-global tag, tracker tag, Fit2Obs tag, and C768 analysis resources (NOAA-EMC#3463)
  Update gefswave glo_025 mesh file with new mask (NOAA-EMC#3457)
  Update MSU glopara paths to new role-global space (NOAA-EMC#3443)
  Enable CI testing on AWS (NOAA-EMC#3459)
  Enable Gaea C5 Jenkins CI (NOAA-EMC#3447)
  Job reference removal from WMO product names (NOAA-EMC#3460)
  Turn off aerosol prognostic radiative feedback for GDAS NOAA-EMC#2926 (NOAA-EMC#3445)
  Add DO_GEMPAK check to postsnd subtask (NOAA-EMC#3451)
  Add a force option to setup_xml to ignore unwritable directories (NOAA-EMC#3448)
  Remove the eomg job (NOAA-EMC#3331)
  Migration to role account for Jenkins on Orion (NOAA-EMC#3440)
  Eliminate `_gfs`, `_gdas`, etc, variables and add necessary if blocks (NOAA-EMC#3420)
  Update workflow staging for sfcanl tiles and waveinit (NOAA-EMC#3429)
  Improve messaging to display clear warning when missing snogrb file (NOAA-EMC#3317)
  JEDI-based ensemble recentering and analysis calculation (NOAA-EMC#3312)
  Enable HPSS archiving on C5/6 (NOAA-EMC#3437)
  Check if HOMEDIR STMP and PTMP are writable (NOAA-EMC#3430)
  Update UFS_Utils and GFS-utils hashes to update Gaea support and ocean/ice post products (NOAA-EMC#3433)
  Enable C1152 forecasts on gaea C6 (NOAA-EMC#3438)
  Migration to role account for Jenkins on Hercules (NOAA-EMC#3423)
  Remove Direct Linking to COM from DATA for `extractvars` Job (NOAA-EMC#3379)
  Enable HPSS via Globus on Hercules and Orion
  Remove job name from product files & update GEMPAK module. (NOAA-EMC#3415)
  `link` instead of `copy` in staging jobs (NOAA-EMC#3410)
  Migrate CI Jenkins to role account on Hera (NOAA-EMC#3414)
  Add rocotorc documentation when using scrontab (NOAA-EMC#3417)
  Update jgdas atmos verfozn and verfrad with COMIN/COMOUT prefix instead of COM (NOAA-EMC#3342)
  Add configuration for empirically-corrected ozone parameters (NOAA-EMC#3386)
  Enable global-workflow to run C768C384 GSI on Gaea-C6 (NOAA-EMC#3412)
  Move logical checks into if blocks (NOAA-EMC#3339)
  Adding Jenkins CI to GaeaC6 using role account (NOAA-EMC#3389)
  Enable GDASApp g-w CI cases to run on wcoss2 (NOAA-EMC#3399)
  CI/CD Test on Gaea C5- And update config.gaea under ci/platform (NOAA-EMC#3280)
  Enable cycling support for Gaea C6 (NOAA-EMC#3323)
  Update enkf archive jobs to use COMIN/COMOUT (NOAA-EMC#3393)
  Copy marine ensemble output observation diags and spread (NOAA-EMC#3407)
  Ci testing on aws 2 (NOAA-EMC#3408)
  Disable METplus jobs on Hera (NOAA-EMC#3403)
  Add the mean EnKF soil increment to the deterministic member (NOAA-EMC#3295)
  Add mpich/8.1.19 to the WCOSS2 LD_LIBRARY_PATH for GDASApp jobs (NOAA-EMC#3396)
  Change order of RUNs (NOAA-EMC#3335)
  CI testing on aws (NOAA-EMC#3391)
  Rename Gulf of Mexico in bufr station list in GFSv17 (NOAA-EMC#3384)
  Enabling AWS CI/testing (NOAA-EMC#3383)
  Update issue templates to use new issue type field (NOAA-EMC#3369)
  Replace WAVECUR_DID variable with "rtofs" (NOAA-EMC#3337)
  Allow for C1152 ATM-Aero cycled DA to run on WCOSS2 (NOAA-EMC#3309)
  Remove Direct Linking to COM from DATA for `wavepostsbs` Job (NOAA-EMC#3303)
  Update jgdas enkf update job with COMIN or COMOUT prefix instead of COM (NOAA-EMC#3333)
  Add capability to run diff resolutions for marine anl and background (NOAA-EMC#3238)
  Update high resolution tests and fix minor wave issues  (NOAA-EMC#3289)
  Add sfs as valid system (NOAA-EMC#3243)
  Add missing arch_tars dependencies (NOAA-EMC#3319)
  Fix the empty aerosol DA aerostat tar file issue (NOAA-EMC#3332)
  Add missing file safeguard for IMS prep in snow analysis tasks (NOAA-EMC#3329)
  Fix memory unsetting on Gaea (NOAA-EMC#3325)
  Fix error log parsing in compute build CI (NOAA-EMC#3301)
  Remove marineanlvrfy task from global-workflow (NOAA-EMC#3314)
  Add `gfs_wavepostpnt` dependencies to gfs_cleanup (NOAA-EMC#3313)
  Increase the GDASApp build wallclock (NOAA-EMC#3298)
  Capture build fail in Jenkins pipeline when no error logs are produced (NOAA-EMC#3297)
  Add/update config files for Gaea and check existence before sourcing config files in generate_workflows.sh (NOAA-EMC#3286)
  Fix ocean restarts when cold starting with DOIAU=YES (NOAA-EMC#3278)
  Splitting up the archive task (NOAA-EMC#3242)
  CTests extended validation for C48_ATM and staged C48_S2SW for gfs_fcst and gfs_atmos (NOAA-EMC#3256)
  Add esnowanl to enkfgfs cycle (NOAA-EMC#3283)
  Add gfs cycles to C48mx500_3DVarAOWCDA (NOAA-EMC#3249)
  Add fetch job and update stage_ic to work with fetched ICs (NOAA-EMC#3141)
  Remove WAFS files and references from `develop` (NOAA-EMC#3263)
  fix intel stack version number on c5 (NOAA-EMC#3258)
  Update gsi_monitor and ufs_utils hashes to recent hashes for C5/C6 build and run (NOAA-EMC#3252)
  Enable DA cycling on gaea C5/C6 (NOAA-EMC#3255)
  Copy post-processed sea ice increment for diagnostics (NOAA-EMC#3235)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working CI-Wcoss2-Passed CI testing on WCOSS for this PR has completed successfully

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Issues resulting from PR #3599 changes

5 participants