Skip to content

Add check for DO_AERO_FCST before copying fv_tracer files#3485

Merged
DavidHuber-NOAA merged 5 commits into
NOAA-EMC:developfrom
DavidGrumm-NOAA:aero_0
Mar 28, 2025
Merged

Add check for DO_AERO_FCST before copying fv_tracer files#3485
DavidHuber-NOAA merged 5 commits into
NOAA-EMC:developfrom
DavidGrumm-NOAA:aero_0

Conversation

@DavidGrumm-NOAA
Copy link
Copy Markdown
Contributor

@DavidGrumm-NOAA DavidGrumm-NOAA commented Mar 21, 2025 •
edited
Loading

Description

The forecast_postdet.sh script should not try to look for aerosol analysis files if there is no aerosol analysis to be done. It currently warns and doesn't fail, but the script should not try to copy aerosol analysis fv_tracer files if not necessary.

Resolves Issue #3360

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO
    • EMC verif-global
    • GDAS
    • GFS-utils
    • GSI
    • GSI-monitor
    • GSI-utils
    • UFS-utils
    • UFS-weather-model
    • wxflow

How has this been tested?

Successfully tested with C96C48_hybatmDA on Hera.

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

@DavidGrumm-NOAA DavidGrumm-NOAA self-assigned this Mar 21, 2025
DavidHuber-NOAA
DavidHuber-NOAA previously approved these changes Mar 21, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@DavidHuber-NOAA DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Noting this is a draft and testing is still ongoing. Approve pending successful test completion.

@DavidGrumm-NOAA
Copy link
Copy Markdown
Contributor Author

DavidGrumm-NOAA commented Mar 21, 2025 via email

@DavidGrumm-NOAA DavidGrumm-NOAA marked this pull request as ready for review March 21, 2025 14:17
@DavidGrumm-NOAA DavidGrumm-NOAA requested review from DavidHuber-NOAA and removed request for WalterKolczynski-NOAA March 21, 2025 14:17
@DavidHuber-NOAA
Copy link
Copy Markdown
Contributor

DavidHuber-NOAA commented Mar 21, 2025

@CoryMartin-NOAA Could you review this PR? Also, are there any other tests that should be run?

@CoryMartin-NOAA
Copy link
Copy Markdown
Contributor

CoryMartin-NOAA commented Mar 24, 2025

I think we need to double check this logic.

For GFSv17:
We should have an aerosol analysis performed for both the GFS and GDAS cycles.
We should only run an aerosol forecast for the GDAS forecast (the GFS analysis is for the external aerosol forecast GEFS/GCAFS to pick up).

I want to make sure this does not copy over the restart files for the GFS forecast, which would unnecessarily add time for I/O for that forecast. I'll look at the branch more closely before I request changes/approve.

@CoryMartin-NOAA
Copy link
Copy Markdown
Contributor

CoryMartin-NOAA commented Mar 24, 2025

@DavidGrumm-NOAA @DavidHuber-NOAA can we run the hybrid aerosol DA CI test just so I can see a log and confirm things are working as expected?

@DavidGrumm-NOAA
Copy link
Copy Markdown
Contributor Author

DavidGrumm-NOAA commented Mar 26, 2025

@CoryMartin-NOAA - I have run the C96C48_hybatmaerosnowDA case using the updated code. All tasks succeeded, and the results can be found in :
/scratch1/NCEPDEV/global/David.Grumm/EC_dirs_032625a_snow/EXPDIR/C96C48_hybatmaerosnowDA

@CoryMartin-NOAA
Copy link
Copy Markdown
Contributor

CoryMartin-NOAA commented Mar 26, 2025

Yes this is not 100% correct. See: /scratch1/NCEPDEV/global/David.Grumm/EC_dirs_032625a_snow/COMROOT/C96C48_hybatmaerosnowDA/logs/2021122018/gfs_fcst_seg0.log

On line 1999 it is checking if DO_AERO_ANL is YES, which it is for the GFS cycle, but we don't want it to copy the aerosol restart files. I think it should be checking DO_AERO_FCST instead in this section to decide if the modified RESTART files should be copied.

@DavidGrumm-NOAA
Copy link
Copy Markdown
Contributor Author

DavidGrumm-NOAA commented Mar 26, 2025 via email

@DavidGrumm-NOAA
Copy link
Copy Markdown
Contributor Author

DavidGrumm-NOAA commented Mar 27, 2025

I have not yet tested the DO_AERO_FCST code update; will test it 3/27/25

@DavidHuber-NOAA DavidHuber-NOAA changed the title Add check for DO_AERO_ANL before copying fv_tracer files Add check for DO_AERO_FCST before copying fv_tracer files Mar 27, 2025
@DavidGrumm-NOAA
Copy link
Copy Markdown
Contributor Author

DavidGrumm-NOAA commented Mar 27, 2025

@CoryMartin-NOAA - Following your suggestion, in forecast_postdet.sh I replaced the check for DO_AERO_ANL with a check for DO_AERO_FCST. With the updated code I reran the C96C48_hybatmaerosnowDA case. All tasks succeeded, and the results can be found in :
/scratch1/NCEPDEV/global/David.Grumm/EC_dirs_032725a_snow/EXPDIR/C96C48_hybatmaerosnowDA

CoryMartin-NOAA
CoryMartin-NOAA approved these changes Mar 28, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logs look correct now, thanks!

DavidHuber-NOAA
DavidHuber-NOAA approved these changes Mar 28, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@DavidHuber-NOAA DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DavidGrumm-NOAA! Approve and merge.

@DavidGrumm-NOAA
Copy link
Copy Markdown
Contributor Author

DavidGrumm-NOAA commented Mar 28, 2025

With this latest updated code I reran the C96C48_hybatmDA case. All tasks succeeded, and the results can be found in :
/scratch1/NCEPDEV/global/David.Grumm/EC_dirs_032725b_hybatmDA/EXPDIR/C96C48_hybatmDA. That completes the planned testing for the latest code update.

@DavidHuber-NOAA DavidHuber-NOAA merged commit 9051c07 into NOAA-EMC:develop Mar 28, 2025
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this pull request Mar 31, 2025
@KateFriedman-NOAA
Merge remote-tracking branch 'origin/develop' into feature/comin_comout
082f0e2 
* origin/develop:
  Create single ocean grib2 product file (NOAA-EMC#3529)
  Scheduled Nightly CI/CD Pipeline Script in GitLab on Gaea C6 (NOAA-EMC#3493)
  make sure cold starts are handled correctly when DOIAU=YES (issue NOAA-EMC#3516) (NOAA-EMC#3520)
  Add check for DO_AERO_FCST before copying fv_tracer files (NOAA-EMC#3485)
  Use jinja templates instead of `@VARNAME@` in config files (NOAA-EMC#3411)
  Replace "status" (or comparable) with "err" in preparation for moving to err_chk/err_exit (NOAA-EMC#3507)
@aerorahul aerorahul mentioned this pull request Mar 31, 2025
Closed
tsga added a commit to tsga/global-workflow that referenced this pull request May 1, 2025
@tsga
Merge branch 'develop' into feature/land_iau
ad208da 
* develop:
  Update GSI hash and GSI fix version to resolve bugs (NOAA-EMC#3626)
  Add missing marine DA files to archiving  (NOAA-EMC#3596)
  Add a low resolution test to mimic GFSv17 cycling as much as possible (NOAA-EMC#3617)
  Add the setting to use the reject list for station t/q observations in GSI based soil DA (NOAA-EMC#3599)
  GitLab CI Framework for schedule PR cases and ctests on multi hosts (NOAA-EMC#3603)
  Avoid parallel restart I/O on WCOSS2 (NOAA-EMC#3615)
  Enables user toggling of GDASApp g-w ctests (NOAA-EMC#3587)
  COM variable updates for prep and some external downstream jobs (NOAA-EMC#3608)
  Remove MOS from system (NOAA-EMC#3612)
  Updates to enable soil DA  (NOAA-EMC#3452)
  Unexport SHELLOPTS when running htar (NOAA-EMC#3601)
  Fix check for netcdf wave restart (NOAA-EMC#3594)
  Call err_chk/err_exit for fatal errors in post JJobs/ex-scripts (NOAA-EMC#3571)
  Remove support for Jet and S4 (NOAA-EMC#3572)
  Hotfix in GitLab pipline for Nightly (env MACHINE breaks build on head node) (NOAA-EMC#3578)
  [hotfix] Missed a path during merging develop (NOAA-EMC#3577)
  Prepare for ops readiness - part 1 (NOAA-EMC#3557)
  Update UFS weather-model to 20250328 hash (NOAA-EMC#3528)
  Fix SFS fcst config (NOAA-EMC#3574)
  Use err_chk in GDAS j-jobs (NOAA-EMC#3570)
  Perform compute builds on Gaea head nodes (NOAA-EMC#3560)
  Add initial capability to produce JEDI-based observation space summary stat files (NOAA-EMC#3471)
  Spread epos over more nodes on Hera to increase allocated memory (NOAA-EMC#3567)
  Create separate gists when multiple files are published on GitHub (NOAA-EMC#3551)
  Use err_chk in GSI J-Jobs and scripts (NOAA-EMC#3549)
  Add unified jinja obs list to marine DA (NOAA-EMC#3530)
  Save snow and aerosol analysis increments (and logs and YAMLs) every cycle (NOAA-EMC#3537)
  Add Dependencies to SFS Cleanup Job (NOAA-EMC#3559)
  Updates archiving to reflect current naming of marine anl output (NOAA-EMC#3541)
  Temporarily disable compute builds on C6 (NOAA-EMC#3558)
  Update gdas.cd hash to resolve msu prod_util failure (NOAA-EMC#3556)
  COMIN/COMOUT updates for enkf chgres and downstream product jobs (NOAA-EMC#3518)
  Call err_chk in forecast scripts for fatal errors (NOAA-EMC#3515)
  Add Rocoto Jobs for the Missing Products of GEFS (NOAA-EMC#3466)
  Download subset fix data with python script (NOAA-EMC#3400)
  Check that partition should be set (NOAA-EMC#3543)
  Rename wave output and refactor some wave scripts to use MPMD, and fix some bugzillas along the way (NOAA-EMC#3517)
  Add support for dual batch partitions on AWS NOAA-EMC#3483
  Update CI build and run directories for GitLab Nightlies on C6 and added GitLab support on Hera (NOAA-EMC#3536)
  Hotfix path for CI in Jenkins on Gaea C6 to it's world-share path (NOAA-EMC#3532)
  Create single ocean grib2 product file (NOAA-EMC#3529)
  Scheduled Nightly CI/CD Pipeline Script in GitLab on Gaea C6 (NOAA-EMC#3493)
  make sure cold starts are handled correctly when DOIAU=YES (issue NOAA-EMC#3516) (NOAA-EMC#3520)
  Add check for DO_AERO_FCST before copying fv_tracer files (NOAA-EMC#3485)
  Use jinja templates instead of `@VARNAME@` in config files (NOAA-EMC#3411)
  Replace "status" (or comparable) with "err" in preparation for moving to err_chk/err_exit (NOAA-EMC#3507)
  Error in Java launch script for CI (NOAA-EMC#3465)
  Delete DATAROOT when running generate_workflows.sh (NOAA-EMC#3504)
  Fix 3244 garbled change (NOAA-EMC#3492)
  Enable ensemble archiving via Globus (NOAA-EMC#3479)
  Update MSU FIX_DIR paths (NOAA-EMC#3488)
  Updates for AOWCDA and hybatmaerosnowDA cases on Gaea C6 (NOAA-EMC#3487)
  Update GOCART path for GDAS/GFS/GCAFS implementations  (NOAA-EMC#3455)
  Make RUN Variables Explicit in `config.resources` (NOAA-EMC#3478)
  Remove unused key from enkfgdas_earc_vrfy (NOAA-EMC#3473)
  Bug fix to the failing early cycle marine DA ensemble re-centering (NOAA-EMC#3454)
  Make marine LETKF optional (NOAA-EMC#3462)
  When sourcing for RUN=enkf*, use CASE_ENS (NOAA-EMC#3475)
  Updates for Gaea: verif-global tag, tracker tag, Fit2Obs tag, and C768 analysis resources (NOAA-EMC#3463)
  Update gefswave glo_025 mesh file with new mask (NOAA-EMC#3457)
  Update MSU glopara paths to new role-global space (NOAA-EMC#3443)
  Enable CI testing on AWS (NOAA-EMC#3459)
  Enable Gaea C5 Jenkins CI (NOAA-EMC#3447)
  Job reference removal from WMO product names (NOAA-EMC#3460)
  Turn off aerosol prognostic radiative feedback for GDAS NOAA-EMC#2926 (NOAA-EMC#3445)
  Add DO_GEMPAK check to postsnd subtask (NOAA-EMC#3451)
  Add a force option to setup_xml to ignore unwritable directories (NOAA-EMC#3448)
  Remove the eomg job (NOAA-EMC#3331)
  Migration to role account for Jenkins on Orion (NOAA-EMC#3440)
  Eliminate `_gfs`, `_gdas`, etc, variables and add necessary if blocks (NOAA-EMC#3420)
  Update workflow staging for sfcanl tiles and waveinit (NOAA-EMC#3429)
  Improve messaging to display clear warning when missing snogrb file (NOAA-EMC#3317)
  JEDI-based ensemble recentering and analysis calculation (NOAA-EMC#3312)
  Enable HPSS archiving on C5/6 (NOAA-EMC#3437)
  Check if HOMEDIR STMP and PTMP are writable (NOAA-EMC#3430)
  Update UFS_Utils and GFS-utils hashes to update Gaea support and ocean/ice post products (NOAA-EMC#3433)
  Enable C1152 forecasts on gaea C6 (NOAA-EMC#3438)
  Migration to role account for Jenkins on Hercules (NOAA-EMC#3423)
  Remove Direct Linking to COM from DATA for `extractvars` Job (NOAA-EMC#3379)
  Enable HPSS via Globus on Hercules and Orion
  Remove job name from product files & update GEMPAK module. (NOAA-EMC#3415)
  `link` instead of `copy` in staging jobs (NOAA-EMC#3410)
  Migrate CI Jenkins to role account on Hera (NOAA-EMC#3414)
  Add rocotorc documentation when using scrontab (NOAA-EMC#3417)
  Update jgdas atmos verfozn and verfrad with COMIN/COMOUT prefix instead of COM (NOAA-EMC#3342)
  Add configuration for empirically-corrected ozone parameters (NOAA-EMC#3386)
  Enable global-workflow to run C768C384 GSI on Gaea-C6 (NOAA-EMC#3412)
  Move logical checks into if blocks (NOAA-EMC#3339)
  Adding Jenkins CI to GaeaC6 using role account (NOAA-EMC#3389)
  Enable GDASApp g-w CI cases to run on wcoss2 (NOAA-EMC#3399)
  CI/CD Test on Gaea C5- And update config.gaea under ci/platform (NOAA-EMC#3280)
  Enable cycling support for Gaea C6 (NOAA-EMC#3323)
  Update enkf archive jobs to use COMIN/COMOUT (NOAA-EMC#3393)
  Copy marine ensemble output observation diags and spread (NOAA-EMC#3407)
  Ci testing on aws 2 (NOAA-EMC#3408)
  Disable METplus jobs on Hera (NOAA-EMC#3403)
  Add the mean EnKF soil increment to the deterministic member (NOAA-EMC#3295)
  Add mpich/8.1.19 to the WCOSS2 LD_LIBRARY_PATH for GDASApp jobs (NOAA-EMC#3396)
  Change order of RUNs (NOAA-EMC#3335)
  CI testing on aws (NOAA-EMC#3391)
  Rename Gulf of Mexico in bufr station list in GFSv17 (NOAA-EMC#3384)
  Enabling AWS CI/testing (NOAA-EMC#3383)
  Update issue templates to use new issue type field (NOAA-EMC#3369)
  Replace WAVECUR_DID variable with "rtofs" (NOAA-EMC#3337)
  Allow for C1152 ATM-Aero cycled DA to run on WCOSS2 (NOAA-EMC#3309)
  Remove Direct Linking to COM from DATA for `wavepostsbs` Job (NOAA-EMC#3303)
  Update jgdas enkf update job with COMIN or COMOUT prefix instead of COM (NOAA-EMC#3333)
  Add capability to run diff resolutions for marine anl and background (NOAA-EMC#3238)
  Update high resolution tests and fix minor wave issues  (NOAA-EMC#3289)
  Add sfs as valid system (NOAA-EMC#3243)
  Add missing arch_tars dependencies (NOAA-EMC#3319)
  Fix the empty aerosol DA aerostat tar file issue (NOAA-EMC#3332)
  Add missing file safeguard for IMS prep in snow analysis tasks (NOAA-EMC#3329)
  Fix memory unsetting on Gaea (NOAA-EMC#3325)
  Fix error log parsing in compute build CI (NOAA-EMC#3301)
  Remove marineanlvrfy task from global-workflow (NOAA-EMC#3314)
  Add `gfs_wavepostpnt` dependencies to gfs_cleanup (NOAA-EMC#3313)
  Increase the GDASApp build wallclock (NOAA-EMC#3298)
  Capture build fail in Jenkins pipeline when no error logs are produced (NOAA-EMC#3297)
  Add/update config files for Gaea and check existence before sourcing config files in generate_workflows.sh (NOAA-EMC#3286)
  Fix ocean restarts when cold starting with DOIAU=YES (NOAA-EMC#3278)
  Splitting up the archive task (NOAA-EMC#3242)
  CTests extended validation for C48_ATM and staged C48_S2SW for gfs_fcst and gfs_atmos (NOAA-EMC#3256)
  Add esnowanl to enkfgfs cycle (NOAA-EMC#3283)
  Add gfs cycles to C48mx500_3DVarAOWCDA (NOAA-EMC#3249)
  Add fetch job and update stage_ic to work with fetched ICs (NOAA-EMC#3141)
  Remove WAFS files and references from `develop` (NOAA-EMC#3263)
  fix intel stack version number on c5 (NOAA-EMC#3258)
  Update gsi_monitor and ufs_utils hashes to recent hashes for C5/C6 build and run (NOAA-EMC#3252)
  Enable DA cycling on gaea C5/C6 (NOAA-EMC#3255)
  Copy post-processed sea ice increment for diagnostics (NOAA-EMC#3235)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CoryMartin-NOAA CoryMartin-NOAA CoryMartin-NOAA approved these changes

@DavidHuber-NOAA DavidHuber-NOAA DavidHuber-NOAA approved these changes

Assignees

@DavidGrumm-NOAA DavidGrumm-NOAA

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DavidGrumm-NOAA @DavidHuber-NOAA @CoryMartin-NOAA