Add the setting to use the reject list for station t/q observations in GSI based soil DA by jiaruidong2017 · Pull Request #3599 · NOAA-EMC/global-workflow

jiaruidong2017 · 2025-04-19T01:01:26Z

Description

This PR adds the setting to read and apply the reject list for removing the t/q observations from prepbufr file in GSA based soil DA.

Refs NOAA-EMC/GSI-fix#35, which will be updated in NOAA-EMC/GSI#866
Resolves #3546

Type of change

Bug fix (fixes something broken)
New feature (adds functionality)
Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

Is this a breaking change (a change in existing functionality)? NO
Does this change require a documentation update? NO
Does this change require an update to any of the following submodules? YES (If YES, please add a link to any PRs that are pending.)
- EMC verif-global
- GDAS
- GFS-utils
- GSI-fix Add the reject list for station t/q observations for GSI based soil DA GSI-fix#35
- GSI-monitor
- GSI-utils
- UFS-utils
- UFS-weather-model
- wxflow

How has this been tested?

Cycled test on Orion

Checklist

KateFriedman-NOAA

Looks good, thanks @jiaruidong2017 ! Approve pending successful completion of CI testing.

KateFriedman-NOAA · 2025-04-28T19:13:29Z

@jiaruidong2017 please sync your PR branch with develop and resolve the shellcheck error that is getting flagged. Then we can run CI on this, thanks!

jiaruidong2017 · 2025-04-28T19:38:57Z

Thanks @KateFriedman-NOAA reminder. Done as suggested.

KateFriedman-NOAA

Approve pending successful completion of CI.

RussTreadon-NOAA · 2025-04-30T18:12:15Z

Attention: @jiaruidong2017 and @KateFriedman-NOAA

g-w CI case C96C48_hybatmDA fails on Hercules when running 20211221 00Z gdas_anal with the error

77: forrtl: severe (9): permission to access file denied, unit 19, file /work2/noaa/stmp/role-da/HERCULES/RUNDIRS/C96C48_hybatmDA/gdas.2021122100/anal.3663509/blacklist
77: Image              PC                Routine            Line        Source
77: gsi.x              0000000002216395  Unknown               Unknown  Unknown
77: gsi.x              0000000000D4FF6C  blacklist_mp_blac         105  blacklist.f90
77: gsi.x              0000000000961D33  read_prepbufr_            610  read_prepbufr.f90
77: gsi.x              000000000094EB1C  read_obsmod_mp_re        1474  read_obs.F90
77: gsi.x              0000000000861B72  observermod_mp_se         329  observer.F90
77: gsi.x              000000000105B243  glbsoi_                   221  glbsoi.f90
77: gsi.x              000000000068D227  gsisub_                   200  gsisub.F90
77: gsi.x              000000000041519D  gsimod_mp_gsimain        2445  gsimod.F90
77: gsi.x              00000000004150DF  MAIN__                    633  gsimain.f90

File /work2/noaa/stmp/role-da/HERCULES/RUNDIRS/C96C48_hybatmDA/gdas.2021122100/anal.3663509/blacklist in the run directory is a soft link to /work2/noaa/da/role-da/CI/hercules/GDASApp/workflow/PR/1642/global-workflow/fix/gsi/rejectlist_global.txt. The $HOMEgfs/fix/gsi is, in turn, a soft link to /work2/noaa/global/role-global/fix/gsi/20241022. This directory does not contain a reject list for global applications.

This PR added the blacklist to [scripts/exglobal_atmos_analysis.sh](https://github.com/NOAA-EMC/global-workflow/pull/3599/files#diff-1dd3053f4de883455cda6aff8811823ab5d24c9ac0c4443dda70a230bfd0e6a0), but this file is not in the EIB staged gsi fix on Hercules.

Cactus /lfs/h2/emc/global/noscrub/emc.global/FIX/fix/gsi/20241022 contains a zero length rejectlist_global.txt. The file was created Apr 28 20:57. Perhaps emc.global created this zero length file when C96C48_hybatmDA ran.

Did adding rejectlist_global.txt to the EIB staged gsi fix slip through the cracks?

KateFriedman-NOAA · 2025-04-30T18:20:31Z

Did adding rejectlist_global.txt to the EIB staged gsi fix slip through the cracks?

@RussTreadon-NOAA looks like it, this is on me, I should have circled back to get that file. Where should I pull it from and can it go into the 20241022 timestamp copy of fix/gsi?

Cactus /lfs/h2/emc/global/noscrub/emc.global/FIX/fix/gsi/20241022 contains a zero length rejectlist_global.txt. The file was created Apr 28 20:57. Perhaps emc.global created this zero length file when C96C48_hybatmDA ran.

Possibly and that actually concerns me. Nothing should write to the FIX_DIR. I'll look into this, although the output from the CI test on WCOSS2 for this PR have already been removed.

RussTreadon-NOAA · 2025-04-30T18:26:00Z

Thank you @KateFriedman-NOAA for the quick reply. We (DA team) should check to ensure fix files are in the appropriate directories. There are too many moving pieces for EIB to keep tabs on everything.

Since rejectlist_global.txt is a new file, I think we can place it in the existing 20241022 directory. What do you think @jiaruidong2017?

@jiaruidong2017 , please work with Kate to get the proper GSI fix file(s) into the EIB staged directory.

KateFriedman-NOAA · 2025-04-30T18:28:30Z

I think we can place it in the existing 20241022 directory.

I agree @RussTreadon-NOAA. @jiaruidong2017 please let me know where I should get the new rejectlist_global.txt file? Is it this? https://github.com/NOAA-EMC/GSI-fix/blob/develop/rejectlist_global.txt

CoryMartin-NOAA · 2025-04-30T18:30:38Z

@KateFriedman-NOAA yes that should be the file in question and I agree it can go in the existing fix directory, no need to update everything

KateFriedman-NOAA · 2025-04-30T18:31:58Z

@KateFriedman-NOAA yes that should be the file in question and I agree it can go in the existing fix directory, no need to update everything

Thanks @CoryMartin-NOAA ! I'll pull that into the fix/gsi/20241022 set immediately. Will need to check to make sure the job isn't going to write to that folder when running though...

KateFriedman-NOAA · 2025-04-30T18:38:35Z

Copied into fix/gsi/20241022 on Hera:

18:37:53 20241022/$pwd
/scratch1/NCEPDEV/global/glopara/fix/gsi/20241022
18:37:54 20241022/$ll rejectlist_global.txt 
-rw-r--r-- 1 role.glopara global 58 Apr 30 18:37 rejectlist_global.txt
18:37:56 20241022/$cat rejectlist_global.txt 
!IOTYPE  ikx stn_id
 t       181 71464
 q       181 71464

Can someone confirm the file is correct? Thanks!

CoryMartin-NOAA · 2025-04-30T18:40:22Z

That looks correct, it's simple (as of now) and just one station.

Looking at the code, I think GSI may need a change to be safer and not open that file if it doesn't exist:
https://github.com/NOAA-EMC/GSI/blob/95b8e3cba7594f8d0661624afe95293b812f767b/src/gsi/blacklist.f90#L105

My new friend GitHub Copilot says we should do:
open(iblktbl, file='blacklist', form='formatted', action='read')
because otherwise I think this will open/create the file if it doesn't exist

@RussTreadon-NOAA thoughts?

jiaruidong2017 · 2025-04-30T18:42:19Z

Thanks @CoryMartin-NOAA for the information and confirmation. That simple file is correct, and we will add more stations in the future.

jiaruidong2017 · 2025-04-30T18:47:00Z

@KateFriedman-NOAA In addition, the prepobs_errtable.global in the /scratch1/NCEPDEV/global/glopara/fix/gsi/20241022/ also needs to be replaced by the new version in the GSI-fix.

KateFriedman-NOAA · 2025-04-30T18:49:04Z

I have copied the GSI fix file to all supported platforms:

WCOSS2 (BACKUPSYS-C) FIX> pwd
/lfs/h2/emc/global/noscrub/emc.global/FIX
WCOSS2 (BACKUPSYS-C) FIX> ll fix/gsi/20241022/rejectlist_global.txt
-rw-r--r-- 1 emc.global global 58 Apr 30 18:37 fix/gsi/20241022/rejectlist_global.txt

WCOSS2 (PRIMARYSYS-D) FIX> pwd
/lfs/h2/emc/global/noscrub/emc.global/FIX
WCOSS2 (PRIMARYSYS-D) FIX> ll fix/gsi/20241022/rejectlist_global.txt
-rw-r--r-- 1 emc.global global 58 Apr 30 18:37 fix/gsi/20241022/rejectlist_global.txt

[role-global@hercules-login-2 role-global]$ pwd
/work2/noaa/global/role-global
[role-global@hercules-login-2 role-global]$ ll fix/gsi/20241022/rejectlist_global.txt
-rw-r--r-- 1 role-global global 58 Apr 30 13:37 fix/gsi/20241022/rejectlist_global.txt

role.glopara@gaea61:/gpfs/f6/drsa-precip3/world-shared/role.glopara> pwd
/gpfs/f6/drsa-precip3/world-shared/role.glopara
role.glopara@gaea61:/gpfs/f6/drsa-precip3/world-shared/role.glopara> ll fix/gsi/20241022/rejectlist_global.txt
-rw-r--r-- 1 role.glopara ncep 58 Apr 30 14:37 fix/gsi/20241022/rejectlist_global.txt

CoryMartin-NOAA · 2025-04-30T18:49:54Z

ah @jiaruidong2017 brings up a good point, this will require a new fix version. We should do a new PR that updates the error table + updates the GSI hash to be more robust when reading the station reject list file.

KateFriedman-NOAA · 2025-04-30T18:52:23Z

a new fix version. We should do a new PR that updates the error table + updates the GSI hash to be more robust when reading the station reject list file.

@CoryMartin-NOAA works for me! Let me know when/where to get the new error table from. Thanks!

RussTreadon-NOAA · 2025-04-30T18:59:03Z

@CoryMartin-NOAA . good catch. You are correct. I checked the Intel fortran compiler developer guide. The default action is READWRITE. This likely explains the observed behavior on WCOSS2. The file did not originally exist. gsi.x opened a non-existent file in READWRITE mode and in the process created a zero-length file. Specifying the action is definitely safer.

Where and how can we access your new friend GitHub Copilot? If possible, I'd like to befriend your friend.

KateFriedman-NOAA · 2025-04-30T18:59:50Z

@CoryMartin-NOAA the workflow team has suspended all CI testing until we get this fixed (so we don't potentially overwrite the new fix file I just pulled in during other testing). I'm available to test the change in the workflow and push this change into develop as soon as it's ready, thanks!

CoryMartin-NOAA · 2025-04-30T19:03:24Z

ok @KateFriedman-NOAA I'll prioritize this and work with @RussTreadon-NOAA to fix it.

@RussTreadon-NOAA in your GitHub settings you can sign up for free Copilot, then once you do, you can talk to it like ChatGPT and you can click individual lines in GitHub and ask it questions (that's what I did for this)

jiaruidong2017 · 2025-04-30T19:03:39Z

@KateFriedman-NOAA The file was updated in the GSI-fix repo or updated in the develop branch of $(HOMEgfs)/sorc/gsi_enkf.fd/fix/ in global-workflow.

I have a copy at /scratch1/NCEPDEV/global/Jiarui.Dong/JEDI/GlobalWorkflow/global-workflow/sorc/gsi_enkf.fd/fix/prepobs_errtable.global

KateFriedman-NOAA · 2025-04-30T19:04:15Z

I'll prioritize this and work with @RussTreadon-NOAA to fix it.

Thanks @CoryMartin-NOAA !

KateFriedman-NOAA · 2025-04-30T19:11:51Z

@KateFriedman-NOAA The file was updated in the GSI-fix repo or updated in the develop branch of $(HOMEgfs)/sorc/gsi_enkf.fd/fix/ in global-workflow.

I have a copy at /scratch1/NCEPDEV/global/Jiarui.Dong/JEDI/GlobalWorkflow/global-workflow/sorc/gsi_enkf.fd/fix/prepobs_errtable.global

Thanks @jiaruidong2017 !

@jiaruidong2017 @CoryMartin-NOAA @RussTreadon-NOAA I have created a new fix/gsi/20250430 timestamp on Hera and placed the new rejectlist and errtable files in:

19:08:34 20250430/$pwd
/scratch1/NCEPDEV/global/glopara/fix/gsi/20250430
19:08:51 20250430/$ll rejectlist_global.txt 
-rw-r--r-- 1 role.glopara global 58 Apr 30 18:37 rejectlist_global.txt
19:09:14 20250430/$ll prepobs_errtable.global                                                                                        
-rw-r--r-- 1 role.glopara global 492799 Apr 30 18:59 prepobs_errtable.global

Please confirm this looks good ~~and I will sync the new 20250430 timestamp~~ I have gone ahead and synced the new timestamp to the other platforms and can update the files again if needed. A PR to update the GSI hash will also need to update gsi_ver in versions/fix.ver.

jiaruidong2017 · 2025-04-30T19:24:13Z

@KateFriedman-NOAA I checked prepobs_errtable.global and rejectlist_global.txt in /scratch1/NCEPDEV/global/glopara/fix/gsi/20250430/, and they both look good.

KateFriedman-NOAA · 2025-04-30T19:31:44Z

@KateFriedman-NOAA I checked prepobs_errtable.global and rejectlist_global.txt in /scratch1/NCEPDEV/global/glopara/fix/gsi/20250430/, and they both look good.

Awesome, thanks @jiaruidong2017 ! I have synced the new fix/gsi/20250430 timestamp to WCOSS2, MSU, Gaea C6, and AWS. Will make a new tarball on HPSS for it as well.

Update: Tarball of new fix/gsi/20250430 timestamp is now on HPSS:
/5year/NCEPDEV/emc-global/emc.glopara/fix/fix.gsi.20250430.tar.xz

RussTreadon-NOAA · 2025-04-30T20:41:16Z

@KateFriedman-NOAA : @CoryMartin-NOAA opened GSI PR #870 to add status='old' to the reject list open statement. I tested his change using g-w CI case C96C48_hybatmDA on Hercules. The modified code behaves as intended.

GSI PR #870 has been merged into GSI develop. The GSI hash to use is d635cb9.

KateFriedman-NOAA · 2025-04-30T20:43:02Z

The GSI hash to use is d635cb9.

Thanks for the update and new GSI hash @RussTreadon-NOAA ! I will open a PR into develop and ask you guys to review.

KateFriedman-NOAA · 2025-04-30T21:18:06Z

Issue #3625 opened and PR #3626 initiated.

* develop: Update GSI hash and GSI fix version to resolve bugs (NOAA-EMC#3626) Add missing marine DA files to archiving (NOAA-EMC#3596) Add a low resolution test to mimic GFSv17 cycling as much as possible (NOAA-EMC#3617) Add the setting to use the reject list for station t/q observations in GSI based soil DA (NOAA-EMC#3599) GitLab CI Framework for schedule PR cases and ctests on multi hosts (NOAA-EMC#3603) Avoid parallel restart I/O on WCOSS2 (NOAA-EMC#3615) Enables user toggling of GDASApp g-w ctests (NOAA-EMC#3587) COM variable updates for prep and some external downstream jobs (NOAA-EMC#3608) Remove MOS from system (NOAA-EMC#3612) Updates to enable soil DA (NOAA-EMC#3452) Unexport SHELLOPTS when running htar (NOAA-EMC#3601) Fix check for netcdf wave restart (NOAA-EMC#3594) Call err_chk/err_exit for fatal errors in post JJobs/ex-scripts (NOAA-EMC#3571) Remove support for Jet and S4 (NOAA-EMC#3572) Hotfix in GitLab pipline for Nightly (env MACHINE breaks build on head node) (NOAA-EMC#3578) [hotfix] Missed a path during merging develop (NOAA-EMC#3577) Prepare for ops readiness - part 1 (NOAA-EMC#3557) Update UFS weather-model to 20250328 hash (NOAA-EMC#3528) Fix SFS fcst config (NOAA-EMC#3574) Use err_chk in GDAS j-jobs (NOAA-EMC#3570) Perform compute builds on Gaea head nodes (NOAA-EMC#3560) Add initial capability to produce JEDI-based observation space summary stat files (NOAA-EMC#3471) Spread epos over more nodes on Hera to increase allocated memory (NOAA-EMC#3567) Create separate gists when multiple files are published on GitHub (NOAA-EMC#3551) Use err_chk in GSI J-Jobs and scripts (NOAA-EMC#3549) Add unified jinja obs list to marine DA (NOAA-EMC#3530) Save snow and aerosol analysis increments (and logs and YAMLs) every cycle (NOAA-EMC#3537) Add Dependencies to SFS Cleanup Job (NOAA-EMC#3559) Updates archiving to reflect current naming of marine anl output (NOAA-EMC#3541) Temporarily disable compute builds on C6 (NOAA-EMC#3558) Update gdas.cd hash to resolve msu prod_util failure (NOAA-EMC#3556) COMIN/COMOUT updates for enkf chgres and downstream product jobs (NOAA-EMC#3518) Call err_chk in forecast scripts for fatal errors (NOAA-EMC#3515) Add Rocoto Jobs for the Missing Products of GEFS (NOAA-EMC#3466) Download subset fix data with python script (NOAA-EMC#3400) Check that partition should be set (NOAA-EMC#3543) Rename wave output and refactor some wave scripts to use MPMD, and fix some bugzillas along the way (NOAA-EMC#3517) Add support for dual batch partitions on AWS NOAA-EMC#3483 Update CI build and run directories for GitLab Nightlies on C6 and added GitLab support on Hera (NOAA-EMC#3536) Hotfix path for CI in Jenkins on Gaea C6 to it's world-share path (NOAA-EMC#3532) Create single ocean grib2 product file (NOAA-EMC#3529) Scheduled Nightly CI/CD Pipeline Script in GitLab on Gaea C6 (NOAA-EMC#3493) make sure cold starts are handled correctly when DOIAU=YES (issue NOAA-EMC#3516) (NOAA-EMC#3520) Add check for DO_AERO_FCST before copying fv_tracer files (NOAA-EMC#3485) Use jinja templates instead of `@VARNAME@` in config files (NOAA-EMC#3411) Replace "status" (or comparable) with "err" in preparation for moving to err_chk/err_exit (NOAA-EMC#3507) Error in Java launch script for CI (NOAA-EMC#3465) Delete DATAROOT when running generate_workflows.sh (NOAA-EMC#3504) Fix 3244 garbled change (NOAA-EMC#3492) Enable ensemble archiving via Globus (NOAA-EMC#3479) Update MSU FIX_DIR paths (NOAA-EMC#3488) Updates for AOWCDA and hybatmaerosnowDA cases on Gaea C6 (NOAA-EMC#3487) Update GOCART path for GDAS/GFS/GCAFS implementations (NOAA-EMC#3455) Make RUN Variables Explicit in `config.resources` (NOAA-EMC#3478) Remove unused key from enkfgdas_earc_vrfy (NOAA-EMC#3473) Bug fix to the failing early cycle marine DA ensemble re-centering (NOAA-EMC#3454) Make marine LETKF optional (NOAA-EMC#3462) When sourcing for RUN=enkf*, use CASE_ENS (NOAA-EMC#3475) Updates for Gaea: verif-global tag, tracker tag, Fit2Obs tag, and C768 analysis resources (NOAA-EMC#3463) Update gefswave glo_025 mesh file with new mask (NOAA-EMC#3457) Update MSU glopara paths to new role-global space (NOAA-EMC#3443) Enable CI testing on AWS (NOAA-EMC#3459) Enable Gaea C5 Jenkins CI (NOAA-EMC#3447) Job reference removal from WMO product names (NOAA-EMC#3460) Turn off aerosol prognostic radiative feedback for GDAS NOAA-EMC#2926 (NOAA-EMC#3445) Add DO_GEMPAK check to postsnd subtask (NOAA-EMC#3451) Add a force option to setup_xml to ignore unwritable directories (NOAA-EMC#3448) Remove the eomg job (NOAA-EMC#3331) Migration to role account for Jenkins on Orion (NOAA-EMC#3440) Eliminate `_gfs`, `_gdas`, etc, variables and add necessary if blocks (NOAA-EMC#3420) Update workflow staging for sfcanl tiles and waveinit (NOAA-EMC#3429) Improve messaging to display clear warning when missing snogrb file (NOAA-EMC#3317) JEDI-based ensemble recentering and analysis calculation (NOAA-EMC#3312) Enable HPSS archiving on C5/6 (NOAA-EMC#3437) Check if HOMEDIR STMP and PTMP are writable (NOAA-EMC#3430) Update UFS_Utils and GFS-utils hashes to update Gaea support and ocean/ice post products (NOAA-EMC#3433) Enable C1152 forecasts on gaea C6 (NOAA-EMC#3438) Migration to role account for Jenkins on Hercules (NOAA-EMC#3423) Remove Direct Linking to COM from DATA for `extractvars` Job (NOAA-EMC#3379) Enable HPSS via Globus on Hercules and Orion Remove job name from product files & update GEMPAK module. (NOAA-EMC#3415) `link` instead of `copy` in staging jobs (NOAA-EMC#3410) Migrate CI Jenkins to role account on Hera (NOAA-EMC#3414) Add rocotorc documentation when using scrontab (NOAA-EMC#3417) Update jgdas atmos verfozn and verfrad with COMIN/COMOUT prefix instead of COM (NOAA-EMC#3342) Add configuration for empirically-corrected ozone parameters (NOAA-EMC#3386) Enable global-workflow to run C768C384 GSI on Gaea-C6 (NOAA-EMC#3412) Move logical checks into if blocks (NOAA-EMC#3339) Adding Jenkins CI to GaeaC6 using role account (NOAA-EMC#3389) Enable GDASApp g-w CI cases to run on wcoss2 (NOAA-EMC#3399) CI/CD Test on Gaea C5- And update config.gaea under ci/platform (NOAA-EMC#3280) Enable cycling support for Gaea C6 (NOAA-EMC#3323) Update enkf archive jobs to use COMIN/COMOUT (NOAA-EMC#3393) Copy marine ensemble output observation diags and spread (NOAA-EMC#3407) Ci testing on aws 2 (NOAA-EMC#3408) Disable METplus jobs on Hera (NOAA-EMC#3403) Add the mean EnKF soil increment to the deterministic member (NOAA-EMC#3295) Add mpich/8.1.19 to the WCOSS2 LD_LIBRARY_PATH for GDASApp jobs (NOAA-EMC#3396) Change order of RUNs (NOAA-EMC#3335) CI testing on aws (NOAA-EMC#3391) Rename Gulf of Mexico in bufr station list in GFSv17 (NOAA-EMC#3384) Enabling AWS CI/testing (NOAA-EMC#3383) Update issue templates to use new issue type field (NOAA-EMC#3369) Replace WAVECUR_DID variable with "rtofs" (NOAA-EMC#3337) Allow for C1152 ATM-Aero cycled DA to run on WCOSS2 (NOAA-EMC#3309) Remove Direct Linking to COM from DATA for `wavepostsbs` Job (NOAA-EMC#3303) Update jgdas enkf update job with COMIN or COMOUT prefix instead of COM (NOAA-EMC#3333) Add capability to run diff resolutions for marine anl and background (NOAA-EMC#3238) Update high resolution tests and fix minor wave issues (NOAA-EMC#3289) Add sfs as valid system (NOAA-EMC#3243) Add missing arch_tars dependencies (NOAA-EMC#3319) Fix the empty aerosol DA aerostat tar file issue (NOAA-EMC#3332) Add missing file safeguard for IMS prep in snow analysis tasks (NOAA-EMC#3329) Fix memory unsetting on Gaea (NOAA-EMC#3325) Fix error log parsing in compute build CI (NOAA-EMC#3301) Remove marineanlvrfy task from global-workflow (NOAA-EMC#3314) Add `gfs_wavepostpnt` dependencies to gfs_cleanup (NOAA-EMC#3313) Increase the GDASApp build wallclock (NOAA-EMC#3298) Capture build fail in Jenkins pipeline when no error logs are produced (NOAA-EMC#3297) Add/update config files for Gaea and check existence before sourcing config files in generate_workflows.sh (NOAA-EMC#3286) Fix ocean restarts when cold starting with DOIAU=YES (NOAA-EMC#3278) Splitting up the archive task (NOAA-EMC#3242) CTests extended validation for C48_ATM and staged C48_S2SW for gfs_fcst and gfs_atmos (NOAA-EMC#3256) Add esnowanl to enkfgfs cycle (NOAA-EMC#3283) Add gfs cycles to C48mx500_3DVarAOWCDA (NOAA-EMC#3249) Add fetch job and update stage_ic to work with fetched ICs (NOAA-EMC#3141) Remove WAFS files and references from `develop` (NOAA-EMC#3263) fix intel stack version number on c5 (NOAA-EMC#3258) Update gsi_monitor and ufs_utils hashes to recent hashes for C5/C6 build and run (NOAA-EMC#3252) Enable DA cycling on gaea C5/C6 (NOAA-EMC#3255) Copy post-processed sea ice increment for diagnostics (NOAA-EMC#3235)

jiaruidong2017 added 2 commits April 18, 2025 20:21

Add the setting to read and apply the reject list for soil DA.

db6ed46

Merge with develop

8787e85

jiaruidong2017 requested review from CoryMartin-NOAA and RussTreadon-NOAA as code owners April 19, 2025 01:01

CoryMartin-NOAA reviewed Apr 21, 2025

View reviewed changes

Comment thread scripts/exglobal_atmos_analysis.sh Outdated

Change the name of reject list.

6873259

CoryMartin-NOAA previously approved these changes Apr 21, 2025

View reviewed changes

CoryMartin-NOAA requested review from CatherineThomas-NOAA, DavidHuber-NOAA and KateFriedman-NOAA April 21, 2025 13:04

Change the file name.

0e73c73

jiaruidong2017 dismissed CoryMartin-NOAA’s stale review via 0e73c73 April 21, 2025 14:54

KateFriedman-NOAA mentioned this pull request Apr 21, 2025

Update error table for surface T,Q observations #3546

Closed

4 tasks

jiaruidong2017 added 2 commits April 22, 2025 09:46

Merge branch 'develop' into feature/add_reject_list

feb7c28

Update GSI hash to include the new obs error table and reject list.

4c29981

KateFriedman-NOAA requested a review from CoryMartin-NOAA April 28, 2025 18:35

CoryMartin-NOAA previously approved these changes Apr 28, 2025

View reviewed changes

KateFriedman-NOAA previously approved these changes Apr 28, 2025

View reviewed changes

jiaruidong2017 added 2 commits April 28, 2025 15:27

Merge branch 'develop' into feature/add_reject_list

ca8da30

Add double quote to fix shellcheck warning

521c3c5

jiaruidong2017 dismissed stale reviews from CoryMartin-NOAA and KateFriedman-NOAA via 521c3c5 April 28, 2025 19:33

CoryMartin-NOAA approved these changes Apr 28, 2025

View reviewed changes

KateFriedman-NOAA approved these changes Apr 28, 2025

View reviewed changes

KateFriedman-NOAA added the CI-Wcoss2-Ready PR is ready for CI testing on WCOSS2. label Apr 28, 2025

emcbot added CI-Wcoss2-Building CI testing is cloning/building on WCOSS2 and removed CI-Wcoss2-Ready PR is ready for CI testing on WCOSS2. CI-Wcoss2-Building CI testing is cloning/building on WCOSS2 labels Apr 28, 2025

KateFriedman-NOAA merged commit 315b55b into NOAA-EMC:develop Apr 30, 2025
5 checks passed

RussTreadon-NOAA mentioned this pull request Apr 30, 2025

Dummy PR to test label-based CI NOAA-EMC/GDASApp#1642

Closed

6 tasks

CoryMartin-NOAA mentioned this pull request Apr 30, 2025

Ensure status is 'old' for blacklist NOAA-EMC/GSI#870

Merged

6 tasks

KateFriedman-NOAA mentioned this pull request Apr 30, 2025

[Bug] Issues resulting from PR #3599 changes #3625

Closed

jiaruidong2017 deleted the feature/add_reject_list branch October 17, 2025 16:26

Conversation

jiaruidong2017 commented Apr 19, 2025 • edited by KateFriedman-NOAA Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

Change characteristics

How has this been tested?

Checklist

Uh oh!

Uh oh!

KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

Uh oh!

KateFriedman-NOAA commented Apr 28, 2025

Uh oh!

jiaruidong2017 commented Apr 28, 2025

Uh oh!

KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

RussTreadon-NOAA commented Apr 30, 2025

Uh oh!

KateFriedman-NOAA commented Apr 30, 2025

Uh oh!

RussTreadon-NOAA commented Apr 30, 2025

Uh oh!

KateFriedman-NOAA commented Apr 30, 2025

Uh oh!

CoryMartin-NOAA commented Apr 30, 2025

Uh oh!

KateFriedman-NOAA commented Apr 30, 2025

Uh oh!

KateFriedman-NOAA commented Apr 30, 2025

Uh oh!

CoryMartin-NOAA commented Apr 30, 2025

Uh oh!

jiaruidong2017 commented Apr 30, 2025

Uh oh!

jiaruidong2017 commented Apr 30, 2025

Uh oh!

KateFriedman-NOAA commented Apr 30, 2025

Uh oh!

CoryMartin-NOAA commented Apr 30, 2025

Uh oh!

KateFriedman-NOAA commented Apr 30, 2025

Uh oh!

RussTreadon-NOAA commented Apr 30, 2025

Uh oh!

KateFriedman-NOAA commented Apr 30, 2025

Uh oh!

CoryMartin-NOAA commented Apr 30, 2025

Uh oh!

jiaruidong2017 commented Apr 30, 2025

Uh oh!

KateFriedman-NOAA commented Apr 30, 2025

Uh oh!

KateFriedman-NOAA commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jiaruidong2017 commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

KateFriedman-NOAA commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RussTreadon-NOAA commented Apr 30, 2025

Uh oh!

KateFriedman-NOAA commented Apr 30, 2025

Uh oh!

KateFriedman-NOAA commented Apr 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jiaruidong2017 commented Apr 19, 2025 •

edited by KateFriedman-NOAA

Loading

KateFriedman-NOAA commented Apr 30, 2025 •

edited

Loading

jiaruidong2017 commented Apr 30, 2025 •

edited

Loading

KateFriedman-NOAA commented Apr 30, 2025 •

edited

Loading