Deploy RC 349 to Production#9952
Merged
zachmargolis merged 16 commits intostages/prodfrom Jan 23, 2024
Merged
Conversation
Bumps [phonelib](https://github.com/daddyz/phonelib) from 0.8.6 to 0.8.7. - [Release notes](https://github.com/daddyz/phonelib/releases) - [Changelog](https://github.com/daddyz/phonelib/blob/master/CHANGELOG.md) - [Commits](daddyz/phonelib@v0.8.6...v0.8.7) --- updated-dependencies: - dependency-name: phonelib dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…9845) * add copy for feature changelog: User-facing Improvements, MFA, add inline device nickname editing for authenticator apps * modify list element * update strings and yml keys * create controller and form * create controller * add destroy for app auth deletion * create page to edit auth app nickname * create routes * enhance edit functionality * add tests for update nickname * create test for app auth update form * add test for app update form * fix functionality for deleting auth app * remove binding.pry, add test for renaming auth app * remove binding.pry, update validate_unique_name validator * create test for app auth deletion * create test for auth app controller api * fix test for unique name error * lintfix * update deletion test * fix test for update totp * removed unused keys * add test for auth apps show * add missing keys * Something is not right * update text for change nickname * fix lint * WIP: delete spec from account shows * remove test since show/hide feature is being done elsewhere
* WIP * working WIP * dummy logout * option. * cleanup * dynaimc update redirect uri * update local development doc * revert accidental change * revert accidental change. minor changes. changelog: Internal, Doc Auth, Test OIDC configuration for development. * clean up. * Editor reformatted markdown. * Doc update. * update based on comments.
* Update scripts/create-deploy-pr - Support $GITHUB_REPOSITORY to specify the repository. - Only check $GH_TOKEN present when running in CI - Figure out $GITHUB_SHA automatically when running locally - Use tmp/ for temporary files * Update scripts/create-release - Allow running locally while still verifying prereqs present in CI - Add DRY_RUN support to prevent making changes while testing - Use tmp/ for temporary files - Support $GITHUB_REPOSITORY to specify which repo to use * Say GIT_REMOTE instead of ORIGIN * create-deploy-pr: Add FORMAT_CHANGELOG env Allow specifying a command to pipe changelog to for additional formatting * create-deploy-pr: create label if it does not exist * create-deploy-pr: don't die if no releases found * create-deploy-pr: Clean up output a little * create-deploy-pr: Convert git remote URLs to lowercase * Remove Github Actions workflows for now * Use $GH_REPO instead of $GITHUB_REPOSITORY gh recognizes $GH_REPO and will use it so you don't always have to specify --repo * changelog: Internal, Deployment, Add local scripts to help with deployment
…r account reset to make more sense (#9905)
* Replace Welcome template with GettingStarted 2-page template * Update translations * Remove unused tags * Update welcome feature spec * changelog changelog: User-facing Improvements, Identity Verification Welcome page, update content * Clean up locale yaml files * Fix spec that checks Welcome page heading * update view spec to match translation tag changes * unused i18n-tasks --------- Co-authored-by: Alex Bradley <alexander.bradley@gsa.gov>
* changelog: User-Facing Improvements, Authentication, MFA redirect for F/T unlock * include application helper * add ft unlock check in session * add spec for authentication controller * spec and address comments * linting * fix spec * hidden spec * add to session * mock browser cache for specs * new session spec * create component * check support * use form for hidden * rename and refactor package * move verification * chang back to hidden field tag * set text * LG-11433: default * only check if has key * make sure to properly check session * make sure to sign in eligible for webauthn platform * remember device set back * webauthn spec js enabled * default hidden value in frontend * use existing method to set hidden field * set hidden field added to session helper * include proper javascript enabled * put back tests in right format * address comments * fix lint
* remove state id specific specs from in_person_spec and move to the state_id_spec file * remove duplicate include * fix heading text spec * add transliteration to address feature spec * update transliteration spec in state id step file * add spec for state specific hint * update function name and remove address test from state id step spec * add zip code validation to address spec * rename manual address spec to full form address * add spec that shows forms are prepopulated on update * update context name to be more accurate * remove some unnecessary comments * add dob validation spec to state id * remove comments * remove redundant text and move state id test from in person spec to state id spec * can move through flow when outage enabled * remove todos * changelog: Internal, Feature specs, improve in person proofing feature specs * add expectation for pre populated data * fix lint issues
* changelog: Internal, Doc Auth, Update all_passed? to consider selfie success
Technical notes:
- Since `all_passed?` is a private method, I created tests for the
method that calls it (`successful_result?`).
- Tests did not yet exist for this method, but rather than backfill
them I focused on selfie, assuming all other checks passed
- I found the values in `true_id_request_spec.rb` for
`PORTRAIT_MATCH_RESULT` were off - (according to our documentation)[https://drive.google.com/file/d/1MmXMYkFqPsn2VMbsMVYAUyC-amLRHVCp/view],
(pg 228) FaceMatchResult will either return `Pass` or `Fail`.
- Because `selfie_success` can return `nil` if selfie is not performed,
and because we don't want it to affect the outcome even if it somehow
did get a response of `false` when selfie capture was not enabled, we
simply return `true` if `liveness_checking_enabled` is `false`.
changelog: Internal, Translations, Remove extra translation
changelog: Internal, Database, Rename disposable_domains table to disposable_email_domains
changelog: Internal, Documentation, Add missing parameter to user registration analytics event
changelog: Internal, Database, Rename disposable_domains table to disposable_email_domains
* changelog: User-Facing Improvements, Controller Updates, Webauthn Setup controller updates * address comments * refactor error messaging for presence objects * update for cleaner generic message * fix styling * setup form spec
…9857) * Removing extraneous comma * Linting * changelog: Internal, In-Person Proofing, remove double address verfication from jobs * Add default value to dav input arg * Since default val of nil is set for dav in resolution proofing job don't add dav in agent job call. * Removed DAV from main code and specs * linfix * Merge in main, add new spec, update other specs, lint * Get resolution proofing job to passing * Pushing changes for pairing * Revert "Pushing changes for pairing" This reverts commit ff6128a. After reviewing the spec these tests are not necessary. * Small refactor to make remote and IPP flow spec separation clear * Added spec to address pii transformation during ipp flow * Remove unneccessary pii check and confirm resolution succeess * Adding specs and fixing appropriate pii * Update spec/services/idv/agent_spec.rb Stop disabling rubocop Co-authored-by: Matt Wagner <mattwagner@navapbc.com> * Fix alignment in args * Use MOCK pii instead of hash --------- Co-authored-by: Matt Wagner <mattwagner@navapbc.com>
aduth
approved these changes
Jan 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Upcoming Features
Internal