LG-11986: Modify the Welcome screen if selfie required#9944
Merged
Conversation
The first bullet is modified if a selfie check is required. changelog: Upcoming Features, Identity Verification, Updates the Welcome page if a selfie is required Co-authored-by: Alex Bradley <alexander.bradley@gsa.gov>
solipet
commented
Jan 19, 2024
| <%= render ProcessListComponent.new(heading_level: :h3, class: 'margin-y-3') do |c| %> | ||
| <%= c.with_item(heading: t('doc_auth.instructions.bullet1')) do %> | ||
| <p><%= t('doc_auth.instructions.text1') %></p> | ||
| <% if decorated_sp_session.selfie_required? %> |
Contributor
Author
There was a problem hiding this comment.
Note: selfie_required? not only checks that the SP requested a selfie, but also checks that the feature flag is enabled.
theabrad
approved these changes
Jan 19, 2024
Contributor
theabrad
left a comment
theabrad
left a comment
There was a problem hiding this comment.
LGTM! Tested locally and it shows the right content when selfie is enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-11986
🛠 Summary of changes
The first bullet on the Welcome page is modified if a selfie check is required.
📜 Testing Plan
To see this locally, hard code the method
NullServiceProviderSession#selfie_required?to return true.👀 Screenshots
Without selfie required (current view on `main`):
With selfie required: