Conversation
changelog: Internal, Doc Auth, Test OIDC configuration for development.
dawei-nava
requested review from
amirbey,
charleyf,
eileen-nava,
night-jellyfish and
zachmargolis
| - 'sp_sinatra_demo' | ||
| friendly_name: 'Example Test OIDC SP' | ||
| in_person_proofing_enabled: true | ||
|
|
There was a problem hiding this comment.
Should I add this or updating an existing one?
| end | ||
|
|
||
| def openid_configuration | ||
| @openid_configuration ||= OpenidConnectConfigurationPresenter.new.configuration |
There was a problem hiding this comment.
This is can be fetched at {root_url}/.well-known/openid-configuration, but due to Puma dev mode and RAILS_MAX_THREAD configuration(with value of 1), making a loop back request to the same server will cause deadlock.
| if @service_provider&.redirect_uris && !@service_provider.redirect_uris.include?(url) | ||
| @service_provider.redirect_uris.append(url) | ||
| changed = true | ||
| end |
There was a problem hiding this comment.
Developer machines can have various ips, add it dynamically so no manual intervention is needed.
|
I tested this out locally on both mobile and desktop and was able to choose the selfie flow, and upload an image (desktop) or use the SDK (mobile)! For transparency, I did not test the other links, I only tried the biometric option. I did not finish looking through all the code changes but plan to take another look tomorrow. |
amirbey
left a comment
amirbey
left a comment
There was a problem hiding this comment.
LGTM! 👍🏿
Ideally, I would prefer to add add https/ssl support to the oidc-sinatra app to avoid duplicating oidc-sinatra-app code in the IdP but from briefly poking around i didn't see a quick solution 🤔 . Ultimately, this will definitely make local development on mobile easier. Thanks Dawei 🙌🏿
4 participants
🛠 Summary of changes
Test OIDC controller to facilitate testing selfie features(enable/disable) on desktop or mobile platform.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
And start https