LG-12038: Update all_passed? to consider selfie success#9937
Merged
night-jellyfish merged 5 commits intomainfrom Jan 19, 2024
Merged
LG-12038: Update all_passed? to consider selfie success#9937night-jellyfish merged 5 commits intomainfrom
night-jellyfish merged 5 commits intomainfrom
Conversation
night-jellyfish
force-pushed
the
brittany/lg-12038-update-all-passed-method
branch
from
702d7b2 to
947cf1b
Compare
amirbey
reviewed
Jan 18, 2024
spec/services/doc_auth/lexis_nexis/responses/true_id_response_spec.rb
Outdated
Show resolved
Hide resolved
Technical notes:
- Since `all_passed?` is a private method, I created tests for the
method that calls it (`successful_result?`).
- Tests did not yet exist for this method, but rather than backfill
them I focused on selfie, assuming all other checks passed
- I found the values in `true_id_request_spec.rb` for
`PORTRAIT_MATCH_RESULT` were off - (according to our documentation)[https://drive.google.com/file/d/1MmXMYkFqPsn2VMbsMVYAUyC-amLRHVCp/view],
(pg 228) FaceMatchResult will either return `Pass` or `Fail`.
- Because `selfie_success` can return `nil` if selfie is not performed,
and because we don't want it to affect the outcome even if it somehow
did get a response of `false` when selfie capture was not enabled, we
simply return `true` if `liveness_checking_enabled` is `false`.
night-jellyfish
force-pushed
the
brittany/lg-12038-update-all-passed-method
branch
from
32469c1 to
4c980d8
Compare
night-jellyfish
deleted the
brittany/lg-12038-update-all-passed-method
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-12038
🛠 Summary of changes
Updates the
all_passed?method to take selfie success into account.Also updates testing / fixtures.