Merged
Conversation
solipet
approved these changes
Jan 18, 2024
Contributor
solipet
left a comment
solipet
left a comment
There was a problem hiding this comment.
ran in both main and the branch and confirmed the changes. I don't speak French or Spanish, but the translated pages appeared to be in those languages.
aduth
reviewed
Jan 22, 2024
Comment on lines
+47
to
+57
|
|
||
| <div class="margin-top-4"> | ||
| <%= render( | ||
| SpinnerButtonComponent.new( | ||
| type: :submit, | ||
| big: true, | ||
| wide: true, | ||
| spin_on_click: false, | ||
| ).with_content(t('doc_auth.buttons.continue')), | ||
| ) %> | ||
| </div> |
Contributor
There was a problem hiding this comment.
It seems like we shouldn't use a spinner button here if we don't intend for it to spin, but instead works as a normal submit button.
Suggested change
| <div class="margin-top-4"> | |
| <%= render( | |
| SpinnerButtonComponent.new( | |
| type: :submit, | |
| big: true, | |
| wide: true, | |
| spin_on_click: false, | |
| ).with_content(t('doc_auth.buttons.continue')), | |
| ) %> | |
| </div> | |
| <%= f.submit t('doc_auth.buttons.continue') %> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-11584
🛠 Summary of changes
Update Welcome template to use GettingStarted 2-page design, with updated translations and "Take photos of your ID" for the first bullet point.
Code was resurrected from prior delete PR #9660.
📜 Testing Plan
Note: Spanish translations use 'tu' (informal you) instead of 'su' (formal you). I assume the State Department translations will correct that as needed.
👀 Screenshots
After: